An easy-to-host PDS on the ATProtocol, iPhone and MacOS. Maintain control of your keys and data, always.
fix: address Phase 2 code review findings in oauth.rs
- Add Default impl for AppState delegating to Self::new() to fix clippy::new_without_default warning
- Add documenting comment above .lock().unwrap() in handle_deep_link explaining that panic on poison is intentional and represents a programming error with no safe recovery path
+8
+8
apps/identity-wallet/src-tauri/src/oauth.rs
+8
apps/identity-wallet/src-tauri/src/oauth.rs
···
30
30
}
31
31
}
32
32
33
+
impl Default for AppState {
34
+
fn default() -> Self {
35
+
Self::new()
36
+
}
37
+
}
38
+
33
39
// ── Pending flow (stub — filled out in Phase 5) ───────────────────────────────
34
40
35
41
/// State parked inside `AppState.pending_auth` while `start_oauth_flow` waits
···
76
82
77
83
// Phase 5: extract code+state, validate CSRF, send on oneshot channel.
78
84
// For now, just log that the callback arrived.
85
+
// Panic on poison: a panic while holding this lock is a programming error
86
+
// with no safe recovery path.
79
87
let _pending = app_state.pending_auth.lock().unwrap();
80
88
tracing::info!("pending_auth slot present: {}", _pending.is_some());
81
89