An easy-to-host PDS on the ATProtocol, iPhone and MacOS. Maintain control of your keys and data, always.
fix(identity-wallet): address code review feedback for Phase 1
- Remove unused `getRelayUrl` import from +page.svelte line 20. The function
is not called in the onMount logic; RelayConfigScreen handles relay URL
checking internally.
- Condense legacy user fallback comment block from 10 lines to 3 lines.
The comment was verbose and described a no-op — RelayConfigScreen already
handles the saved relay URL internally, so no additional onMount logic is
needed.
+4
-11
+4
-11
apps/identity-wallet/src/routes/+page.svelte
+4
-11
apps/identity-wallet/src/routes/+page.svelte
···
17
17
import HomeScreen from '$lib/components/home/HomeScreen.svelte';
18
18
import DIDDocumentScreen from '$lib/components/home/DIDDocumentScreen.svelte';
19
19
import RecoveryInfoScreen from '$lib/components/home/RecoveryInfoScreen.svelte';
20
-
import { createAccount, getRelayUrl, listIdentities, type CreateAccountError, type OAuthError, type HomeData } from '$lib/ipc';
20
+
import { createAccount, listIdentities, type CreateAccountError, type OAuthError, type HomeData } from '$lib/ipc';
21
21
22
22
// ── Onboarding step type ─────────────────────────────────────────────────
23
23
//
···
92
92
// listIdentities failed (e.g. empty Keychain on first launch) — continue to mode_select
93
93
}
94
94
95
-
// Legacy user fallback: if a relay URL is already configured (from the old
96
-
// single-identity flow before multi-identity), the user has used the app before
97
-
// but has no managed-dids entry. Skip relay_config but still show mode_select
98
-
// so they can choose create vs. import. Without this, legacy users would see
99
-
// mode_select and then relay_config (asking them to configure a relay they
100
-
// already configured).
101
-
// Note: mode_select is already the default step, so this is a no-op for
102
-
// mode_select itself, but it prevents the "Create new identity" path from
103
-
// redundantly showing relay_config when the relay is already configured.
104
-
// The relay_config screen itself already checks getRelayUrl() internally.
95
+
// Legacy users (relay URL configured but no managed-dids) stay at mode_select.
96
+
// RelayConfigScreen internally checks for saved relay URL, so the "Create new
97
+
// identity" path handles them correctly without additional logic here.
105
98
106
99
// Listen for auth_ready from relay OAuth (existing onboarding flow).
107
100
listen('auth_ready', () => {