+3

src/xrt/compositor/render/render_gfx.c

reviewed

··· 534 534 &rr->views[1].mesh.descriptor_set); // descriptor_set 535 535 VK_CHK_WITH_RET(ret, "vk_create_descriptor_set", false); 536 536 537 537 + // Used to sub-allocate UBOs from, restart from scratch each frame. 538 538 + render_sub_alloc_tracker_init(&rr->ubo_tracker, &r->gfx.shared_ubo); 539 539 + 537 540 return true; 538 541 } 539 542

+15

src/xrt/compositor/render/render_interface.h

reviewed

··· 388 388 389 389 struct 390 390 { 391 391 + /*! 392 392 + * Shared UBO buffer that we sub-allocate out of, this is to 393 393 + * have fewer buffers that the kernel needs to validate on 394 394 + * command submission time. 395 395 + * 396 396 + * https://registry.khronos.org/vulkan/site/guide/latest/memory_allocation.html 397 397 + */ 398 398 + struct render_buffer shared_ubo; 399 399 + } gfx; 400 400 + 401 401 + struct 402 402 + { 391 403 //! The binding index for the source texture. 392 404 uint32_t src_binding; 393 405 ··· 781 793 { 782 794 //! Resources that we are based on. 783 795 struct render_resources *r; 796 796 + 797 797 + //! Shared buffer that we sub-allocate UBOs from. 798 798 + struct render_sub_alloc_tracker ubo_tracker; 784 799 785 800 //! The current target we are rendering too, can change during command building. 786 801 struct render_gfx_target_resources *rtr;

+42

src/xrt/compositor/render/render_resources.c

reviewed

··· 657 657 658 658 659 659 /* 660 660 + * Gfx. 661 661 + */ 662 662 + 663 663 + { 664 664 + VkBufferUsageFlags usage_flags = VK_BUFFER_USAGE_UNIFORM_BUFFER_BIT; 665 665 + VkMemoryPropertyFlags memory_property_flags = // 666 666 + VK_MEMORY_PROPERTY_HOST_COHERENT_BIT | // 667 667 + VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT; // 668 668 + 669 669 + uint32_t num_buffers = 0; 670 670 + 671 671 + // Number of layer shader runs (views), number of layers, two UBOs per layer. 672 672 + num_buffers += RENDER_MAX_LAYER_RUNS * RENDER_MAX_LAYERS * 2; 673 673 + 674 674 + // Two mesh distortion runs with one UBO each. 675 675 + num_buffers += 2; 676 676 + 677 677 + // We currently use the aligmnent as max UBO size. 678 678 + static_assert(sizeof(struct render_gfx_mesh_ubo_data) <= RENDER_ALWAYS_SAFE_UBO_ALIGNMENT, "MAX"); 679 679 + 680 680 + // Calculate size. 681 681 + VkDeviceSize size = num_buffers * RENDER_ALWAYS_SAFE_UBO_ALIGNMENT; 682 682 + 683 683 + ret = render_buffer_init( // 684 684 + vk, // vk_bundle 685 685 + &r->gfx.shared_ubo, // buffer 686 686 + usage_flags, // usage_flags 687 687 + memory_property_flags, // memory_property_flags 688 688 + size); // size 689 689 + VK_CHK_WITH_RET(ret, "render_buffer_init", false); 690 690 + 691 691 + ret = render_buffer_map( // 692 692 + vk, // vk_bundle 693 693 + &r->gfx.shared_ubo); // buffer 694 694 + VK_CHK_WITH_RET(ret, "render_buffer_map", false); 695 695 + } 696 696 + 697 697 + 698 698 + /* 660 699 * Mesh static. 661 700 */ 662 701 ··· 961 1000 D(ImageView, r->mock.color.image_view); 962 1001 D(Image, r->mock.color.image); 963 1002 DF(Memory, r->mock.color.memory); 1003 1003 + 1004 1004 + render_buffer_close(vk, &r->gfx.shared_ubo); 1005 1005 + 964 1006 D(DescriptorSetLayout, r->mesh.descriptor_set_layout); 965 1007 D(PipelineLayout, r->mesh.pipeline_layout); 966 1008 D(PipelineCache, r->pipeline_cache);