The open source OpenXR runtime
d/wmr: Fix prober crash after failing to load fw
Fix a double-free. The wmr_hmd_create() method
already cleans up the hid devices on failure.
authored by
Jan Schmidt
and committed by
Jakob Bornecrantz
236e7324
87d804c7
+3
-3
+3
-3
src/xrt/drivers/wmr/wmr_prober.c
+3
-3
src/xrt/drivers/wmr/wmr_prober.c
···
339
339
340
340
if (hmd == NULL) {
341
341
U_LOG_IFL_E(log_level, "Failed to create WMR HMD device.");
342
-
goto error_companion;
342
+
/* No cleanup - the wmr_hmd_create() method cleaned up
343
+
* the hid devices already */
344
+
return XRT_ERROR_DEVICE_CREATION_FAILED;
343
345
}
344
346
345
347
#ifdef XRT_BUILD_DRIVER_HANDTRACKING
···
354
356
355
357
return XRT_SUCCESS;
356
358
357
-
error_companion:
358
-
os_hid_destroy(hid_companion);
359
359
error_holo:
360
360
os_hid_destroy(hid_holo);
361
361