The open source OpenXR runtime
a/gst: Explain why we require evenly-sized frames (NFC)
+3
+3
src/xrt/auxiliary/gstreamer/gst_sink.c
+3
src/xrt/auxiliary/gstreamer/gst_sink.c
···
55
55
static void
56
56
complain_if_wrong_image_size(struct xrt_frame *xf)
57
57
{
58
+
// libx264 is the actual source of this requirement; it refuses to handle odd widths/heights when encoding I420
59
+
// subsampled content. OpenH264 should work, but it's easy enough to just force all users of this code to
60
+
// provide normal-sized inputs.
58
61
if (xf->width % 2 == 1) {
59
62
U_LOG_W("Image width needs to be divisible by 2!");
60
63
}