The open source OpenXR runtime
a/vk: Disable naming of VkInstance objects
Mesa as of this patch doesn't currectly support setting debug names on
VkInstance. And the Vulkan loader had a bug before 1.3.261 that would cause
crashes if trying to set the name on VkInstance.
https://github.com/KhronosGroup/Vulkan-Loader/commit/faeb94c2df372557087c3ec77a52b772c0098b1f
+4
-1
+4
-1
src/xrt/auxiliary/vk/vk_helpers.h
+4
-1
src/xrt/auxiliary/vk/vk_helpers.h
···
649
649
* Some combinations of Vulkan implementation and types are broken, we still
650
650
* want type safety so we have this define. Examples of broken combinations:
651
651
*
652
+
* 1. Both Mesa and the Vulkan loader didn't support setting names on the
653
+
* VkInstance, loader got support in 1.3.261 and Mesa hasn't as of writing.
654
+
*
652
655
* @ingroup aux_vk
653
656
*/
654
657
#define VK_NAME_OBJ_DISABLED(VK, TYPE, OBJ) \
···
658
661
659
662
660
663
// clang-format off
661
-
#define VK_NAME_INSTANCE(VK, OBJ, NAME) VK_NAME_OBJ(VK, VkInstance, INSTANCE, OBJ, NAME)
664
+
#define VK_NAME_INSTANCE(VK, OBJ, NAME) VK_NAME_OBJ_DISABLED(VK, VkInstance, OBJ)
662
665
#define VK_NAME_PHYSICAL_DEVICE(VK, OBJ, NAME) VK_NAME_OBJ(VK, VkPhysicalDevice, PHYSICAL_DEVICE, OBJ, NAME)
663
666
#define VK_NAME_DEVICE(VK, OBJ, NAME) VK_NAME_OBJ(VK, VkDevice, DEVICE, OBJ, NAME)
664
667
#define VK_NAME_QUEUE(VK, OBJ, NAME) VK_NAME_OBJ(VK, VkQueue, QUEUE, OBJ, NAME)