The open source OpenXR runtime
0
fork

Configure Feed

Select the types of activity you want to include in your feed.

d/wmr: Document camera start and constify argument

+14 -9
+8 -8
src/xrt/drivers/wmr/wmr_camera.c
··· 66 66 struct os_thread_helper usb_thread; 67 67 int usb_complete; 68 68 69 - struct wmr_camera_config *configs; 70 - int n_configs; 69 + const struct wmr_camera_config *configs; 70 + int config_count; 71 71 72 72 size_t xfer_size; 73 73 uint32_t frame_width, frame_height; ··· 116 116 117 117 F = 26; 118 118 119 - for (i = 0; i < cam->n_configs; i++) { 120 - struct wmr_camera_config *config = cam->configs + i; 119 + for (i = 0; i < cam->config_count; i++) { 120 + const struct wmr_camera_config *config = &cam->configs[i]; 121 121 if (config->purpose != WMR_CAMERA_PURPOSE_HEAD_TRACKING) 122 122 continue; 123 123 ··· 364 364 } 365 365 366 366 bool 367 - wmr_camera_start(struct wmr_camera *cam, struct wmr_camera_config *cam_configs, int n_configs) 367 + wmr_camera_start(struct wmr_camera *cam, const struct wmr_camera_config *cam_configs, int config_count) 368 368 { 369 369 int res, i; 370 370 371 371 cam->configs = cam_configs; 372 - cam->n_configs = n_configs; 372 + cam->config_count = config_count; 373 373 if (!compute_frame_size(cam)) { 374 374 WMR_CAM_WARN(cam, "Invalid config or no head tracking cameras found"); 375 375 goto fail; ··· 383 383 if (res < 0) 384 384 goto fail; 385 385 386 - for (i = 0; i < cam->n_configs; i++) { 387 - struct wmr_camera_config *config = cam->configs + i; 386 + for (i = 0; i < cam->config_count; i++) { 387 + const struct wmr_camera_config *config = &cam->configs[i]; 388 388 if (config->purpose != WMR_CAMERA_PURPOSE_HEAD_TRACKING) 389 389 continue; 390 390
+6 -1
src/xrt/drivers/wmr/wmr_camera.h
··· 27 27 void 28 28 wmr_camera_free(struct wmr_camera *cam); 29 29 30 + /*! 31 + * Starts the cameras. 32 + * 33 + * The data pointed to by @p configs must be kept alive for as long as the camera is kept alive. 34 + */ 30 35 bool 31 - wmr_camera_start(struct wmr_camera *cam, struct wmr_camera_config *cam_configs, int n_configs); 36 + wmr_camera_start(struct wmr_camera *cam, const struct wmr_camera_config *configs, int config_count); 32 37 bool 33 38 wmr_camera_stop(struct wmr_camera *cam); 34 39 int