The open source OpenXR runtime
0
fork

Configure Feed

Select the types of activity you want to include in your feed.

st/oxr: Fix missing return, resolve warnings

+13 -11
+7 -7
src/xrt/state_trackers/oxr/oxr_space.c
··· 139 139 return true; 140 140 } 141 141 142 - bool 142 + XRT_CHECK_RESULT bool 143 143 is_local_space_set_up(struct oxr_session *sess) 144 144 { 145 145 return (sess->local_space_pure_relation.relation_flags & XRT_SPACE_RELATION_ORIENTATION_VALID_BIT) != 0; ··· 191 191 return true; 192 192 } 193 193 194 - bool 194 + XRT_CHECK_RESULT bool 195 195 oxr_space_pure_relation_in_space(struct oxr_logger *log, 196 196 XrTime time, 197 197 struct xrt_space_relation *relation, ··· 218 218 return true; 219 219 } 220 220 221 - bool 221 + XRT_CHECK_RESULT bool 222 222 oxr_space_pure_pose_in_space(struct oxr_logger *log, 223 223 XrTime time, 224 224 struct xrt_pose *pose, ··· 231 231 return oxr_space_pure_relation_in_space(log, time, &rel, spc, apply_space_pose, out_relation); 232 232 } 233 233 234 - bool 234 + XRT_CHECK_RESULT bool 235 235 oxr_space_pure_relation_from_space(struct oxr_logger *log, 236 236 XrTime time, 237 237 struct xrt_space_relation *relation, ··· 252 252 return true; 253 253 } 254 254 255 - bool 255 + XRT_CHECK_RESULT bool 256 256 oxr_space_pure_pose_from_space(struct oxr_logger *log, 257 257 XrTime time, 258 258 struct xrt_pose *pose, ··· 264 264 return oxr_space_pure_relation_from_space(log, time, &rel, spc, out_relation); 265 265 } 266 266 267 - bool 267 + XRT_CHECK_RESULT bool 268 268 oxr_space_get_pure_relation(struct oxr_logger *log, 269 269 struct oxr_space *spc, 270 270 XrTime time, ··· 296 296 return oxr_error(log, false, "Unknown space type"); 297 297 } 298 298 299 - bool 299 + XRT_CHECK_RESULT bool 300 300 global_to_local_space(struct oxr_logger *log, struct oxr_session *sess, XrTime time, struct xrt_space_relation *rel) 301 301 { 302 302 if (!is_local_space_set_up(sess)) {
+6 -4
src/xrt/state_trackers/oxr/oxr_vulkan.c
··· 231 231 "vkEnumerateDeviceExtensionProperties"); 232 232 233 233 if (!EnumerateDeviceExtensionProperties) { 234 - oxr_error(log, XR_ERROR_RUNTIME_FAILURE, "Failed to get vkEnumerateDeviceExtensionProperties fp"); 234 + return oxr_error(log, XR_ERROR_RUNTIME_FAILURE, 235 + "Failed to get vkEnumerateDeviceExtensionProperties fp"); 235 236 } 236 237 237 238 uint32_t prop_count = 0; 238 239 VkResult res = EnumerateDeviceExtensionProperties(physical_device, NULL, &prop_count, NULL); 239 240 if (res != VK_SUCCESS) { 240 - oxr_error(log, XR_ERROR_RUNTIME_FAILURE, "Failed to enumerate device extension properties count (%d)", 241 - res); 241 + return oxr_error(log, XR_ERROR_RUNTIME_FAILURE, 242 + "Failed to enumerate device extension properties count (%d)", res); 242 243 } 243 244 244 245 ··· 247 248 res = EnumerateDeviceExtensionProperties(physical_device, NULL, &prop_count, props); 248 249 if (res != VK_SUCCESS) { 249 250 free(props); 250 - oxr_error(log, XR_ERROR_RUNTIME_FAILURE, "Failed to enumerate device extension properties (%d)", res); 251 + return oxr_error(log, XR_ERROR_RUNTIME_FAILURE, "Failed to enumerate device extension properties (%d)", 252 + res); 251 253 } 252 254 253 255 *out_props = props;