+15 -4

src/xrt/state_trackers/oxr/oxr_objects.h

reviewed

··· 803 803 return XRT_CAST_PTR_TO_OXR_HANDLE(XrSwapchain, sc); 804 804 } 805 805 806 806 + /*! 807 807 + * Shared create function for swapchains, called by grahpics API specific 808 808 + * implementations list below. Does most init, but not @ref xrt_swapchain 809 809 + * allocation and other API specific things. 810 810 + * 811 811 + * @param log Logger set with the current OpenXR function call context. 812 812 + * @param sess OpenXR session 813 813 + * @param createInfo Creation info. 814 814 + * @param sc Swapchain. 815 815 + * @param[out] out_swapchain Return of the allocated swapchain. 816 816 + */ 806 817 XrResult 807 807 - oxr_create_swapchain(struct oxr_logger * /*log*/, 808 808 - struct oxr_session *sess, 809 809 - const XrSwapchainCreateInfo * /*createInfo*/, 810 810 - struct oxr_swapchain **out_swapchain); 818 818 + oxr_swapchain_common_create(struct oxr_logger *log, 819 819 + struct oxr_session *sess, 820 820 + const XrSwapchainCreateInfo *createInfo, 821 821 + struct oxr_swapchain **out_swapchain); 811 822 812 823 813 824 /*

+4 -4

src/xrt/state_trackers/oxr/oxr_swapchain.c

reviewed

··· 219 219 */ 220 220 221 221 XrResult 222 222 - oxr_create_swapchain(struct oxr_logger *log, 223 223 - struct oxr_session *sess, 224 224 - const XrSwapchainCreateInfo *createInfo, 225 225 - struct oxr_swapchain **out_swapchain) 222 222 + oxr_swapchain_common_create(struct oxr_logger *log, 223 223 + struct oxr_session *sess, 224 224 + const XrSwapchainCreateInfo *createInfo, 225 225 + struct oxr_swapchain **out_swapchain) 226 226 { 227 227 xrt_result_t xret = XRT_SUCCESS; 228 228

+1 -1

src/xrt/state_trackers/oxr/oxr_swapchain_d3d11.c

reviewed

··· 43 43 struct oxr_swapchain *sc; 44 44 XrResult ret; 45 45 46 46 - ret = oxr_create_swapchain(log, sess, createInfo, &sc); 46 46 + ret = oxr_swapchain_common_create(log, sess, createInfo, &sc); 47 47 if (ret != XR_SUCCESS) { 48 48 return ret; 49 49 }

+1 -1

src/xrt/state_trackers/oxr/oxr_swapchain_d3d12.c

reviewed

··· 51 51 XR_SWAPCHAIN_USAGE_UNORDERED_ACCESS_BIT, 52 52 XR_SWAPCHAIN_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT); 53 53 54 54 - ret = oxr_create_swapchain(log, sess, createInfo, &sc); 54 54 + ret = oxr_swapchain_common_create(log, sess, createInfo, &sc); 55 55 if (ret != XR_SUCCESS) { 56 56 return ret; 57 57 }

+1 -1

src/xrt/state_trackers/oxr/oxr_swapchain_gl.c

reviewed

··· 88 88 struct oxr_swapchain *sc; 89 89 XrResult ret; 90 90 91 91 - ret = oxr_create_swapchain(log, sess, createInfo, &sc); 91 91 + ret = oxr_swapchain_common_create(log, sess, createInfo, &sc); 92 92 if (ret != XR_SUCCESS) { 93 93 return ret; 94 94 }

+1 -1

src/xrt/state_trackers/oxr/oxr_swapchain_vk.c

reviewed

··· 41 41 struct oxr_swapchain *sc; 42 42 XrResult ret; 43 43 44 44 - ret = oxr_create_swapchain(log, sess, createInfo, &sc); 44 44 + ret = oxr_swapchain_common_create(log, sess, createInfo, &sc); 45 45 if (ret != XR_SUCCESS) { 46 46 return ret; 47 47 }