The open source OpenXR runtime
0
fork

Configure Feed

Select the types of activity you want to include in your feed.

xrt: Tidy xrt_instance_create argument order and add doc-comment

authored by

Jakob Bornecrantz and committed by
Jakob Bornecrantz
deedd10a 323d794d

+23 -19
+6 -2
src/xrt/include/xrt/xrt_instance.h
··· 226 226 * 227 227 * Each target must implement this function. 228 228 * 229 + * @param[in] ii A pointer to a info struct containing information about the 230 + * application. 229 231 * @param[out] out_xinst A pointer to an xrt_instance pointer. Will be 230 232 * populated. 231 233 * ··· 234 236 * @relates xrt_instance 235 237 */ 236 238 int 237 - xrt_instance_create(struct xrt_instance **out_xinst, 238 - struct xrt_instance_info *ii); 239 + xrt_instance_create(struct xrt_instance_info *ii, 240 + struct xrt_instance **out_xinst 241 + 242 + ); 239 243 240 244 /*! 241 245 * @}
+2 -2
src/xrt/ipc/ipc_client_instance.c
··· 183 183 * @public @memberof ipc_instance 184 184 */ 185 185 int 186 - ipc_instance_create(struct xrt_instance **out_xinst, 187 - struct xrt_instance_info *i_info) 186 + ipc_instance_create(struct xrt_instance_info *i_info, 187 + struct xrt_instance **out_xinst) 188 188 { 189 189 struct ipc_client_instance *ii = 190 190 U_TYPED_CALLOC(struct ipc_client_instance);
+1 -1
src/xrt/ipc/ipc_server_process.c
··· 384 384 s->running = true; 385 385 s->exit_on_disconnect = debug_get_bool_option_exit_on_disconnect(); 386 386 387 - int ret = xrt_instance_create(&s->xinst, NULL); 387 + int ret = xrt_instance_create(NULL, &s->xinst); 388 388 if (ret < 0) { 389 389 teardown_all(s); 390 390 return ret;
+1 -1
src/xrt/state_trackers/gui/gui_prober.c
··· 38 38 int ret = 0; 39 39 40 40 // Initialize the prober. 41 - ret = xrt_instance_create(&p->instance, NULL); 41 + ret = xrt_instance_create(NULL, &p->instance); 42 42 if (ret != 0) { 43 43 return do_exit(p, ret); 44 44 }
+1 -1
src/xrt/state_trackers/oxr/oxr_instance.c
··· 177 177 sizeof(inst->xinst->instance_info.application_name), "%s", 178 178 createInfo->applicationInfo.applicationName); 179 179 180 - xinst_ret = xrt_instance_create(&inst->xinst, &i_info); 180 + xinst_ret = xrt_instance_create(&i_info, &inst->xinst); 181 181 if (xinst_ret != 0) { 182 182 ret = oxr_error(log, XR_ERROR_RUNTIME_FAILURE, 183 183 "Failed to create prober");
+1 -1
src/xrt/targets/cli/cli_cmd_calibrate.c
··· 32 32 int ret; 33 33 34 34 // Fist initialize the instance. 35 - ret = xrt_instance_create(&p->xi, NULL); 35 + ret = xrt_instance_create(NULL, &p->xi); 36 36 if (ret != 0) { 37 37 fprintf(stderr, "Failed to create instance\n"); 38 38 return ret;
+1 -1
src/xrt/targets/cli/cli_cmd_probe.c
··· 36 36 // Initialize the prober. 37 37 printf(" :: Creating instance!\n"); 38 38 39 - ret = xrt_instance_create(&xi, NULL); 39 + ret = xrt_instance_create(NULL, &xi); 40 40 if (ret != 0) { 41 41 return do_exit(&xi, 0); 42 42 }
+1 -1
src/xrt/targets/cli/cli_cmd_test.c
··· 36 36 // Initialize the prober. 37 37 printf(" :: Creating instance!\n"); 38 38 39 - ret = xrt_instance_create(&xi, NULL); 39 + ret = xrt_instance_create(NULL, &xi); 40 40 if (ret != 0) { 41 41 return do_exit(&xi, 0); 42 42 }
+2 -2
src/xrt/targets/common/target_instance.c
··· 35 35 */ 36 36 37 37 int 38 - xrt_instance_create(struct xrt_instance **out_xinst, 39 - struct xrt_instance_info *i_info) 38 + xrt_instance_create(struct xrt_instance_info *i_info, 39 + struct xrt_instance **out_xinst) 40 40 { 41 41 struct xrt_prober *xp = NULL; 42 42
+2 -2
src/xrt/targets/common/target_instance_no_comp.c
··· 29 29 */ 30 30 31 31 int 32 - xrt_instance_create(struct xrt_instance **out_xinst, 33 - struct xrt_instance_info *i_info) 32 + xrt_instance_create(struct xrt_instance_info *i_info, 33 + struct xrt_instance **out_xinst) 34 34 { 35 35 struct xrt_prober *xp = NULL; 36 36
+5 -5
src/xrt/targets/openxr/target.c
··· 14 14 15 15 // Forward declaration 16 16 int 17 - ipc_instance_create(struct xrt_instance **out_xinst, 18 - struct xrt_instance_info *i_info); 17 + ipc_instance_create(struct xrt_instance_info *i_info, 18 + struct xrt_instance **out_xinst); 19 19 20 20 int 21 - xrt_instance_create(struct xrt_instance **out_xinst, 22 - struct xrt_instance_info *i_info) 21 + xrt_instance_create(struct xrt_instance_info *i_info, 22 + struct xrt_instance **out_xinst) 23 23 { 24 - return ipc_instance_create(out_xinst, i_info); 24 + return ipc_instance_create(i_info, out_xinst); 25 25 } 26 26 27 27 #else