+1

doc/proclamation/fixes/mr.247

reviewed

··· 1 1 + Fix crash due to bad dbus path, triggered by bad return checking when probing for BLE devices.

+3

src/xrt/auxiliary/os/os_ble.h

reviewed

··· 73 73 * Open the given mac and path to device endpoint (Currently Linux/BlueZ 74 74 * specific). 75 75 * 76 76 + * @returns Negative on failure, zero on no device found and positive if a 77 77 + * device has been found. 78 78 + * 76 79 * @ingroup aux_os 77 80 */ 78 81 int

+6 -1

src/xrt/auxiliary/os/os_ble_dbus.c

reviewed

··· 719 719 XRT_MAYBE_UNUSED ssize_t written = 720 720 get_path_to_notify_char(bledev->conn, dev_uuid, char_uuid, 721 721 dbus_address, sizeof(dbus_address)); 722 722 + if (written == 0) { 723 723 + return 0; 724 724 + } else if (written < 0) { 725 725 + return -1; 726 726 + } 722 727 723 728 msg = dbus_message_new_method_call( 724 729 "org.bluez", // target for the method call ··· 766 771 767 772 *out_ble = &bledev->base; 768 773 769 769 - return 0; 774 774 + return 1; 770 775 }