+1

constellation/readme.md

reviewed

··· 151 151 - [ ] write time hist 152 152 - [ ] read ops (api) 153 153 - [ ] expose internal stats? 154 154 + - [ ] figure out what's the right thing to do if merge op fails. happened on startup after an unclean reboot. 154 155 155 156 156 157 cache

+14 -5

constellation/src/storage/rocks_store.rs

reviewed

··· 271 271 } 272 272 273 273 fn merge_op_extend_did_ids( 274 274 - _new_key: &[u8], 274 274 + key: &[u8], 275 275 existing: Option<&[u8]>, 276 276 operands: &MergeOperands, 277 277 ) -> Option<Vec<u8>> { ··· 282 282 existing_linkers 283 283 } 284 284 Err(e) => { 285 285 - eprintln!("bug? could not deserialize existing target linkers: {e:?}"); 286 286 - return None; 285 285 + eprintln!("bug? could not deserialize existing target linkers: {e:?}. key={key:?}. continuing, but data will be lost!"); 286 286 + if existing_bytes.len() < 1000 { 287 287 + eprintln!("dropping: {existing_bytes:?}"); 288 288 + } else { 289 289 + eprintln!("(too long to print)"); 290 290 + } 291 291 + Vec::with_capacity(operands.len()) 287 292 } 288 293 } 289 294 } else { ··· 293 298 match _vr(new_linkers) { 294 299 Ok(TargetLinkers(new_linkers)) => linkers.extend(new_linkers), 295 300 Err(e) => { 296 296 - eprintln!("bug? could not deserialize new target linkrers: {e:?}"); 297 297 - return None; 301 301 + eprintln!("bug? could not deserialize new target linkrers: {e:?}. key={key:?}. continuing, but data will be lost!"); 302 302 + if new_linkers.len() < 1000 { 303 303 + eprintln!("skipping: {new_linkers:?}"); 304 304 + } else { 305 305 + eprintln!("(too long to print)"); 306 306 + } 298 307 } 299 308 } 300 309 }