this repo has no description
internal/ci: enforce vet and mod tidy on all modules
That is, both the root module and internal/e2e.
This would have caught our recent failures on master
due to internal/e2e not being tidied.
Updates #1630.
Signed-off-by: Daniel Martí <mvdan@mvdan.cc>
Change-Id: Ic22d0ae16ea17d748ca16383023b2ee1a9513196
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1171769
TryBot-Result: CUEcueckoo <cueckoo@cuelang.org>
Reviewed-by: Roger Peppe <rogpeppe@gmail.com>
Unity-Result: CUE porcuepine <cue.porcuepine@gmail.com>
+19
-2
+8
-1
.github/workflows/trybot.yml
+8
-1
.github/workflows/trybot.yml
···
193
193
GITHUB_TOKEN: ${{ secrets.E2E_GITHUB_TOKEN }}
194
194
- if: (matrix.go-version == '1.21.x' && matrix.runner == 'ubuntu-22.04')
195
195
name: Check
196
-
run: go vet ./...
196
+
run: |-
197
+
for module in . internal/e2e; do
198
+
(
199
+
cd $module
200
+
go vet ./...
201
+
go mod tidy
202
+
)
203
+
done
197
204
- name: Check that git is clean at the end of the job
198
205
run: test -z "$(git status --porcelain)" || (git status; git diff; false)
+11
-1
internal/ci/github/trybot.cue
+11
-1
internal/ci/github/trybot.cue
···
140
140
// However, CUE does not have any such build tags yet, and we don't use
141
141
// dependencies that vary wildly between platforms.
142
142
// For now, to save CI resources, just run the checks on one matrix job.
143
+
// We loop over all Go modules and use a subshell to run the commands in each directory;
144
+
// note that this still makes the script stop at the first command failure.
143
145
// TODO: consider adding more checks as per https://github.com/golang/go/issues/42119.
144
146
if: "\(_isLatestLinux)"
145
147
name: "Check"
146
-
run: "go vet ./..."
148
+
run: """
149
+
for module in . internal/e2e; do
150
+
(
151
+
cd $module
152
+
go vet ./...
153
+
go mod tidy
154
+
)
155
+
done
156
+
"""
147
157
}
148
158
149
159
_goTestRace: json.#step & {