this repo has no description
all: resolve a handful of linter warnings
cue/parser's use of astinternal is just in the tests,
so there's no need to import it in the non-test code.
There's also no reason to define a func variable.
Remove a few unused fields and one type.
In internal/core/export's test, use an underscore assignment
so that the debugValue constant doesn't trigger "unused" warnings.
Signed-off-by: Daniel Martí <mvdan@mvdan.cc>
Change-Id: Id117bb2e5a8c6fd6c7d01f7f7782719663a6fddb
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1195020
TryBot-Result: CUEcueckoo <cueckoo@cuelang.org>
Unity-Result: CUE porcuepine <cue.porcuepine@gmail.com>
Reviewed-by: Roger Peppe <rogpeppe@gmail.com>
+5
-11
-3
cue/parser/parser.go
-3
cue/parser/parser.go
+4
-3
cue/parser/parser_test.go
+4
-3
cue/parser/parser_test.go
···
20
20
"testing"
21
21
22
22
"cuelang.org/go/cue/ast"
23
+
"cuelang.org/go/internal/astinternal"
23
24
)
24
25
25
26
func TestParse(t *testing.T) {
···
685
686
mode = append(mode, ParseFuncs)
686
687
}
687
688
f, err := ParseFile("input", tc.in, mode...)
688
-
got := debugStr(f)
689
+
got := astinternal.DebugStr(f)
689
690
if err != nil {
690
691
got += "\n" + err.Error()
691
692
}
···
858
859
return true
859
860
}, nil)
860
861
if sel == nil {
861
-
t.Fatalf("found no *SelectorExpr: %#v %s", f.Decls[0], debugStr(f))
862
+
t.Fatalf("found no *SelectorExpr: %#v %s", f.Decls[0], astinternal.DebugStr(f))
862
863
}
863
864
const wantSel = "&{fmt _ {<nil>} {{}}}"
864
865
if fmt.Sprint(sel) != wantSel {
···
877
878
if err != nil {
878
879
t.Errorf("unexpected error: %v", err)
879
880
}
880
-
t.Error(debugStr(f))
881
+
t.Error(astinternal.DebugStr(f))
881
882
}
-2
internal/core/dep/dep_test.go
-2
internal/core/dep/dep_test.go
+1
internal/core/export/value_test.go
+1
internal/core/export/value_test.go
-1
internal/core/runtime/extern.go
-1
internal/core/runtime/extern.go