this repo has no description
all: don't use XXX strings unnecessarily
None of these were "XXX" comments in the sense that the code
cannot be in master, as described in #1959.
Use more realistic examples, other characters like NNN,
or Foo... rather than FooXXX when we mean any object with that prefix.
For #1959.
Signed-off-by: Daniel Martí <mvdan@mvdan.cc>
Change-Id: Iece6ccbed29223ed44911f8fd1ecc622a6d443fc
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1193723
Unity-Result: CUE porcuepine <cue.porcuepine@gmail.com>
TryBot-Result: CUEcueckoo <cueckoo@cuelang.org>
Reviewed-by: Paul Jolly <paul@myitcv.io>
+7
-7
+1
-1
CONTRIBUTING.md
+1
-1
CONTRIBUTING.md
···
800
800
remote: Processing changes: refs: 1, done
801
801
remote:
802
802
remote: ERROR: In commit ab13517fa29487dcf8b0d48916c51639426c5ee9
803
-
remote: ERROR: author email address XXXXXXXXXXXXXXXXXXX
803
+
remote: ERROR: author email address your.email@domain.com
804
804
remote: ERROR: does not match your user account.
805
805
```
806
806
+1
-1
cue/ast/astutil/sanitize.go
+1
-1
cue/ast/astutil/sanitize.go
···
317
317
}
318
318
319
319
// uniqueName returns a new name globally unique name of the form
320
-
// base_XX ... base_XXXXXXXXXXXXXX or _base or the same pattern with a '_'
320
+
// base_NN ... base_NNNNNNNNNNNNNN or _base or the same pattern with a '_'
321
321
// prefix if hidden is true.
322
322
//
323
323
// It prefers short extensions over large ones, while ensuring the likelihood of
+1
-1
cue/format/format_test.go
+1
-1
cue/format/format_test.go
···
281
281
282
282
}
283
283
284
-
// Verify that the printer doesn't crash if the AST contains BadXXX nodes.
284
+
// Verify that the printer doesn't crash if the AST contains Bad... nodes.
285
285
func TestBadNodes(t *testing.T) {
286
286
const src = "package p\n("
287
287
const res = "package p\n\n(_|_)\n"
+2
-2
cue/parser/parser.go
+2
-2
cue/parser/parser.go
···
52
52
lit string // token literal
53
53
54
54
// Error recovery
55
-
// (used to limit the number of calls to syncXXX functions
55
+
// (used to limit the number of calls to sync... functions
56
56
// w/o making scanning progress - avoids potential endless
57
57
// loops across multiple parser functions during error recovery)
58
58
syncPos token.Pos // last synchronization position
59
-
syncCnt int // number of calls to syncXXX without progress
59
+
syncCnt int // number of calls to sync... functions without progress
60
60
61
61
// Non-syntactic parser control
62
62
exprLev int // < 0: in control clause, >= 0: in expression
+1
-1
internal/core/adt/states.go
+1
-1
internal/core/adt/states.go
···
126
126
// This is a signal condition that is reached when:
127
127
// - a node is set to a concrete scalar value
128
128
// - a node is set to an error
129
-
// - or if XXXstate is reached.
129
+
// - or if ...state is reached.
130
130
//
131
131
// TODO: rename to something better?
132
132
scalarKnown
+1
-1
internal/core/export/export.go
+1
-1
internal/core/export/export.go
···
636
636
637
637
// uniqueFeature returns a name for an identifier that uniquely identifies
638
638
// the given expression. If the preferred name is already taken, a new globally
639
-
// unique name of the form base_X ... base_XXXXXXXXXXXXXX is generated.
639
+
// unique name of the form base_N ... base_NNNNNNNNNNNNNN is generated.
640
640
//
641
641
// It prefers short extensions over large ones, while ensuring the likelihood of
642
642
// fast termination is high. There are at least two digits to make it visually