mvdan.cc / cue
this repo has no description
0
fork

Configure Feed

Select the types of activity you want to include in your feed.

internal/source: avoid a NopCloser if src is already a Closer

This case is hit over 400 times in `go test ./...`. For example,
./cue/interpreter/embed sets cue/build.File.Source to an *os.File,
so wrapping that in an io.NopCloser is unnecessary.

Note that there's no correctness issue here; such packages
also defer closing the source file, and repeated calls to os.File.Close
are harmless.

Signed-off-by: Daniel Martí <mvdan@mvdan.cc>
Change-Id: I4d3c057b69cf9d4a9e02abba2f9c03e1e3759e31
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1225200
TryBot-Result: CUEcueckoo <cueckoo@cuelang.org>
Unity-Result: CUE porcuepine <cue.porcuepine@gmail.com>
Reviewed-by: Roger Peppe <rogpeppe@gmail.com>

Daniel Martí 6d58d63b 4ba95727

+2
+2
internal/source/source.go
··· 63 63 return io.NopCloser(strings.NewReader(src)), nil 64 64 case []byte: 65 65 return io.NopCloser(bytes.NewReader(src)), nil 66 + case io.ReadCloser: 67 + return src, nil 66 68 case io.Reader: 67 69 return io.NopCloser(src), nil 68 70 }