mvdan.cc / cue
this repo has no description
0
fork

Configure Feed

Select the types of activity you want to include in your feed.

cuepls: minimal fix to make compilation work vs Go tip

The internal/golangorgx/... packages contain vendored (and modified)
versions of various (internal) packages from golang.org/x/tools,
golang.org/x/tools/gopls and golang.org/x/telemetry. As such, it's not
uncommon for things to break, because we are relying on internals.

Go tip has made a change as part of https://golang.org/issue/67182 that
causes us to break with respect to the originally vendored code. We make
a surgical update to the golang.org/x/telemetry to fix that break,
rather than trying to revendor all/part of the original package set
(which at this stage would be a lot of work).

Verified by running go test ./... with:

go version devel go1.23-1cb13ac7f6 Tue May 21 11:57:40 2024 +0000 linux/arm64

Signed-off-by: Paul Jolly <paul@myitcv.io>
Change-Id: I7554632f3b6d38fb73484602770ed28e681d4341
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1195010
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
TryBot-Result: CUEcueckoo <cueckoo@cuelang.org>

Paul Jolly 74519675 4900cfc6

+6 -2
+6 -2
internal/golangorgx/telemetry/crashmonitor/crash_go123.go
··· 7 7 8 8 package crashmonitor 9 9 10 - import "runtime/debug" 10 + import ( 11 + "os" 12 + "runtime/debug" 13 + ) 11 14 12 15 func init() { 13 - setCrashOutput = debug.SetCrashOutput 16 + setCrashOutput = func(f *os.File) error { return debug.SetCrashOutput(f, debug.CrashOptions{}) } 17 + 14 18 }