this repo has no description
internal/cueexperiment: keep all past experiments around
So that any existing users setting them to their final value
when the experiment was completed are not broken unnecessarily.
We had only removed yamlv3decoder so far; the modules experiment
was slated for removal via a TODO, so remove that TODO as well.
Updates #3689.
Signed-off-by: Daniel Martí <mvdan@mvdan.cc>
Change-Id: I8fddb699b85bdc8b1115da1d042a9c92084db743
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1207501
TryBot-Result: CUEcueckoo <cueckoo@cuelang.org>
Reviewed-by: Roger Peppe <rogpeppe@gmail.com>
Unity-Result: CUE porcuepine <cue.porcuepine@gmail.com>
+11
-4
+11
-4
internal/cueexperiment/exp.go
+11
-4
internal/cueexperiment/exp.go
···
11
11
// When adding, deleting, or modifying entries below,
12
12
// update cmd/cue/cmd/help.go as well for `cue help environment`.
13
13
var Flags struct {
14
-
// TODO(mvdan): remove in December 2025; leaving it around for now
15
-
// so that we delay breaking any users enabling this experiment.
16
-
Modules bool `envflag:"deprecated,default:true"`
17
-
18
14
// EvalV3 enables the new evaluator. The new evaluator addresses various
19
15
// performance concerns.
20
16
EvalV3 bool
···
29
25
30
26
// Enable topological sorting of struct fields.
31
27
TopoSort bool
28
+
29
+
// The flags below describe completed experiments; they can still be set
30
+
// as long as the value aligns with the final behavior once the experiment finished.
31
+
// Breaking users who set such a flag seems unnecessary,
32
+
// and it simplifies using the same experiment flags across a range of CUE versions.
33
+
34
+
// Modules was an experiment which ran from early 2023 to late 2024.
35
+
Modules bool `envflag:"deprecated,default:true"`
36
+
37
+
// YAMLV3Decoder was an experiment which ran from early 2024 to late 2024.
38
+
YAMLV3Decoder bool `envflag:"deprecated,default:true"`
32
39
}
33
40
34
41
// Init initializes Flags. Note: this isn't named "init" because we