mvdan.cc / cue
this repo has no description
0
fork

Configure Feed

Select the types of activity you want to include in your feed.

internal/core/adt: always print errors in leaf nodes

Without this, inline structs may sometimes drop errors
altogether. Note that this only affects debug printing.

This now shows errors more often, but this seems to
improve readability of test cases, so not bad.

Issue #4102

Signed-off-by: Marcel van Lohuizen <mpvl@gmail.com>
Change-Id: I65d87e56c393e606ec2120033705c29442adb562
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1224529
Unity-Result: CUE porcuepine <cue.porcuepine@gmail.com>
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
TryBot-Result: CUEcueckoo <cueckoo@cuelang.org>

Marcel van Lohuizen 8dce6dc7 15e67c0f

+10 -10
+2 -2
cue/testdata/compile/scope.txtar
··· 162 162 } 163 163 } 164 164 let _schema_1#2 = (_|_){ 165 - // [structural cycle] 165 + // [structural cycle] schema.next: structural cycle 166 166 } 167 167 } 168 168 -- diff/-out/evalalpha<==>+out/eval -- ··· 175 175 let _schema_1#2 = (_|_){ 176 176 - // [structural cycle] _schema_1: structural cycle: 177 177 - // ./in.cue:32:8 178 - + // [structural cycle] 178 + + // [structural cycle] schema.next: structural cycle 179 179 } 180 180 } 181 181 -- diff/todo/p3 --
+4 -4
cue/testdata/cycle/constraints.txtar
··· 866 866 b: (_|_){ 867 867 // [structural cycle] 868 868 link: (_|_){ 869 - // [structural cycle] 869 + // [structural cycle] selfTriggerCycle.issue1503.#T.a.b.link: structural cycle 870 870 } 871 871 } 872 872 } ··· 875 875 b: (_|_){ 876 876 // [structural cycle] 877 877 link: (_|_){ 878 - // [structural cycle] 878 + // [structural cycle] selfTriggerCycle.issue1503.#T.a.b.link: structural cycle 879 879 } 880 880 } 881 881 } ··· 1135 1135 + b: (_|_){ 1136 1136 + // [structural cycle] 1137 1137 + link: (_|_){ 1138 - + // [structural cycle] 1138 + + // [structural cycle] selfTriggerCycle.issue1503.#T.a.b.link: structural cycle 1139 1139 + } 1140 1140 + } 1141 1141 + } ··· 1144 1144 + b: (_|_){ 1145 1145 + // [structural cycle] 1146 1146 + link: (_|_){ 1147 - + // [structural cycle] 1147 + + // [structural cycle] selfTriggerCycle.issue1503.#T.a.b.link: structural cycle 1148 1148 } 1149 1149 } 1150 1150 }
+1 -1
cue/testdata/cycle/issue2526.txtar
··· 28 28 } 29 29 } 30 30 y: (_|_){ 31 - // [structural cycle] 31 + // [structural cycle] x.y: structural cycle 32 32 } 33 33 }
+2 -2
cue/testdata/cycle/structural.txtar
··· 1400 1400 } 1401 1401 } 1402 1402 let _schema_1#1 = (_|_){ 1403 - // [structural cycle] 1403 + // [structural cycle] withLetFail.schema.next: structural cycle 1404 1404 } 1405 1405 } 1406 1406 fieldsSumInfinite: (_|_){ ··· 2034 2034 let _schema_1#1 = (_|_){ 2035 2035 - // [structural cycle] withLetFail._schema_1: structural cycle: 2036 2036 - // ./in.cue:362:17 2037 - + // [structural cycle] 2037 + + // [structural cycle] withLetFail.schema.next: structural cycle 2038 2038 } 2039 2039 } 2040 2040 fieldsSumInfinite: (_|_){
+1 -1
internal/core/debug/debug.go
··· 312 312 w.indent += "// " 313 313 w.string("\n") 314 314 w.dst = fmt.Appendf(w.dst, "[%v]", v.Code) 315 - if !v.ChildError { 315 + if !v.ChildError || len(x.Arcs) == 0 { 316 316 msg := errors.Details(v.Err, &errors.Config{ 317 317 Cwd: w.cfg.Cwd, 318 318 ToSlash: true,