this repo has no description
integration/workspace: add test showing bad behaviour
This test shows that spaces in filenames cause problems: the edits to
the file are not properly applied to the overlay, and consequently the
wrong Hover results are returned.
Signed-off-by: Matthew Sackman <matthew@cue.works>
Change-Id: I4c70e34d7826c4775fecd1e1b4d17695ff8796b9
Reviewed-on: https://cue.gerrithub.io/c/cue-lang/cue/+/1230704
Unity-Result: CUE porcuepine <cue.porcuepine@gmail.com>
TryBot-Result: CUEcueckoo <cueckoo@cuelang.org>
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
+47
+47
cmd/cue/cmd/integration/workspace/symlink_test.go
+47
cmd/cue/cmd/integration/workspace/symlink_test.go
···
3
3
import (
4
4
"os"
5
5
"path/filepath"
6
+
"strings"
6
7
"testing"
7
8
"time"
8
9
9
10
"cuelang.org/go/internal/golangorgx/gopls/protocol"
10
11
. "cuelang.org/go/internal/golangorgx/gopls/test/integration"
12
+
"cuelang.org/go/internal/golangorgx/gopls/test/integration/fake"
11
13
"github.com/go-quicktest/qt"
12
14
)
13
15
···
62
64
)
63
65
})
64
66
}
67
+
68
+
func TestSymlinksAncestor(t *testing.T) {
69
+
const files = `
70
+
-- real/cue.mod/module.cue --
71
+
module: "mod.example/x"
72
+
language: version: "v0.11.0"
73
+
74
+
-- real/a.cue --
75
+
package a
76
+
77
+
y: x
78
+
79
+
// docs for x
80
+
x: _
81
+
`
82
+
WithOptions(RootURIAsDefaultFolder()).Run(t, files, func(t *testing.T, env *Env) {
83
+
rootURI := env.Sandbox.Workdir.RootURI()
84
+
rootFilePath := rootURI.Path()
85
+
86
+
err := os.Symlink(filepath.Join(rootFilePath, "real"), filepath.Join(rootFilePath, "sym link"))
87
+
qt.Assert(t, qt.IsNil(err))
88
+
89
+
env.OpenFile("sym link/a.cue")
90
+
env.Await(
91
+
env.DoneWithOpen(),
92
+
LogExactf(protocol.Debug, 1, false, "Package dirs=[%v/sym%%20link] importPath=mod.example/x@v0:a Reloaded", rootURI),
93
+
)
94
+
95
+
got, _ := env.Hover(protocol.Location{
96
+
URI: rootURI + "/sym%20link/a.cue",
97
+
Range: protocol.Range{Start: protocol.Position{Line: 2, Character: 3}},
98
+
})
99
+
qt.Assert(t, qt.IsTrue(strings.HasPrefix(got.Value, "docs for x")))
100
+
101
+
// add a newline (and comment so that the hover coords exist), before line 2
102
+
env.EditBuffer("sym link/a.cue", fake.NewEdit(2, 0, 2, 0, "// hi\n"))
103
+
env.Await(env.DoneWithChange())
104
+
105
+
got, _ = env.Hover(protocol.Location{
106
+
URI: rootURI + "/sym%20link/a.cue",
107
+
Range: protocol.Range{Start: protocol.Position{Line: 2, Character: 3}},
108
+
})
109
+
qt.Assert(t, qt.IsNotNil(got)) // This is WRONG: it *should* be nil.
110
+
})
111
+
}