this repo has no description
0
fork

Configure Feed

Select the types of activity you want to include in your feed.

internal/ci: remove cue-unity/unity from codereview.cfg

The old cueckoo treats both unity codereview.cfg entries as optional,
only triggering workflows on the present ones.

The new cueckoo will do something similar, but it will omit "cue-unity"
if "cue-unity-new" is also present, which it no longer will be.

In both cases, we will only trigger a workflow on unity-private now.

As a bonus, the "Trigger unity build" step now triggers unity-private,
as it had not been updated with our duplicated setup at all.

Signed-off-by: Daniel Martí <mvdan@mvdan.cc>
Change-Id: I1a5f08ac9eeb75f79fff4879de431bfff9b5b9cb
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/554255
Reviewed-by: Paul Jolly <paul@myitcv.io>
TryBot-Result: CUEcueckoo <cueckoo+gerrithub@cuelang.org>
Unity-New-Result: CUE porcuepine <cue.porcuepine@gmail.com>

+9 -13
+1 -1
.github/workflows/release.yml
··· 94 94 run: 'curl -s -L -H "Accept: application/vnd.github+json" -H "Authorization: Bearer ${{ secrets.CUECKOO_GITHUB_PAT }}" -H "X-GitHub-Api-Version: 2022-11-28" -f --request POST --data-binary "{\"event_type\":\"Re-test post release of ${GITHUB_REF##refs/tags/}\"}" https://api.github.com/repos/cue-lang/cuelang.org/dispatches' 95 95 - if: startsWith(github.ref, 'refs/tags/v') 96 96 name: Trigger unity build 97 - run: 'curl -s -L -H "Accept: application/vnd.github+json" -H "Authorization: Bearer ${{ secrets.CUECKOO_GITHUB_PAT }}" -H "X-GitHub-Api-Version: 2022-11-28" -f --request POST --data-binary "{\"event_type\":\"Check against CUE ${GITHUB_REF##refs/tags/}\",\"client_payload\":{\"type\":\"unity\",\"payload\":{\"versions\":\"\\\"${GITHUB_REF##refs/tags/}\\\"\"}}}" https://api.github.com/repos/cue-unity/unity/dispatches' 97 + run: 'curl -s -L -H "Accept: application/vnd.github+json" -H "Authorization: Bearer ${{ secrets.CUECKOO_GITHUB_PAT }}" -H "X-GitHub-Api-Version: 2022-11-28" -f --request POST --data-binary "{\"event_type\":\"Check against CUE ${GITHUB_REF##refs/tags/}\",\"client_payload\":{\"type\":\"unity\",\"payload\":{\"versions\":\"\\\"${GITHUB_REF##refs/tags/}\\\"\"}}}" https://api.github.com/repos/cue-unity/unity-private/dispatches'
+1 -1
.github/workflows/tip_triggers.yml
··· 16 16 - name: Trigger tip.cuelang.org deploy 17 17 run: 'curl -s -L -H "Accept: application/vnd.github+json" -H "Authorization: Bearer ${{ secrets.CUECKOO_GITHUB_PAT }}" -H "X-GitHub-Api-Version: 2022-11-28" -f --request POST --data-binary "{\"event_type\":\"Rebuild tip against ${GITHUB_SHA}\",\"client_payload\":{\"type\":\"rebuild_tip\"}}" https://api.github.com/repos/cue-lang/cuelang.org/dispatches' 18 18 - name: Trigger unity build 19 - run: 'curl -s -L -H "Accept: application/vnd.github+json" -H "Authorization: Bearer ${{ secrets.CUECKOO_GITHUB_PAT }}" -H "X-GitHub-Api-Version: 2022-11-28" -f --request POST --data-binary "{\"event_type\":\"Check against ${GITHUB_SHA}\",\"client_payload\":{\"type\":\"unity\",\"payload\":{\"versions\":\"\\\"commit:${GITHUB_SHA}\\\"\"}}}" https://api.github.com/repos/cue-unity/unity/dispatches' 19 + run: 'curl -s -L -H "Accept: application/vnd.github+json" -H "Authorization: Bearer ${{ secrets.CUECKOO_GITHUB_PAT }}" -H "X-GitHub-Api-Version: 2022-11-28" -f --request POST --data-binary "{\"event_type\":\"Check against ${GITHUB_SHA}\",\"client_payload\":{\"type\":\"unity\",\"payload\":{\"versions\":\"\\\"commit:${GITHUB_SHA}\\\"\"}}}" https://api.github.com/repos/cue-unity/unity-private/dispatches'
+1 -2
codereview.cfg
··· 2 2 3 3 gerrit: https://review.gerrithub.io/a/cue-lang/cue 4 4 github: https://github.com/cue-lang/cue 5 - cue-unity: https://github.com/cue-unity/unity 6 - cue-unity-new: https://github.com/cue-unity/unity-private 5 + cue-unity: https://github.com/cue-unity/unity-private
+3 -4
internal/ci/base/codereview.cue
··· 12 12 // file that drives golang.org/x/review/git-codereview. This config 13 13 // file is also used by github.com/cue-sh/tools/cmd/cueckoo. 14 14 #codeReview: { 15 - gerrit?: string 16 - github?: string 17 - "cue-unity"?: string 18 - "cue-unity-new"?: string 15 + gerrit?: string 16 + github?: string 17 + "cue-unity"?: string 19 18 } 20 19 21 20 // #toCodeReviewCfg converts a #codeReview instance to
+3 -5
internal/ci/repo/repo.cue
··· 11 11 12 12 githubRepositoryPath: "cue-lang/cue" 13 13 14 - unityRepositoryPath: "cue-unity/unity" 15 - unityRepositoryURL: "https://github.com/" + unityRepositoryPath 16 - unityNewRepositoryURL: unityRepositoryURL + "-private" 14 + unityRepositoryPath: "cue-unity/unity-private" 15 + unityRepositoryURL: "https://github.com/" + unityRepositoryPath 17 16 18 17 cuelangRepositoryPath: "cue-lang/cuelang.org" 19 18 ··· 56 55 // zeroReleaseTagSuffix. 57 56 zeroReleaseTagPattern: "*" + zeroReleaseTagSuffix 58 57 59 - codeReview: "cue-unity": unityRepositoryURL 60 - codeReview: "cue-unity-new": unityNewRepositoryURL 58 + codeReview: "cue-unity": unityRepositoryURL