this repo has no description
cmd/cue: reject mod mirror without anything to do
As otherwise it can be confusing that it always succeeds immediately.
Signed-off-by: Daniel Martí <mvdan@mvdan.cc>
Change-Id: I81dd0887014a013bdaa8624a377c2d32db43550c
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1211440
TryBot-Result: CUEcueckoo <cueckoo@cuelang.org>
Reviewed-by: Roger Peppe <rogpeppe@gmail.com>
Unity-Result: CUE porcuepine <cue.porcuepine@gmail.com>
+10
-5
+4
cmd/cue/cmd/modmirror.go
+4
cmd/cue/cmd/modmirror.go
···
86
86
allVersions := flagAllVersions.Bool(cmd)
87
87
useMod := flagMod.Bool(cmd)
88
88
89
+
if len(args) == 0 && !useMod {
90
+
return fmt.Errorf("nothing to do; provide arguments or --mod")
91
+
}
92
+
89
93
// TODO configure concurrency limit?
90
94
91
95
srcResolver, err := modconfig.NewResolver(newModConfig(srcRegStr))
+6
-5
cmd/cue/cmd/testdata/script/modmirror_modmode.txtar
+6
-5
cmd/cue/cmd/testdata/script/modmirror_modmode.txtar
···
17
17
cmp stdout $WORK/want-mirror2-stdout
18
18
19
19
# No arguments without --mod should fail as a no-op.
20
-
# TODO: currently these do nothing at all.
21
-
exec cue mod mirror --to $MEMREGISTRY2
20
+
! exec cue mod mirror --to $MEMREGISTRY2
22
21
! stdout .
23
-
! stderr .
24
-
exec cue mod mirror
22
+
cmp stderr $WORK/want-noop-stderr
23
+
! exec cue mod mirror
25
24
! stdout .
26
-
! stderr .
25
+
cmp stderr $WORK/want-noop-stderr
27
26
28
27
-- want-mirror1-stdout --
29
28
mirroring baz.org@v0.5.0
···
50
49
"main": "main",
51
50
"example.com@v0": "v0.0.1"
52
51
}
52
+
-- want-noop-stderr --
53
+
nothing to do; provide arguments or --mod
53
54
-- example/cue.mod/module.cue --
54
55
module: "main.org"
55
56
language: version: "v0.8.0"