this repo has no description
0
fork

Configure Feed

Select the types of activity you want to include in your feed.

all: use eval.NewContext when possible

eval.NewContext prints better error messages due to
its "nodeFormatter" implementation. This can not be
added to the adt package to avoid import cycles.

Use eval.NewContext where appropriate.

Signed-off-by: Marcel van Lohuizen <mpvl@gmail.com>
Change-Id: I811442cef59eca1571ffe680f0a63fb6b8f35e41
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1208685
Unity-Result: CUE porcuepine <cue.porcuepine@gmail.com>
Reviewed-by: Matthew Sackman <matthew@cue.works>
TryBot-Result: CUEcueckoo <cueckoo@cuelang.org>

+6 -3
+2 -1
pkg/list/list.go
··· 23 23 "cuelang.org/go/cue/errors" 24 24 "cuelang.org/go/cue/token" 25 25 "cuelang.org/go/internal/core/adt" 26 + "cuelang.org/go/internal/core/eval" 26 27 "cuelang.org/go/internal/pkg" 27 28 "cuelang.org/go/internal/types" 28 29 "cuelang.org/go/internal/value" ··· 275 276 276 277 var tv types.Value 277 278 a[0].Core(&tv) 278 - ctx := adt.NewContext(tv.R, tv.V) 279 + ctx := eval.NewContext(tv.R, tv.V) 279 280 280 281 posX, posY := 0, 0 281 282 code := adt.IncompleteError
+2 -1
pkg/list/sort.go
··· 25 25 "cuelang.org/go/cue" 26 26 "cuelang.org/go/internal" 27 27 "cuelang.org/go/internal/core/adt" 28 + "cuelang.org/go/internal/core/eval" 28 29 "cuelang.org/go/internal/types" 29 30 ) 30 31 ··· 152 153 153 154 var v types.Value 154 155 cmp.Core(&v) 155 - ctx := adt.NewContext(v.R, v.V) 156 + ctx := eval.NewContext(v.R, v.V) 156 157 157 158 n := &adt.Vertex{ 158 159 Label: v.V.Label,
+2 -1
tools/trim/trim.go
··· 56 56 "cuelang.org/go/cue/ast/astutil" 57 57 "cuelang.org/go/internal/core/adt" 58 58 "cuelang.org/go/internal/core/debug" 59 + "cuelang.org/go/internal/core/eval" 59 60 "cuelang.org/go/internal/core/subsume" 60 61 "cuelang.org/go/internal/core/walk" 61 62 "cuelang.org/go/internal/value" ··· 75 76 76 77 t := &trimmer{ 77 78 Config: *cfg, 78 - ctx: adt.NewContext(r, v), 79 + ctx: eval.NewContext(r, v), 79 80 remove: map[ast.Node]bool{}, 80 81 exclude: map[ast.Node]bool{}, 81 82 debug: Debug,