+1 -1

AGENTS.md

reviewed

··· 100 100 ### Formatting & Linting 101 101 102 102 - 2-space indentation, 120 character line length (enforced by `.swift-format.json`) 103 103 - - Trailing commas are mandatory (enforced by `.swiftlint.yml`) 103 103 + - `swift-format` is the source of truth for trailing commas: multi-element collection literals keep trailing commas, while single-element collection literals may have them removed. 104 104 - SwiftLint runs in strict mode; never disable lint rules without permission 105 105 - Custom SwiftLint rule: `store_state_mutation_in_views` — do not mutate `store.*` directly in view files; send actions instead 106 106 - Before creating a PR, run `make lint`.

+3 -1

supacode/Clients/Shell/ShellClient.swift

reviewed

··· 336 336 data.append(chunk) 337 337 return consumeLines(from: &data) 338 338 } 339 339 - lines.forEach { continuation.yield($0) } 339 339 + for line in lines { 340 340 + continuation.yield(line) 341 341 + } 340 342 } 341 343 continuation.onTermination = { _ in 342 344 handle.readabilityHandler = nil

+1 -1

supacode/Features/Repositories/Views/WorktreeDetailView.swift

reviewed

··· 954 954 key: "u", 955 955 modifiers: UserCustomShortcutModifiers() 956 956 ) 957 957 - ), 957 957 + ) 958 958 ], 959 959 isUpdateAvailable: true, 960 960 availableUpdateVersion: "2026.5.1"

+6 -2

supacode/Infrastructure/Ghostty/GhosttySurfaceView.swift

reviewed

··· 2424 2424 } 2425 2425 2426 2426 isolated deinit { 2427 2427 - observers.forEach { NotificationCenter.default.removeObserver($0) } 2427 2427 + for observer in observers { 2428 2428 + NotificationCenter.default.removeObserver(observer) 2429 2429 + } 2428 2430 } 2429 2431 2430 2432 override func layout() { ··· 2568 2570 } 2569 2571 2570 2572 override func updateTrackingAreas() { 2571 2571 - trackingAreas.forEach { removeTrackingArea($0) } 2573 2573 + for trackingArea in trackingAreas { 2574 2574 + removeTrackingArea(trackingArea) 2575 2575 + } 2572 2576 super.updateTrackingAreas() 2573 2577 guard let scroller = scrollView.verticalScroller else { return } 2574 2578 addTrackingArea(

+6 -6

supacodeTests/RepositoriesFeatureTests.swift

reviewed

··· 663 663 [ 664 664 PersistedRepositoryEntry(path: repoRoot, kind: .git), 665 665 PersistedRepositoryEntry(path: plainRoot, kind: .plain), 666 666 - ], 666 666 + ] 667 667 ] 668 668 #expect(savedEntries.value == expectedSavedEntries) 669 669 } ··· 1994 1994 id: pendingID, 1995 1995 repositoryID: repository.id, 1996 1996 progress: WorktreeCreationProgress(stage: .loadingLocalBranches) 1997 1997 - ), 1997 1997 + ) 1998 1998 ] 1999 1999 let store = TestStore(initialState: state) { 2000 2000 RepositoriesFeature() ··· 2032 2032 stage: .checkingRepositoryMode, 2033 2033 worktreeName: "swift-otter" 2034 2034 ) 2035 2035 - ), 2035 2035 + ) 2036 2036 ] 2037 2037 let store = TestStore(initialState: state) { 2038 2038 RepositoriesFeature() ··· 2227 2227 addedLines: nil, 2228 2228 removedLines: nil, 2229 2229 pullRequest: makePullRequest(state: "MERGED") 2230 2230 - ), 2230 2230 + ) 2231 2231 ] 2232 2232 let fixedDate = Date(timeIntervalSince1970: 1_000_000) 2233 2233 let store = TestStore(initialState: state) { ··· 2921 2921 id: removedWorktree.id, 2922 2922 repositoryID: repository.id, 2923 2923 progress: WorktreeCreationProgress(stage: .choosingWorktreeName) 2924 2924 - ), 2924 2924 + ) 2925 2925 ] 2926 2926 initialState.pinnedWorktreeIDs = [removedWorktree.id] 2927 2927 initialState.worktreeInfoByID = [ ··· 3008 3008 id: pendingID, 3009 3009 repositoryID: repository.id, 3010 3010 progress: WorktreeCreationProgress(stage: .loadingLocalBranches) 3011 3011 - ), 3011 3011 + ) 3012 3012 ] 3013 3013 initialState.selection = .worktree(pendingID) 3014 3014 initialState.sidebarSelectedWorktreeIDs = [existingWorktree.id, pendingID]

+2 -2

supacodeTests/RepositorySettingsFeatureTests.swift

reviewed

··· 135 135 key: "b", 136 136 modifiers: UserCustomShortcutModifiers(command: true) 137 137 ) 138 138 - ), 138 138 + ) 139 139 ] 140 140 ) 141 141 ··· 239 239 command: "echo updated", 240 240 execution: .shellScript, 241 241 shortcut: nil 242 242 - ), 242 242 + ) 243 243 ] 244 244 ) 245 245

+1

supacodeTests/WritableKeyPath+Sendable.swift

reviewed

··· 1 1 #if compiler(>=6) 2 2 + // swift-format-ignore: AvoidRetroactiveConformances 2 3 extension WritableKeyPath: @retroactive @unchecked Sendable {} 3 4 #endif