this repo has no description
Do not accept io.EOF when expecting an error
This should almost always be handled specially, so don't let tests that
expect errors hide the fact that they returned an io.EOF. This could be
revisited if the tests are ever updated to check for specific errors.
+9
-8
+9
-8
gitdiff/file_header_test.go
+9
-8
gitdiff/file_header_test.go
···
1
1
package gitdiff
2
2
3
3
import (
4
+
"io"
4
5
"os"
5
6
"reflect"
6
7
"testing"
···
152
153
153
154
f, err := p.ParseGitFileHeader()
154
155
if test.Err {
155
-
if err == nil {
156
-
t.Fatalf("expected error parsing git file header, got nil")
156
+
if err == nil || err == io.EOF {
157
+
t.Fatalf("expected error parsing git file header, got %v", err)
157
158
}
158
159
return
159
160
}
···
257
258
258
259
f, err := p.ParseTraditionalFileHeader()
259
260
if test.Err {
260
-
if err == nil {
261
-
t.Fatalf("expected error parsing traditional file header, got nil")
261
+
if err == nil || err == io.EOF {
262
+
t.Fatalf("expected error parsing traditional file header, got %v", err)
262
263
}
263
264
return
264
265
}
···
357
358
t.Run(name, func(t *testing.T) {
358
359
output, n, err := parseName(test.Input, test.Term, test.Drop)
359
360
if test.Err {
360
-
if err == nil {
361
-
t.Fatalf("expected error parsing name, but got nil")
361
+
if err == nil || err == io.EOF {
362
+
t.Fatalf("expected error parsing name, but got %v", err)
362
363
}
363
364
return
364
365
}
···
596
597
597
598
end, err := parseGitHeaderData(&f, test.Line, test.DefaultName)
598
599
if test.Err {
599
-
if err == nil {
600
-
t.Fatalf("expected error parsing header data, but got nil")
600
+
if err == nil || err == io.EOF {
601
+
t.Fatalf("expected error parsing header data, but got %v", err)
601
602
}
602
603
return
603
604
}