loading up the forgejo repo on tangled to test page performance
Fix checkbox field markup (#30666)
Fixes https://github.com/go-gitea/gitea/issues/30664.
Previous use was not a supported way by fomantic and the misuse only
became visible after the checkbox migration.
(cherry picked from commit 1a2ae64b16f10b8d1e17197d18b9eb373faf58db)
authored by
silverwind
and committed by
Earl Warren
2079d61a
bafe2373
+10
-6
+5
-3
templates/user/settings/applications_oauth2_edit_form.tmpl
+5
-3
templates/user/settings/applications_oauth2_edit_form.tmpl
···
41
41
<label for="redirect-uris">{{ctx.Locale.Tr "settings.oauth2_redirect_uris"}}</label>
42
42
<textarea name="redirect_uris" id="redirect-uris" required>{{StringUtils.Join .App.RedirectURIs "\n"}}</textarea>
43
43
</div>
44
-
<div class="field ui checkbox {{if .Err_ConfidentialClient}}error{{end}}">
45
-
<label>{{ctx.Locale.Tr "settings.oauth2_confidential_client"}}</label>
46
-
<input type="checkbox" name="confidential_client" {{if .App.ConfidentialClient}}checked{{end}}>
44
+
<div class="field {{if .Err_ConfidentialClient}}error{{end}}">
45
+
<div class="ui checkbox">
46
+
<label>{{ctx.Locale.Tr "settings.oauth2_confidential_client"}}</label>
47
+
<input type="checkbox" name="confidential_client" {{if .App.ConfidentialClient}}checked{{end}}>
48
+
</div>
47
49
</div>
48
50
<button class="ui primary button">
49
51
{{ctx.Locale.Tr "settings.save_application"}}
+5
-3
templates/user/settings/applications_oauth2_list.tmpl
+5
-3
templates/user/settings/applications_oauth2_list.tmpl
···
61
61
<label for="redirect-uris">{{ctx.Locale.Tr "settings.oauth2_redirect_uris"}}</label>
62
62
<textarea name="redirect_uris" id="redirect-uris"></textarea>
63
63
</div>
64
-
<div class="field ui checkbox {{if .Err_ConfidentialClient}}error{{end}}">
65
-
<label>{{ctx.Locale.Tr "settings.oauth2_confidential_client"}}</label>
66
-
<input type="checkbox" name="confidential_client" checked>
64
+
<div class="field {{if .Err_ConfidentialClient}}error{{end}}">
65
+
<div class="ui checkbox">
66
+
<label>{{ctx.Locale.Tr "settings.oauth2_confidential_client"}}</label>
67
+
<input type="checkbox" name="confidential_client" checked>
68
+
</div>
67
69
</div>
68
70
<button class="ui primary button">
69
71
{{ctx.Locale.Tr "settings.create_oauth2_application_button"}}