loading up the forgejo repo on tangled to test page performance
Merge pull request 'Fix boolean inputs in workflow_dispatch' (#5439) from Mai-Lapyst/forgejo:workflow_dispatch-fix-boolean-inputs into forgejo
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/5439
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
+6
-4
+3
-3
routers/web/repo/actions/manual.go
+3
-3
routers/web/repo/actions/manual.go
···
1
-
// Copyright The Forgejo Authors.
2
-
// SPDX-License-Identifier: MIT
1
+
// Copyright 2024 The Forgejo Authors.
2
+
// SPDX-License-Identifier: GPL-3.0-or-later
3
3
4
4
package actions
5
5
···
43
43
44
44
formKeyGetter := func(key string) string {
45
45
formKey := "inputs[" + key + "]"
46
-
return ctx.FormString(formKey)
46
+
return ctx.Req.PostFormValue(formKey)
47
47
}
48
48
49
49
if err := workflow.Dispatch(ctx, formKeyGetter, ctx.Repo.Repository, ctx.Doer); err != nil {
+3
-1
templates/repo/actions/dispatch.tmpl
+3
-1
templates/repo/actions/dispatch.tmpl
···
33
33
{{if eq $val.Type "boolean"}}
34
34
<div class="ui checkbox">
35
35
<label><strong>{{if $val.Description}}{{$val.Description}}{{else}}{{$key}}{{end}}</strong></label>
36
-
<input {{if $val.Required}}required{{end}} type="checkbox" name="inputs[{{$key}}]" {{if eq $val.Default "true"}}checked{{end}}>
36
+
{{/* These two inputs need to stay in exactly this order (checkbox first, hidden second) or boolean fields wont work correctly! */}}
37
+
<input type="checkbox" name="inputs[{{$key}}]" value="on" {{if eq $val.Default "true"}}checked{{end}}>
38
+
<input type="hidden" name="inputs[{{$key}}]" value="off" autocomplete="off">
37
39
</div>
38
40
{{else}}
39
41
<label>{{if $val.Description}}{{$val.Description}}{{else}}{{$key}}{{end}}</label>