loading up the forgejo repo on tangled to test page performance
0
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix incorrect `show-modal` and `show-panel` class (#23660)

That's incorrect code caused by Copy&Paste.

`show-modal` / `show-panel` are used by JS to show something, but these
links have `href`, they should navigate to new page.

Close #23657

authored by

wxiaoguang and committed by
GitHub
378d6b84 e8433b7f

+8 -8
+1 -1
templates/repo/projects/view.tmpl
··· 8 8 </div> 9 9 <div class="column right aligned"> 10 10 {{if and .CanWriteProjects (not .Repository.IsArchived)}} 11 - <a class="ui green button show-modal item" href="{{$.RepoLink}}/issues/new/choose?project={{$.Project.ID}}">{{.locale.Tr "repo.issues.new"}}</a> 11 + <a class="ui green button item" href="{{$.RepoLink}}/issues/new/choose?project={{$.Project.ID}}">{{.locale.Tr "repo.issues.new"}}</a> 12 12 <a class="ui green button show-modal item" data-modal="#new-board-item">{{.locale.Tr "new_project_column"}}</a> 13 13 {{end}} 14 14 <div class="ui small modal new-board-modal" id="new-board-item">
+3 -3
templates/repo/settings/lfs.tmpl
··· 7 7 <h4 class="ui top attached header"> 8 8 {{.locale.Tr "repo.settings.lfs_filelist"}} ({{.locale.Tr "admin.total" .Total}}) 9 9 <div class="ui right"> 10 - <a class="ui tiny show-panel button" href="{{.Link}}/locks">{{.locale.Tr "repo.settings.lfs_locks"}}</a> 11 - <a class="ui primary tiny show-panel button" href="{{.Link}}/pointers">&nbsp;{{.locale.Tr "repo.settings.lfs_findpointerfiles"}}</a> 10 + <a class="ui tiny button" href="{{.Link}}/locks">{{.locale.Tr "repo.settings.lfs_locks"}}</a> 11 + <a class="ui primary tiny button" href="{{.Link}}/pointers">&nbsp;{{.locale.Tr "repo.settings.lfs_findpointerfiles"}}</a> 12 12 </div> 13 13 </h4> 14 14 <table id="lfs-files-table" class="ui attached segment single line table"> ··· 25 25 <td>{{FileSize .Size}}</td> 26 26 <td>{{TimeSince .CreatedUnix.AsTime $.locale}}</td> 27 27 <td class="right aligned"> 28 - <a class="ui primary show-panel button" href="{{$.Link}}/find?oid={{.Oid}}&size={{.Size}}">{{$.locale.Tr "repo.settings.lfs_findcommits"}}</a> 28 + <a class="ui primary button" href="{{$.Link}}/find?oid={{.Oid}}&size={{.Size}}">{{$.locale.Tr "repo.settings.lfs_findcommits"}}</a> 29 29 <button class="ui basic show-modal icon button" data-modal="#delete-{{.Oid}}"> 30 30 <span class="btn-octicon btn-octicon-danger tooltip" data-content="{{$.locale.Tr "repo.editor.delete_this_file"}}" data-position="bottom center">{{svg "octicon-trash"}}</span> 31 31 </button>
+1 -1
templates/repo/settings/lfs_file.tmpl
··· 12 12 <a class="ui mini basic button unescape-button gt-hidden">{{.locale.Tr "repo.unescape_control_characters"}}</a> 13 13 <a class="ui mini basic button escape-button">{{.locale.Tr "repo.escape_control_characters"}}</a> 14 14 {{end}} 15 - <a class="ui primary show-panel button" href="{{.LFSFilesLink}}/find?oid={{.LFSFile.Oid}}&size={{.LFSFile.Size}}">{{$.locale.Tr "repo.settings.lfs_findcommits"}}</a> 15 + <a class="ui primary button" href="{{.LFSFilesLink}}/find?oid={{.LFSFile.Oid}}&size={{.LFSFile.Size}}">{{$.locale.Tr "repo.settings.lfs_findcommits"}}</a> 16 16 </div> 17 17 </h4> 18 18 <div class="ui attached table unstackable segment">
+1 -1
templates/repo/settings/lfs_pointers.tmpl
··· 56 56 </span> 57 57 </td> 58 58 <td> 59 - <a class="ui primary show-panel button" href="{{$.LFSFilesLink}}/find?oid={{.Oid}}&size={{.Size}}&sha={{.SHA}}">{{$.locale.Tr "repo.settings.lfs_findcommits"}}</a> 59 + <a class="ui primary button" href="{{$.LFSFilesLink}}/find?oid={{.Oid}}&size={{.Size}}&sha={{.SHA}}">{{$.locale.Tr "repo.settings.lfs_findcommits"}}</a> 60 60 </td> 61 61 <td>{{if .InRepo}}{{svg "octicon-check"}}{{else}}{{svg "octicon-x"}}{{end}}</td> 62 62 <td>{{if .Exists}}{{svg "octicon-check"}}{{else}}{{svg "octicon-x"}}{{end}}</td>
+1 -1
templates/user/settings/keys_gpg.tmpl
··· 50 50 {{$.locale.Tr "settings.delete_key"}} 51 51 </button> 52 52 {{if and (not .Verified) (ne $.VerifyingID .KeyID)}} 53 - <a class="ui primary tiny show-panel button" href="{{$.Link}}?verify_gpg={{.KeyID}}">{{$.locale.Tr "settings.gpg_key_verify"}}</a> 53 + <a class="ui primary tiny button" href="{{$.Link}}?verify_gpg={{.KeyID}}">{{$.locale.Tr "settings.gpg_key_verify"}}</a> 54 54 {{end}} 55 55 </div> 56 56 <div class="left floated content">
+1 -1
templates/user/settings/keys_ssh.tmpl
··· 42 42 {{$.locale.Tr "settings.delete_key"}} 43 43 </button> 44 44 {{if and (not .Verified) (ne $.VerifyingFingerprint .Fingerprint)}} 45 - <a class="ui primary tiny show-panel button" href="{{$.Link}}?verify_ssh={{.Fingerprint}}">{{$.locale.Tr "settings.ssh_key_verify"}}</a> 45 + <a class="ui primary tiny button" href="{{$.Link}}?verify_ssh={{.Fingerprint}}">{{$.locale.Tr "settings.ssh_key_verify"}}</a> 46 46 {{end}} 47 47 48 48 </div>