+1 -1

models/issues/dependency.go

reviewed

··· 134 134 } 135 135 defer committer.Close() 136 136 137 137 - // Check if it aleready exists 137 137 + // Check if it already exists 138 138 exists, err := issueDepExists(ctx, issue.ID, dep.ID) 139 139 if err != nil { 140 140 return err

+14 -9

models/issues/issue.go

reviewed

··· 189 189 190 190 // LoadRepo loads issue's repository 191 191 func (issue *Issue) LoadRepo(ctx context.Context) (err error) { 192 192 - if issue.Repo == nil { 192 192 + if issue.Repo == nil && issue.RepoID != 0 { 193 193 issue.Repo, err = repo_model.GetRepositoryByID(ctx, issue.RepoID) 194 194 if err != nil { 195 195 return fmt.Errorf("getRepositoryByID [%d]: %w", issue.RepoID, err) ··· 223 223 224 224 // LoadLabels loads labels 225 225 func (issue *Issue) LoadLabels(ctx context.Context) (err error) { 226 226 - if issue.Labels == nil { 226 226 + if issue.Labels == nil && issue.ID != 0 { 227 227 issue.Labels, err = GetLabelsByIssueID(ctx, issue.ID) 228 228 if err != nil { 229 229 return fmt.Errorf("getLabelsByIssueID [%d]: %w", issue.ID, err) ··· 234 234 235 235 // LoadPoster loads poster 236 236 func (issue *Issue) LoadPoster(ctx context.Context) (err error) { 237 237 - if issue.Poster == nil { 237 237 + if issue.Poster == nil && issue.PosterID != 0 { 238 238 issue.Poster, err = user_model.GetPossibleUserByID(ctx, issue.PosterID) 239 239 if err != nil { 240 240 issue.PosterID = -1 ··· 252 252 // LoadPullRequest loads pull request info 253 253 func (issue *Issue) LoadPullRequest(ctx context.Context) (err error) { 254 254 if issue.IsPull { 255 255 - if issue.PullRequest == nil { 255 255 + if issue.PullRequest == nil && issue.ID != 0 { 256 256 issue.PullRequest, err = GetPullRequestByIssueID(ctx, issue.ID) 257 257 if err != nil { 258 258 if IsErrPullRequestNotExist(err) { ··· 261 261 return fmt.Errorf("getPullRequestByIssueID [%d]: %w", issue.ID, err) 262 262 } 263 263 } 264 264 - issue.PullRequest.Issue = issue 264 264 + if issue.PullRequest != nil { 265 265 + issue.PullRequest.Issue = issue 266 266 + } 265 267 } 266 268 return nil 267 269 } ··· 2128 2130 } 2129 2131 2130 2132 // BlockedByDependencies finds all Dependencies an issue is blocked by 2131 2131 - func (issue *Issue) BlockedByDependencies(ctx context.Context) (issueDeps []*DependencyInfo, err error) { 2132 2132 - err = db.GetEngine(ctx). 2133 2133 + func (issue *Issue) BlockedByDependencies(ctx context.Context, opts db.ListOptions) (issueDeps []*DependencyInfo, err error) { 2134 2134 + sess := db.GetEngine(ctx). 2133 2135 Table("issue"). 2134 2136 Join("INNER", "repository", "repository.id = issue.repo_id"). 2135 2137 Join("INNER", "issue_dependency", "issue_dependency.dependency_id = issue.id"). 2136 2138 Where("issue_id = ?", issue.ID). 2137 2139 // sort by repo id then created date, with the issues of the same repo at the beginning of the list 2138 2138 - OrderBy("CASE WHEN issue.repo_id = ? THEN 0 ELSE issue.repo_id END, issue.created_unix DESC", issue.RepoID). 2139 2139 - Find(&issueDeps) 2140 2140 + OrderBy("CASE WHEN issue.repo_id = ? THEN 0 ELSE issue.repo_id END, issue.created_unix DESC", issue.RepoID) 2141 2141 + if opts.Page != 0 { 2142 2142 + sess = db.SetSessionPagination(sess, &opts) 2143 2143 + } 2144 2144 + err = sess.Find(&issueDeps) 2140 2145 2141 2146 for _, depInfo := range issueDeps { 2142 2147 depInfo.Issue.Repo = &depInfo.Repository

+8

modules/structs/issue.go

reviewed

··· 211 211 } 212 212 return "" 213 213 } 214 214 + 215 215 + // IssueMeta basic issue information 216 216 + // swagger:model 217 217 + type IssueMeta struct { 218 218 + Index int64 `json:"index"` 219 219 + Owner string `json:"owner"` 220 220 + Name string `json:"repo"` 221 221 + }

+3

options/locale/locale_en-US.ini

reviewed

··· 1489 1489 issues.dependency.title = Dependencies 1490 1490 issues.dependency.issue_no_dependencies = No dependencies set. 1491 1491 issues.dependency.pr_no_dependencies = No dependencies set. 1492 1492 + issues.dependency.no_permission_1 = "You do not have permission to read %d dependency" 1493 1493 + issues.dependency.no_permission_n = "You do not have permission to read %d dependencies" 1494 1494 + issues.dependency.no_permission.can_remove = "You do not have permission to read this dependency but can remove this dependency" 1492 1495 issues.dependency.add = Add dependency… 1493 1496 issues.dependency.cancel = Cancel 1494 1497 issues.dependency.remove = Remove

+8

routers/api/v1/api.go

reviewed

··· 1026 1026 Patch(reqToken(auth_model.AccessTokenScopeRepo), mustNotBeArchived, bind(api.EditAttachmentOptions{}), repo.EditIssueAttachment). 1027 1027 Delete(reqToken(auth_model.AccessTokenScopeRepo), mustNotBeArchived, repo.DeleteIssueAttachment) 1028 1028 }, mustEnableAttachments) 1029 1029 + m.Combo("/dependencies"). 1030 1030 + Get(repo.GetIssueDependencies). 1031 1031 + Post(reqToken(auth_model.AccessTokenScopeRepo), mustNotBeArchived, bind(api.IssueMeta{}), repo.CreateIssueDependency). 1032 1032 + Delete(reqToken(auth_model.AccessTokenScopeRepo), mustNotBeArchived, bind(api.IssueMeta{}), repo.RemoveIssueDependency) 1033 1033 + m.Combo("/blocks"). 1034 1034 + Get(repo.GetIssueBlocks). 1035 1035 + Post(reqToken(auth_model.AccessTokenScopeRepo), bind(api.IssueMeta{}), repo.CreateIssueBlocking). 1036 1036 + Delete(reqToken(auth_model.AccessTokenScopeRepo), bind(api.IssueMeta{}), repo.RemoveIssueBlocking) 1029 1037 }) 1030 1038 }, mustEnableIssuesOrPulls) 1031 1039 m.Group("/labels", func() {

+598

routers/api/v1/repo/issue_dependency.go

reviewed

··· 1 1 + // Copyright 2016 The Gogs Authors. All rights reserved. 2 2 + // Copyright 2023 The Gitea Authors. All rights reserved. 3 3 + // SPDX-License-Identifier: MIT 4 4 + 5 5 + package repo 6 6 + 7 7 + import ( 8 8 + "net/http" 9 9 + 10 10 + "code.gitea.io/gitea/models/db" 11 11 + issues_model "code.gitea.io/gitea/models/issues" 12 12 + access_model "code.gitea.io/gitea/models/perm/access" 13 13 + repo_model "code.gitea.io/gitea/models/repo" 14 14 + "code.gitea.io/gitea/modules/context" 15 15 + "code.gitea.io/gitea/modules/setting" 16 16 + api "code.gitea.io/gitea/modules/structs" 17 17 + "code.gitea.io/gitea/modules/web" 18 18 + "code.gitea.io/gitea/services/convert" 19 19 + ) 20 20 + 21 21 + // GetIssueDependencies list an issue's dependencies 22 22 + func GetIssueDependencies(ctx *context.APIContext) { 23 23 + // swagger:operation GET /repos/{owner}/{repo}/issues/{index}/dependencies issue issueListIssueDependencies 24 24 + // --- 25 25 + // summary: List an issue's dependencies, i.e all issues that block this issue. 26 26 + // produces: 27 27 + // - application/json 28 28 + // parameters: 29 29 + // - name: owner 30 30 + // in: path 31 31 + // description: owner of the repo 32 32 + // type: string 33 33 + // required: true 34 34 + // - name: repo 35 35 + // in: path 36 36 + // description: name of the repo 37 37 + // type: string 38 38 + // required: true 39 39 + // - name: index 40 40 + // in: path 41 41 + // description: index of the issue 42 42 + // type: string 43 43 + // required: true 44 44 + // - name: page 45 45 + // in: query 46 46 + // description: page number of results to return (1-based) 47 47 + // type: integer 48 48 + // - name: limit 49 49 + // in: query 50 50 + // description: page size of results 51 51 + // type: integer 52 52 + // responses: 53 53 + // "200": 54 54 + // "$ref": "#/responses/IssueList" 55 55 + 56 56 + // If this issue's repository does not enable dependencies then there can be no dependencies by default 57 57 + if !ctx.Repo.Repository.IsDependenciesEnabled(ctx) { 58 58 + ctx.NotFound() 59 59 + return 60 60 + } 61 61 + 62 62 + issue, err := issues_model.GetIssueByIndex(ctx.Repo.Repository.ID, ctx.ParamsInt64(":index")) 63 63 + if err != nil { 64 64 + if issues_model.IsErrIssueNotExist(err) { 65 65 + ctx.NotFound("IsErrIssueNotExist", err) 66 66 + } else { 67 67 + ctx.Error(http.StatusInternalServerError, "GetIssueByIndex", err) 68 68 + } 69 69 + return 70 70 + } 71 71 + 72 72 + // 1. We must be able to read this issue 73 73 + if !ctx.Repo.Permission.CanReadIssuesOrPulls(issue.IsPull) { 74 74 + ctx.NotFound() 75 75 + return 76 76 + } 77 77 + 78 78 + page := ctx.FormInt("page") 79 79 + if page <= 1 { 80 80 + page = 1 81 81 + } 82 82 + limit := ctx.FormInt("limit") 83 83 + if limit == 0 { 84 84 + limit = setting.API.DefaultPagingNum 85 85 + } else if limit > setting.API.MaxResponseItems { 86 86 + limit = setting.API.MaxResponseItems 87 87 + } 88 88 + 89 89 + canWrite := ctx.Repo.Permission.CanWriteIssuesOrPulls(issue.IsPull) 90 90 + 91 91 + blockerIssues := make([]*issues_model.Issue, 0, limit) 92 92 + 93 93 + // 2. Get the issues this issue depends on, i.e. the `<#b>`: `<issue> <- <#b>` 94 94 + blockersInfo, err := issue.BlockedByDependencies(ctx, db.ListOptions{ 95 95 + Page: page, 96 96 + PageSize: limit, 97 97 + }) 98 98 + if err != nil { 99 99 + ctx.Error(http.StatusInternalServerError, "BlockedByDependencies", err) 100 100 + return 101 101 + } 102 102 + 103 103 + var lastRepoID int64 104 104 + var lastPerm access_model.Permission 105 105 + for _, blocker := range blockersInfo { 106 106 + // Get the permissions for this repository 107 107 + perm := lastPerm 108 108 + if lastRepoID != blocker.Repository.ID { 109 109 + if blocker.Repository.ID == ctx.Repo.Repository.ID { 110 110 + perm = ctx.Repo.Permission 111 111 + } else { 112 112 + var err error 113 113 + perm, err = access_model.GetUserRepoPermission(ctx, &blocker.Repository, ctx.Doer) 114 114 + if err != nil { 115 115 + ctx.ServerError("GetUserRepoPermission", err) 116 116 + return 117 117 + } 118 118 + } 119 119 + lastRepoID = blocker.Repository.ID 120 120 + } 121 121 + 122 122 + // check permission 123 123 + if !perm.CanReadIssuesOrPulls(blocker.Issue.IsPull) { 124 124 + if !canWrite { 125 125 + hiddenBlocker := &issues_model.DependencyInfo{ 126 126 + Issue: issues_model.Issue{ 127 127 + Title: "HIDDEN", 128 128 + }, 129 129 + } 130 130 + blocker = hiddenBlocker 131 131 + } else { 132 132 + confidentialBlocker := &issues_model.DependencyInfo{ 133 133 + Issue: issues_model.Issue{ 134 134 + RepoID: blocker.Issue.RepoID, 135 135 + Index: blocker.Index, 136 136 + Title: blocker.Title, 137 137 + IsClosed: blocker.IsClosed, 138 138 + IsPull: blocker.IsPull, 139 139 + }, 140 140 + Repository: repo_model.Repository{ 141 141 + ID: blocker.Issue.Repo.ID, 142 142 + Name: blocker.Issue.Repo.Name, 143 143 + OwnerName: blocker.Issue.Repo.OwnerName, 144 144 + }, 145 145 + } 146 146 + confidentialBlocker.Issue.Repo = &confidentialBlocker.Repository 147 147 + blocker = confidentialBlocker 148 148 + } 149 149 + } 150 150 + blockerIssues = append(blockerIssues, &blocker.Issue) 151 151 + } 152 152 + 153 153 + ctx.JSON(http.StatusOK, convert.ToAPIIssueList(ctx, blockerIssues)) 154 154 + } 155 155 + 156 156 + // CreateIssueDependency create a new issue dependencies 157 157 + func CreateIssueDependency(ctx *context.APIContext) { 158 158 + // swagger:operation POST /repos/{owner}/{repo}/issues/{index}/dependencies issue issueCreateIssueDependencies 159 159 + // --- 160 160 + // summary: Make the issue in the url depend on the issue in the form. 161 161 + // produces: 162 162 + // - application/json 163 163 + // parameters: 164 164 + // - name: owner 165 165 + // in: path 166 166 + // description: owner of the repo 167 167 + // type: string 168 168 + // required: true 169 169 + // - name: repo 170 170 + // in: path 171 171 + // description: name of the repo 172 172 + // type: string 173 173 + // required: true 174 174 + // - name: index 175 175 + // in: path 176 176 + // description: index of the issue 177 177 + // type: string 178 178 + // required: true 179 179 + // - name: body 180 180 + // in: body 181 181 + // schema: 182 182 + // "$ref": "#/definitions/IssueMeta" 183 183 + // responses: 184 184 + // "201": 185 185 + // "$ref": "#/responses/Issue" 186 186 + // "404": 187 187 + // description: the issue does not exist 188 188 + 189 189 + // We want to make <:index> depend on <Form>, i.e. <:index> is the target 190 190 + target := getParamsIssue(ctx) 191 191 + if ctx.Written() { 192 192 + return 193 193 + } 194 194 + 195 195 + // and <Form> represents the dependency 196 196 + form := web.GetForm(ctx).(*api.IssueMeta) 197 197 + dependency := getFormIssue(ctx, form) 198 198 + if ctx.Written() { 199 199 + return 200 200 + } 201 201 + 202 202 + dependencyPerm := getPermissionForRepo(ctx, target.Repo) 203 203 + if ctx.Written() { 204 204 + return 205 205 + } 206 206 + 207 207 + createIssueDependency(ctx, target, dependency, ctx.Repo.Permission, *dependencyPerm) 208 208 + if ctx.Written() { 209 209 + return 210 210 + } 211 211 + 212 212 + ctx.JSON(http.StatusCreated, convert.ToAPIIssue(ctx, target)) 213 213 + } 214 214 + 215 215 + // RemoveIssueDependency remove an issue dependency 216 216 + func RemoveIssueDependency(ctx *context.APIContext) { 217 217 + // swagger:operation DELETE /repos/{owner}/{repo}/issues/{index}/dependencies issue issueRemoveIssueDependencies 218 218 + // --- 219 219 + // summary: Remove an issue dependency 220 220 + // produces: 221 221 + // - application/json 222 222 + // parameters: 223 223 + // - name: owner 224 224 + // in: path 225 225 + // description: owner of the repo 226 226 + // type: string 227 227 + // required: true 228 228 + // - name: repo 229 229 + // in: path 230 230 + // description: name of the repo 231 231 + // type: string 232 232 + // required: true 233 233 + // - name: index 234 234 + // in: path 235 235 + // description: index of the issue 236 236 + // type: string 237 237 + // required: true 238 238 + // - name: body 239 239 + // in: body 240 240 + // schema: 241 241 + // "$ref": "#/definitions/IssueMeta" 242 242 + // responses: 243 243 + // "200": 244 244 + // "$ref": "#/responses/Issue" 245 245 + 246 246 + // We want to make <:index> depend on <Form>, i.e. <:index> is the target 247 247 + target := getParamsIssue(ctx) 248 248 + if ctx.Written() { 249 249 + return 250 250 + } 251 251 + 252 252 + // and <Form> represents the dependency 253 253 + form := web.GetForm(ctx).(*api.IssueMeta) 254 254 + dependency := getFormIssue(ctx, form) 255 255 + if ctx.Written() { 256 256 + return 257 257 + } 258 258 + 259 259 + dependencyPerm := getPermissionForRepo(ctx, target.Repo) 260 260 + if ctx.Written() { 261 261 + return 262 262 + } 263 263 + 264 264 + removeIssueDependency(ctx, target, dependency, ctx.Repo.Permission, *dependencyPerm) 265 265 + if ctx.Written() { 266 266 + return 267 267 + } 268 268 + 269 269 + ctx.JSON(http.StatusCreated, convert.ToAPIIssue(ctx, target)) 270 270 + } 271 271 + 272 272 + // GetIssueBlocks list issues that are blocked by this issue 273 273 + func GetIssueBlocks(ctx *context.APIContext) { 274 274 + // swagger:operation GET /repos/{owner}/{repo}/issues/{index}/blocks issue issueListBlocks 275 275 + // --- 276 276 + // summary: List issues that are blocked by this issue 277 277 + // produces: 278 278 + // - application/json 279 279 + // parameters: 280 280 + // - name: owner 281 281 + // in: path 282 282 + // description: owner of the repo 283 283 + // type: string 284 284 + // required: true 285 285 + // - name: repo 286 286 + // in: path 287 287 + // description: name of the repo 288 288 + // type: string 289 289 + // required: true 290 290 + // - name: index 291 291 + // in: path 292 292 + // description: index of the issue 293 293 + // type: string 294 294 + // required: true 295 295 + // - name: page 296 296 + // in: query 297 297 + // description: page number of results to return (1-based) 298 298 + // type: integer 299 299 + // - name: limit 300 300 + // in: query 301 301 + // description: page size of results 302 302 + // type: integer 303 303 + // responses: 304 304 + // "200": 305 305 + // "$ref": "#/responses/IssueList" 306 306 + 307 307 + // We need to list the issues that DEPEND on this issue not the other way round 308 308 + // Therefore whether dependencies are enabled or not in this repository is potentially irrelevant. 309 309 + 310 310 + issue := getParamsIssue(ctx) 311 311 + if ctx.Written() { 312 312 + return 313 313 + } 314 314 + 315 315 + if !ctx.Repo.Permission.CanReadIssuesOrPulls(issue.IsPull) { 316 316 + ctx.NotFound() 317 317 + return 318 318 + } 319 319 + 320 320 + page := ctx.FormInt("page") 321 321 + if page <= 1 { 322 322 + page = 1 323 323 + } 324 324 + limit := ctx.FormInt("limit") 325 325 + if limit <= 1 { 326 326 + limit = setting.API.DefaultPagingNum 327 327 + } 328 328 + 329 329 + skip := (page - 1) * limit 330 330 + max := page * limit 331 331 + 332 332 + deps, err := issue.BlockingDependencies(ctx) 333 333 + if err != nil { 334 334 + ctx.Error(http.StatusInternalServerError, "BlockingDependencies", err) 335 335 + return 336 336 + } 337 337 + 338 338 + var lastRepoID int64 339 339 + var lastPerm access_model.Permission 340 340 + 341 341 + var issues []*issues_model.Issue 342 342 + for i, depMeta := range deps { 343 343 + if i < skip || i >= max { 344 344 + continue 345 345 + } 346 346 + 347 347 + // Get the permissions for this repository 348 348 + perm := lastPerm 349 349 + if lastRepoID != depMeta.Repository.ID { 350 350 + if depMeta.Repository.ID == ctx.Repo.Repository.ID { 351 351 + perm = ctx.Repo.Permission 352 352 + } else { 353 353 + var err error 354 354 + perm, err = access_model.GetUserRepoPermission(ctx, &depMeta.Repository, ctx.Doer) 355 355 + if err != nil { 356 356 + ctx.ServerError("GetUserRepoPermission", err) 357 357 + return 358 358 + } 359 359 + } 360 360 + lastRepoID = depMeta.Repository.ID 361 361 + } 362 362 + 363 363 + if !perm.CanReadIssuesOrPulls(depMeta.Issue.IsPull) { 364 364 + continue 365 365 + } 366 366 + 367 367 + depMeta.Issue.Repo = &depMeta.Repository 368 368 + issues = append(issues, &depMeta.Issue) 369 369 + } 370 370 + 371 371 + ctx.JSON(http.StatusOK, convert.ToAPIIssueList(ctx, issues)) 372 372 + } 373 373 + 374 374 + // CreateIssueBlocking block the issue given in the body by the issue in path 375 375 + func CreateIssueBlocking(ctx *context.APIContext) { 376 376 + // swagger:operation POST /repos/{owner}/{repo}/issues/{index}/blocks issue issueCreateIssueBlocking 377 377 + // --- 378 378 + // summary: Block the issue given in the body by the issue in path 379 379 + // produces: 380 380 + // - application/json 381 381 + // parameters: 382 382 + // - name: owner 383 383 + // in: path 384 384 + // description: owner of the repo 385 385 + // type: string 386 386 + // required: true 387 387 + // - name: repo 388 388 + // in: path 389 389 + // description: name of the repo 390 390 + // type: string 391 391 + // required: true 392 392 + // - name: index 393 393 + // in: path 394 394 + // description: index of the issue 395 395 + // type: string 396 396 + // required: true 397 397 + // - name: body 398 398 + // in: body 399 399 + // schema: 400 400 + // "$ref": "#/definitions/IssueMeta" 401 401 + // responses: 402 402 + // "201": 403 403 + // "$ref": "#/responses/Issue" 404 404 + // "404": 405 405 + // description: the issue does not exist 406 406 + 407 407 + dependency := getParamsIssue(ctx) 408 408 + if ctx.Written() { 409 409 + return 410 410 + } 411 411 + 412 412 + form := web.GetForm(ctx).(*api.IssueMeta) 413 413 + target := getFormIssue(ctx, form) 414 414 + if ctx.Written() { 415 415 + return 416 416 + } 417 417 + 418 418 + targetPerm := getPermissionForRepo(ctx, target.Repo) 419 419 + if ctx.Written() { 420 420 + return 421 421 + } 422 422 + 423 423 + createIssueDependency(ctx, target, dependency, *targetPerm, ctx.Repo.Permission) 424 424 + if ctx.Written() { 425 425 + return 426 426 + } 427 427 + 428 428 + ctx.JSON(http.StatusCreated, convert.ToAPIIssue(ctx, dependency)) 429 429 + } 430 430 + 431 431 + // RemoveIssueBlocking unblock the issue given in the body by the issue in path 432 432 + func RemoveIssueBlocking(ctx *context.APIContext) { 433 433 + // swagger:operation DELETE /repos/{owner}/{repo}/issues/{index}/blocks issue issueRemoveIssueBlocking 434 434 + // --- 435 435 + // summary: Unblock the issue given in the body by the issue in path 436 436 + // produces: 437 437 + // - application/json 438 438 + // parameters: 439 439 + // - name: owner 440 440 + // in: path 441 441 + // description: owner of the repo 442 442 + // type: string 443 443 + // required: true 444 444 + // - name: repo 445 445 + // in: path 446 446 + // description: name of the repo 447 447 + // type: string 448 448 + // required: true 449 449 + // - name: index 450 450 + // in: path 451 451 + // description: index of the issue 452 452 + // type: string 453 453 + // required: true 454 454 + // - name: body 455 455 + // in: body 456 456 + // schema: 457 457 + // "$ref": "#/definitions/IssueMeta" 458 458 + // responses: 459 459 + // "200": 460 460 + // "$ref": "#/responses/Issue" 461 461 + 462 462 + dependency := getParamsIssue(ctx) 463 463 + if ctx.Written() { 464 464 + return 465 465 + } 466 466 + 467 467 + form := web.GetForm(ctx).(*api.IssueMeta) 468 468 + target := getFormIssue(ctx, form) 469 469 + if ctx.Written() { 470 470 + return 471 471 + } 472 472 + 473 473 + targetPerm := getPermissionForRepo(ctx, target.Repo) 474 474 + if ctx.Written() { 475 475 + return 476 476 + } 477 477 + 478 478 + removeIssueDependency(ctx, target, dependency, *targetPerm, ctx.Repo.Permission) 479 479 + if ctx.Written() { 480 480 + return 481 481 + } 482 482 + 483 483 + ctx.JSON(http.StatusCreated, convert.ToAPIIssue(ctx, dependency)) 484 484 + } 485 485 + 486 486 + func getParamsIssue(ctx *context.APIContext) *issues_model.Issue { 487 487 + issue, err := issues_model.GetIssueByIndex(ctx.Repo.Repository.ID, ctx.ParamsInt64(":index")) 488 488 + if err != nil { 489 489 + if issues_model.IsErrIssueNotExist(err) { 490 490 + ctx.NotFound("IsErrIssueNotExist", err) 491 491 + } else { 492 492 + ctx.Error(http.StatusInternalServerError, "GetIssueByIndex", err) 493 493 + } 494 494 + return nil 495 495 + } 496 496 + issue.Repo = ctx.Repo.Repository 497 497 + return issue 498 498 + } 499 499 + 500 500 + func getFormIssue(ctx *context.APIContext, form *api.IssueMeta) *issues_model.Issue { 501 501 + var repo *repo_model.Repository 502 502 + if form.Owner != ctx.Repo.Repository.OwnerName || form.Name != ctx.Repo.Repository.Name { 503 503 + if !setting.Service.AllowCrossRepositoryDependencies { 504 504 + ctx.JSON(http.StatusBadRequest, "CrossRepositoryDependencies not enabled") 505 505 + return nil 506 506 + } 507 507 + var err error 508 508 + repo, err = repo_model.GetRepositoryByOwnerAndName(ctx, form.Owner, form.Name) 509 509 + if err != nil { 510 510 + if repo_model.IsErrRepoNotExist(err) { 511 511 + ctx.NotFound("IsErrRepoNotExist", err) 512 512 + } else { 513 513 + ctx.Error(http.StatusInternalServerError, "GetRepositoryByOwnerAndName", err) 514 514 + } 515 515 + return nil 516 516 + } 517 517 + } else { 518 518 + repo = ctx.Repo.Repository 519 519 + } 520 520 + 521 521 + issue, err := issues_model.GetIssueByIndex(repo.ID, form.Index) 522 522 + if err != nil { 523 523 + if issues_model.IsErrIssueNotExist(err) { 524 524 + ctx.NotFound("IsErrIssueNotExist", err) 525 525 + } else { 526 526 + ctx.Error(http.StatusInternalServerError, "GetIssueByIndex", err) 527 527 + } 528 528 + return nil 529 529 + } 530 530 + issue.Repo = repo 531 531 + return issue 532 532 + } 533 533 + 534 534 + func getPermissionForRepo(ctx *context.APIContext, repo *repo_model.Repository) *access_model.Permission { 535 535 + if repo.ID == ctx.Repo.Repository.ID { 536 536 + return &ctx.Repo.Permission 537 537 + } 538 538 + 539 539 + perm, err := access_model.GetUserRepoPermission(ctx, repo, ctx.Doer) 540 540 + if err != nil { 541 541 + ctx.Error(http.StatusInternalServerError, "GetUserRepoPermission", err) 542 542 + return nil 543 543 + } 544 544 + 545 545 + return &perm 546 546 + } 547 547 + 548 548 + func createIssueDependency(ctx *context.APIContext, target, dependency *issues_model.Issue, targetPerm, dependencyPerm access_model.Permission) { 549 549 + if target.Repo.IsArchived || !target.Repo.IsDependenciesEnabled(ctx) { 550 550 + // The target's repository doesn't have dependencies enabled 551 551 + ctx.NotFound() 552 552 + return 553 553 + } 554 554 + 555 555 + if !targetPerm.CanWriteIssuesOrPulls(target.IsPull) { 556 556 + // We can't write to the target 557 557 + ctx.NotFound() 558 558 + return 559 559 + } 560 560 + 561 561 + if !dependencyPerm.CanReadIssuesOrPulls(dependency.IsPull) { 562 562 + // We can't read the dependency 563 563 + ctx.NotFound() 564 564 + return 565 565 + } 566 566 + 567 567 + err := issues_model.CreateIssueDependency(ctx.Doer, target, dependency) 568 568 + if err != nil { 569 569 + ctx.Error(http.StatusInternalServerError, "CreateIssueDependency", err) 570 570 + return 571 571 + } 572 572 + } 573 573 + 574 574 + func removeIssueDependency(ctx *context.APIContext, target, dependency *issues_model.Issue, targetPerm, dependencyPerm access_model.Permission) { 575 575 + if target.Repo.IsArchived || !target.Repo.IsDependenciesEnabled(ctx) { 576 576 + // The target's repository doesn't have dependencies enabled 577 577 + ctx.NotFound() 578 578 + return 579 579 + } 580 580 + 581 581 + if !targetPerm.CanWriteIssuesOrPulls(target.IsPull) { 582 582 + // We can't write to the target 583 583 + ctx.NotFound() 584 584 + return 585 585 + } 586 586 + 587 587 + if !dependencyPerm.CanReadIssuesOrPulls(dependency.IsPull) { 588 588 + // We can't read the dependency 589 589 + ctx.NotFound() 590 590 + return 591 591 + } 592 592 + 593 593 + err := issues_model.RemoveIssueDependency(ctx.Doer, target, dependency, issues_model.DependencyTypeBlockedBy) 594 594 + if err != nil { 595 595 + ctx.Error(http.StatusInternalServerError, "CreateIssueDependency", err) 596 596 + return 597 597 + } 598 598 + }

+2

routers/api/v1/swagger/options.go

reviewed

··· 41 41 CreateIssueCommentOption api.CreateIssueCommentOption 42 42 // in:body 43 43 EditIssueCommentOption api.EditIssueCommentOption 44 44 + // in:body 45 45 + IssueMeta api.IssueMeta 44 46 45 47 // in:body 46 48 IssueLabelsOption api.IssueLabelsOption

+54 -2

routers/web/repo/issue.go

reviewed

··· 1812 1812 } 1813 1813 1814 1814 // Get Dependencies 1815 1815 - ctx.Data["BlockedByDependencies"], err = issue.BlockedByDependencies(ctx) 1815 1815 + blockedBy, err := issue.BlockedByDependencies(ctx, db.ListOptions{}) 1816 1816 if err != nil { 1817 1817 ctx.ServerError("BlockedByDependencies", err) 1818 1818 return 1819 1819 } 1820 1820 - ctx.Data["BlockingDependencies"], err = issue.BlockingDependencies(ctx) 1820 1820 + ctx.Data["BlockedByDependencies"], ctx.Data["BlockedByDependenciesNotPermitted"] = checkBlockedByIssues(ctx, blockedBy) 1821 1821 + if ctx.Written() { 1822 1822 + return 1823 1823 + } 1824 1824 + 1825 1825 + blocking, err := issue.BlockingDependencies(ctx) 1821 1826 if err != nil { 1822 1827 ctx.ServerError("BlockingDependencies", err) 1828 1828 + return 1829 1829 + } 1830 1830 + 1831 1831 + ctx.Data["BlockingDependencies"], ctx.Data["BlockingByDependenciesNotPermitted"] = checkBlockedByIssues(ctx, blocking) 1832 1832 + if ctx.Written() { 1823 1833 return 1824 1834 } 1825 1835 ··· 1849 1859 } 1850 1860 1851 1861 ctx.HTML(http.StatusOK, tplIssueView) 1862 1862 + } 1863 1863 + 1864 1864 + func checkBlockedByIssues(ctx *context.Context, blockers []*issues_model.DependencyInfo) (canRead, notPermitted []*issues_model.DependencyInfo) { 1865 1865 + var lastRepoID int64 1866 1866 + var lastPerm access_model.Permission 1867 1867 + for i, blocker := range blockers { 1868 1868 + // Get the permissions for this repository 1869 1869 + perm := lastPerm 1870 1870 + if lastRepoID != blocker.Repository.ID { 1871 1871 + if blocker.Repository.ID == ctx.Repo.Repository.ID { 1872 1872 + perm = ctx.Repo.Permission 1873 1873 + } else { 1874 1874 + var err error 1875 1875 + perm, err = access_model.GetUserRepoPermission(ctx, &blocker.Repository, ctx.Doer) 1876 1876 + if err != nil { 1877 1877 + ctx.ServerError("GetUserRepoPermission", err) 1878 1878 + return 1879 1879 + } 1880 1880 + } 1881 1881 + lastRepoID = blocker.Repository.ID 1882 1882 + } 1883 1883 + 1884 1884 + // check permission 1885 1885 + if !perm.CanReadIssuesOrPulls(blocker.Issue.IsPull) { 1886 1886 + blockers[len(notPermitted)], blockers[i] = blocker, blockers[len(notPermitted)] 1887 1887 + notPermitted = blockers[:len(notPermitted)+1] 1888 1888 + } 1889 1889 + } 1890 1890 + blockers = blockers[len(notPermitted):] 1891 1891 + sortDependencyInfo(blockers) 1892 1892 + sortDependencyInfo(notPermitted) 1893 1893 + 1894 1894 + return blockers, notPermitted 1895 1895 + } 1896 1896 + 1897 1897 + func sortDependencyInfo(blockers []*issues_model.DependencyInfo) { 1898 1898 + sort.Slice(blockers, func(i, j int) bool { 1899 1899 + if blockers[i].RepoID == blockers[j].RepoID { 1900 1900 + return blockers[i].Issue.CreatedUnix < blockers[j].Issue.CreatedUnix 1901 1901 + } 1902 1902 + return blockers[i].RepoID < blockers[j].RepoID 1903 1903 + }) 1852 1904 } 1853 1905 1854 1906 // GetActionIssue will return the issue which is used in the context.

+20 -3

routers/web/repo/issue_dependency.go

reviewed

··· 7 7 "net/http" 8 8 9 9 issues_model "code.gitea.io/gitea/models/issues" 10 10 + access_model "code.gitea.io/gitea/models/perm/access" 10 11 "code.gitea.io/gitea/modules/context" 11 12 "code.gitea.io/gitea/modules/setting" 12 13 ) ··· 44 45 } 45 46 46 47 // Check if both issues are in the same repo if cross repository dependencies is not enabled 47 47 - if issue.RepoID != dep.RepoID && !setting.Service.AllowCrossRepositoryDependencies { 48 48 - ctx.Flash.Error(ctx.Tr("repo.issues.dependency.add_error_dep_not_same_repo")) 49 49 - return 48 48 + if issue.RepoID != dep.RepoID { 49 49 + if !setting.Service.AllowCrossRepositoryDependencies { 50 50 + ctx.Flash.Error(ctx.Tr("repo.issues.dependency.add_error_dep_not_same_repo")) 51 51 + return 52 52 + } 53 53 + if err := dep.LoadRepo(ctx); err != nil { 54 54 + ctx.ServerError("loadRepo", err) 55 55 + return 56 56 + } 57 57 + // Can ctx.Doer read issues in the dep repo? 58 58 + depRepoPerm, err := access_model.GetUserRepoPermission(ctx, dep.Repo, ctx.Doer) 59 59 + if err != nil { 60 60 + ctx.ServerError("GetUserRepoPermission", err) 61 61 + return 62 62 + } 63 63 + if !depRepoPerm.CanReadIssuesOrPulls(dep.IsPull) { 64 64 + // you can't see this dependency 65 65 + return 66 66 + } 50 67 } 51 68 52 69 // Check if issue and dependency is the same

+20 -16

services/convert/issue.go

reviewed

··· 32 32 if err := issue.LoadRepo(ctx); err != nil { 33 33 return &api.Issue{} 34 34 } 35 35 - if err := issue.Repo.LoadOwner(ctx); err != nil { 36 36 - return &api.Issue{} 37 37 - } 38 35 39 36 apiIssue := &api.Issue{ 40 37 ID: issue.ID, 41 41 - URL: issue.APIURL(), 42 42 - HTMLURL: issue.HTMLURL(), 43 38 Index: issue.Index, 44 39 Poster: ToUser(ctx, issue.Poster, nil), 45 40 Title: issue.Title, 46 41 Body: issue.Content, 47 42 Attachments: ToAttachments(issue.Attachments), 48 43 Ref: issue.Ref, 49 49 - Labels: ToLabelList(issue.Labels, issue.Repo, issue.Repo.Owner), 50 44 State: issue.State(), 51 45 IsLocked: issue.IsLocked, 52 46 Comments: issue.NumComments, ··· 54 48 Updated: issue.UpdatedUnix.AsTime(), 55 49 } 56 50 57 57 - apiIssue.Repo = &api.RepositoryMeta{ 58 58 - ID: issue.Repo.ID, 59 59 - Name: issue.Repo.Name, 60 60 - Owner: issue.Repo.OwnerName, 61 61 - FullName: issue.Repo.FullName(), 51 51 + if issue.Repo != nil { 52 52 + if err := issue.Repo.LoadOwner(ctx); err != nil { 53 53 + return &api.Issue{} 54 54 + } 55 55 + apiIssue.URL = issue.APIURL() 56 56 + apiIssue.HTMLURL = issue.HTMLURL() 57 57 + apiIssue.Labels = ToLabelList(issue.Labels, issue.Repo, issue.Repo.Owner) 58 58 + apiIssue.Repo = &api.RepositoryMeta{ 59 59 + ID: issue.Repo.ID, 60 60 + Name: issue.Repo.Name, 61 61 + Owner: issue.Repo.OwnerName, 62 62 + FullName: issue.Repo.FullName(), 63 63 + } 62 64 } 63 65 64 66 if issue.ClosedUnix != 0 { ··· 85 87 if err := issue.LoadPullRequest(ctx); err != nil { 86 88 return &api.Issue{} 87 89 } 88 88 - apiIssue.PullRequest = &api.PullRequestMeta{ 89 89 - HasMerged: issue.PullRequest.HasMerged, 90 90 - } 91 91 - if issue.PullRequest.HasMerged { 92 92 - apiIssue.PullRequest.Merged = issue.PullRequest.MergedUnix.AsTimePtr() 90 90 + if issue.PullRequest != nil { 91 91 + apiIssue.PullRequest = &api.PullRequestMeta{ 92 92 + HasMerged: issue.PullRequest.HasMerged, 93 93 + } 94 94 + if issue.PullRequest.HasMerged { 95 95 + apiIssue.PullRequest.Merged = issue.PullRequest.MergedUnix.AsTimePtr() 96 96 + } 93 97 } 94 98 } 95 99 if issue.DeadlineUnix != 0 {

+36 -3

templates/repo/issue/view_content/sidebar.tmpl

reviewed

··· 420 420 <div class="ui divider"></div> 421 421 422 422 <div class="ui depending"> 423 423 - {{if (and (not .BlockedByDependencies) (not .BlockingDependencies))}} 423 423 + {{if (and (not .BlockedByDependencies) (not .BlockedByDependenciesNotPermitted) (not .BlockingDependencies) (not .BlockingDependenciesNotPermitted))}} 424 424 <span class="text"><strong>{{.locale.Tr "repo.issues.dependency.title"}}</strong></span> 425 425 <br> 426 426 <p> ··· 432 432 </p> 433 433 {{end}} 434 434 435 435 - {{if .BlockingDependencies}} 435 435 + {{if or .BlockingDependencies .BlockingDependenciesNotPermitted}} 436 436 <span class="text" data-tooltip-content="{{if .Issue.IsPull}}{{.locale.Tr "repo.issues.dependency.pr_close_blocks"}}{{else}}{{.locale.Tr "repo.issues.dependency.issue_close_blocks"}}{{end}}"> 437 437 <strong>{{.locale.Tr "repo.issues.dependency.blocks_short"}}</strong> 438 438 </span> ··· 456 456 </div> 457 457 </div> 458 458 {{end}} 459 459 + {{if .BlockingDependenciesNotPermitted}} 460 460 + <div class="item gt-df gt-ac gt-sb"> 461 461 + <span>{{$.locale.TrN (len .BlockingDependenciesNotPermitted) "repo.issues.dependency.no_permission_1" "repo.issues.dependency.no_permission_n" (len .BlockingDependenciesNotPermitted)}}</span> 462 462 + </div> 463 463 + {{end}} 459 464 </div> 460 465 {{end}} 461 466 462 462 - {{if .BlockedByDependencies}} 467 467 + {{if or .BlockedByDependencies .BlockedByDependenciesNotPermitted}} 463 468 <span class="text" data-tooltip-content="{{if .Issue.IsPull}}{{.locale.Tr "repo.issues.dependency.pr_closing_blockedby"}}{{else}}{{.locale.Tr "repo.issues.dependency.issue_closing_blockedby"}}{{end}}"> 464 469 <strong>{{.locale.Tr "repo.issues.dependency.blocked_by_short"}}</strong> 465 470 </span> ··· 481 486 </a> 482 487 {{end}} 483 488 </div> 489 489 + </div> 490 490 + {{end}} 491 491 + {{if $.CanCreateIssueDependencies}} 492 492 + {{range .BlockedByDependenciesNotPermitted}} 493 493 + <div class="item dependency{{if .Issue.IsClosed}} is-closed{{end}} gt-df gt-ac gt-sb"> 494 494 + <div class="item-left gt-df gt-jc gt-fc gt-f1"> 495 495 + <div> 496 496 + <span data-tooltip-content="{{$.locale.Tr "repo.issues.dependency.no_permission.can_remove"}}">{{svg "octicon-lock" 16}}</span> 497 497 + <span class="title" data-tooltip-content="#{{.Issue.Index}} {{.Issue.Title | RenderEmoji $.Context}}"> 498 498 + #{{.Issue.Index}} {{.Issue.Title | RenderEmoji $.Context}} 499 499 + </span> 500 500 + </div> 501 501 + <div class="text small"> 502 502 + {{.Repository.OwnerName}}/{{.Repository.Name}} 503 503 + </div> 504 504 + </div> 505 505 + <div class="item-right gt-df gt-ac"> 506 506 + {{if and $.CanCreateIssueDependencies (not $.Repository.IsArchived)}} 507 507 + <a class="delete-dependency-button ci muted" data-id="{{.Issue.ID}}" data-type="blocking" data-tooltip-content="{{$.locale.Tr "repo.issues.dependency.remove_info"}}"> 508 508 + {{svg "octicon-trash" 16}} 509 509 + </a> 510 510 + {{end}} 511 511 + </div> 512 512 + </div> 513 513 + {{end}} 514 514 + {{else if .BlockedByDependenciesNotPermitted}} 515 515 + <div class="item gt-df gt-ac gt-sb"> 516 516 + <span>{{$.locale.TrN (len .BlockedByDependenciesNotPermitted) "repo.issues.dependency.no_permission_1" "repo.issues.dependency.no_permission_n" (len .BlockedByDependenciesNotPermitted)}}</span> 484 517 </div> 485 518 {{end}} 486 519 </div>

+310

templates/swagger/v1_json.tmpl

reviewed

··· 6256 6256 } 6257 6257 } 6258 6258 }, 6259 6259 + "/repos/{owner}/{repo}/issues/{index}/blocks": { 6260 6260 + "get": { 6261 6261 + "produces": [ 6262 6262 + "application/json" 6263 6263 + ], 6264 6264 + "tags": [ 6265 6265 + "issue" 6266 6266 + ], 6267 6267 + "summary": "List issues that are blocked by this issue", 6268 6268 + "operationId": "issueListBlocks", 6269 6269 + "parameters": [ 6270 6270 + { 6271 6271 + "type": "string", 6272 6272 + "description": "owner of the repo", 6273 6273 + "name": "owner", 6274 6274 + "in": "path", 6275 6275 + "required": true 6276 6276 + }, 6277 6277 + { 6278 6278 + "type": "string", 6279 6279 + "description": "name of the repo", 6280 6280 + "name": "repo", 6281 6281 + "in": "path", 6282 6282 + "required": true 6283 6283 + }, 6284 6284 + { 6285 6285 + "type": "string", 6286 6286 + "description": "index of the issue", 6287 6287 + "name": "index", 6288 6288 + "in": "path", 6289 6289 + "required": true 6290 6290 + }, 6291 6291 + { 6292 6292 + "type": "integer", 6293 6293 + "description": "page number of results to return (1-based)", 6294 6294 + "name": "page", 6295 6295 + "in": "query" 6296 6296 + }, 6297 6297 + { 6298 6298 + "type": "integer", 6299 6299 + "description": "page size of results", 6300 6300 + "name": "limit", 6301 6301 + "in": "query" 6302 6302 + } 6303 6303 + ], 6304 6304 + "responses": { 6305 6305 + "200": { 6306 6306 + "$ref": "#/responses/IssueList" 6307 6307 + } 6308 6308 + } 6309 6309 + }, 6310 6310 + "post": { 6311 6311 + "produces": [ 6312 6312 + "application/json" 6313 6313 + ], 6314 6314 + "tags": [ 6315 6315 + "issue" 6316 6316 + ], 6317 6317 + "summary": "Block the issue given in the body by the issue in path", 6318 6318 + "operationId": "issueCreateIssueBlocking", 6319 6319 + "parameters": [ 6320 6320 + { 6321 6321 + "type": "string", 6322 6322 + "description": "owner of the repo", 6323 6323 + "name": "owner", 6324 6324 + "in": "path", 6325 6325 + "required": true 6326 6326 + }, 6327 6327 + { 6328 6328 + "type": "string", 6329 6329 + "description": "name of the repo", 6330 6330 + "name": "repo", 6331 6331 + "in": "path", 6332 6332 + "required": true 6333 6333 + }, 6334 6334 + { 6335 6335 + "type": "string", 6336 6336 + "description": "index of the issue", 6337 6337 + "name": "index", 6338 6338 + "in": "path", 6339 6339 + "required": true 6340 6340 + }, 6341 6341 + { 6342 6342 + "name": "body", 6343 6343 + "in": "body", 6344 6344 + "schema": { 6345 6345 + "$ref": "#/definitions/IssueMeta" 6346 6346 + } 6347 6347 + } 6348 6348 + ], 6349 6349 + "responses": { 6350 6350 + "201": { 6351 6351 + "$ref": "#/responses/Issue" 6352 6352 + }, 6353 6353 + "404": { 6354 6354 + "description": "the issue does not exist" 6355 6355 + } 6356 6356 + } 6357 6357 + }, 6358 6358 + "delete": { 6359 6359 + "produces": [ 6360 6360 + "application/json" 6361 6361 + ], 6362 6362 + "tags": [ 6363 6363 + "issue" 6364 6364 + ], 6365 6365 + "summary": "Unblock the issue given in the body by the issue in path", 6366 6366 + "operationId": "issueRemoveIssueBlocking", 6367 6367 + "parameters": [ 6368 6368 + { 6369 6369 + "type": "string", 6370 6370 + "description": "owner of the repo", 6371 6371 + "name": "owner", 6372 6372 + "in": "path", 6373 6373 + "required": true 6374 6374 + }, 6375 6375 + { 6376 6376 + "type": "string", 6377 6377 + "description": "name of the repo", 6378 6378 + "name": "repo", 6379 6379 + "in": "path", 6380 6380 + "required": true 6381 6381 + }, 6382 6382 + { 6383 6383 + "type": "string", 6384 6384 + "description": "index of the issue", 6385 6385 + "name": "index", 6386 6386 + "in": "path", 6387 6387 + "required": true 6388 6388 + }, 6389 6389 + { 6390 6390 + "name": "body", 6391 6391 + "in": "body", 6392 6392 + "schema": { 6393 6393 + "$ref": "#/definitions/IssueMeta" 6394 6394 + } 6395 6395 + } 6396 6396 + ], 6397 6397 + "responses": { 6398 6398 + "200": { 6399 6399 + "$ref": "#/responses/Issue" 6400 6400 + } 6401 6401 + } 6402 6402 + } 6403 6403 + }, 6259 6404 "/repos/{owner}/{repo}/issues/{index}/comments": { 6260 6405 "get": { 6261 6406 "produces": [ ··· 6534 6679 }, 6535 6680 "404": { 6536 6681 "$ref": "#/responses/notFound" 6682 6682 + } 6683 6683 + } 6684 6684 + } 6685 6685 + }, 6686 6686 + "/repos/{owner}/{repo}/issues/{index}/dependencies": { 6687 6687 + "get": { 6688 6688 + "produces": [ 6689 6689 + "application/json" 6690 6690 + ], 6691 6691 + "tags": [ 6692 6692 + "issue" 6693 6693 + ], 6694 6694 + "summary": "List an issue's dependencies, i.e all issues that block this issue.", 6695 6695 + "operationId": "issueListIssueDependencies", 6696 6696 + "parameters": [ 6697 6697 + { 6698 6698 + "type": "string", 6699 6699 + "description": "owner of the repo", 6700 6700 + "name": "owner", 6701 6701 + "in": "path", 6702 6702 + "required": true 6703 6703 + }, 6704 6704 + { 6705 6705 + "type": "string", 6706 6706 + "description": "name of the repo", 6707 6707 + "name": "repo", 6708 6708 + "in": "path", 6709 6709 + "required": true 6710 6710 + }, 6711 6711 + { 6712 6712 + "type": "string", 6713 6713 + "description": "index of the issue", 6714 6714 + "name": "index", 6715 6715 + "in": "path", 6716 6716 + "required": true 6717 6717 + }, 6718 6718 + { 6719 6719 + "type": "integer", 6720 6720 + "description": "page number of results to return (1-based)", 6721 6721 + "name": "page", 6722 6722 + "in": "query" 6723 6723 + }, 6724 6724 + { 6725 6725 + "type": "integer", 6726 6726 + "description": "page size of results", 6727 6727 + "name": "limit", 6728 6728 + "in": "query" 6729 6729 + } 6730 6730 + ], 6731 6731 + "responses": { 6732 6732 + "200": { 6733 6733 + "$ref": "#/responses/IssueList" 6734 6734 + } 6735 6735 + } 6736 6736 + }, 6737 6737 + "post": { 6738 6738 + "produces": [ 6739 6739 + "application/json" 6740 6740 + ], 6741 6741 + "tags": [ 6742 6742 + "issue" 6743 6743 + ], 6744 6744 + "summary": "Make the issue in the url depend on the issue in the form.", 6745 6745 + "operationId": "issueCreateIssueDependencies", 6746 6746 + "parameters": [ 6747 6747 + { 6748 6748 + "type": "string", 6749 6749 + "description": "owner of the repo", 6750 6750 + "name": "owner", 6751 6751 + "in": "path", 6752 6752 + "required": true 6753 6753 + }, 6754 6754 + { 6755 6755 + "type": "string", 6756 6756 + "description": "name of the repo", 6757 6757 + "name": "repo", 6758 6758 + "in": "path", 6759 6759 + "required": true 6760 6760 + }, 6761 6761 + { 6762 6762 + "type": "string", 6763 6763 + "description": "index of the issue", 6764 6764 + "name": "index", 6765 6765 + "in": "path", 6766 6766 + "required": true 6767 6767 + }, 6768 6768 + { 6769 6769 + "name": "body", 6770 6770 + "in": "body", 6771 6771 + "schema": { 6772 6772 + "$ref": "#/definitions/IssueMeta" 6773 6773 + } 6774 6774 + } 6775 6775 + ], 6776 6776 + "responses": { 6777 6777 + "201": { 6778 6778 + "$ref": "#/responses/Issue" 6779 6779 + }, 6780 6780 + "404": { 6781 6781 + "description": "the issue does not exist" 6782 6782 + } 6783 6783 + } 6784 6784 + }, 6785 6785 + "delete": { 6786 6786 + "produces": [ 6787 6787 + "application/json" 6788 6788 + ], 6789 6789 + "tags": [ 6790 6790 + "issue" 6791 6791 + ], 6792 6792 + "summary": "Remove an issue dependency", 6793 6793 + "operationId": "issueRemoveIssueDependencies", 6794 6794 + "parameters": [ 6795 6795 + { 6796 6796 + "type": "string", 6797 6797 + "description": "owner of the repo", 6798 6798 + "name": "owner", 6799 6799 + "in": "path", 6800 6800 + "required": true 6801 6801 + }, 6802 6802 + { 6803 6803 + "type": "string", 6804 6804 + "description": "name of the repo", 6805 6805 + "name": "repo", 6806 6806 + "in": "path", 6807 6807 + "required": true 6808 6808 + }, 6809 6809 + { 6810 6810 + "type": "string", 6811 6811 + "description": "index of the issue", 6812 6812 + "name": "index", 6813 6813 + "in": "path", 6814 6814 + "required": true 6815 6815 + }, 6816 6816 + { 6817 6817 + "name": "body", 6818 6818 + "in": "body", 6819 6819 + "schema": { 6820 6820 + "$ref": "#/definitions/IssueMeta" 6821 6821 + } 6822 6822 + } 6823 6823 + ], 6824 6824 + "responses": { 6825 6825 + "200": { 6826 6826 + "$ref": "#/responses/Issue" 6537 6827 } 6538 6828 } 6539 6829 } ··· 17928 18218 "format": "int64" 17929 18219 }, 17930 18220 "x-go-name": "Labels" 18221 18221 + } 18222 18222 + }, 18223 18223 + "x-go-package": "code.gitea.io/gitea/modules/structs" 18224 18224 + }, 18225 18225 + "IssueMeta": { 18226 18226 + "description": "IssueMeta basic issue information", 18227 18227 + "type": "object", 18228 18228 + "properties": { 18229 18229 + "index": { 18230 18230 + "type": "integer", 18231 18231 + "format": "int64", 18232 18232 + "x-go-name": "Index" 18233 18233 + }, 18234 18234 + "owner": { 18235 18235 + "type": "string", 18236 18236 + "x-go-name": "Owner" 18237 18237 + }, 18238 18238 + "repo": { 18239 18239 + "type": "string", 18240 18240 + "x-go-name": "Name" 17931 18241 } 17932 18242 }, 17933 18243 "x-go-package": "code.gitea.io/gitea/modules/structs"