loading up the forgejo repo on tangled to test page performance
Use correct minio error (#26634)
Previously, `err` was defined above, checked for `err == nil` and used
nowhere else.
Hence, the result of `convertMinioErr` would always be `nil`.
This leads to a NPE further down the line.
That is not intentional, it should convert the error of the most recent
operation, not one of its predecessors.
Found through
https://discord.com/channels/322538954119184384/322538954119184384/1143185780206993550.
+2
-2
+2
-2
modules/storage/minio.go
+2
-2
modules/storage/minio.go
···
91
91
}
92
92
93
93
// Check to see if we already own this bucket
94
-
exists, errBucketExists := minioClient.BucketExists(ctx, config.Bucket)
95
-
if errBucketExists != nil {
94
+
exists, err := minioClient.BucketExists(ctx, config.Bucket)
95
+
if err != nil {
96
96
return nil, convertMinioErr(err)
97
97
}
98
98