oppi.li / perf-test
loading up the forgejo repo on tangled to test page performance
0
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix incorrect "tabindex" attributes (#26733)

Fix #26731

Almost all "tabindex" in code are incorrect.

1. All "input/button" by default are focusable, so no need to use "tabindex=0"
2. All "div/span" by default are not focusable, so no need to use "tabindex=-1"
3. All "dropdown" are focusable by framework, so no need to use "tabindex"
4. Some tabindex values are incorrect (eg: `new_form.tmpl`), so remove them

Co-authored-by: Giteabot <teabot@gitea.io>

authored by

wxiaoguang
Giteabot and committed by
GitHub 4fdb09de 576644d8

+54 -55
+3 -3
templates/org/create.tmpl
··· 19 19 <span class="inline required field"><label for="visibility">{{.locale.Tr "org.settings.visibility"}}</label></span> 20 20 <div class="inline-grouped-list"> 21 21 <div class="ui radio checkbox"> 22 - <input class="enable-system-radio" tabindex="0" name="visibility" type="radio" value="0" {{if .DefaultOrgVisibilityMode.IsPublic}}checked{{end}}> 22 + <input class="enable-system-radio" name="visibility" type="radio" value="0" {{if .DefaultOrgVisibilityMode.IsPublic}}checked{{end}}> 23 23 <label>{{.locale.Tr "org.settings.visibility.public"}}</label> 24 24 </div> 25 25 <div class="ui radio checkbox"> 26 - <input class="enable-system-radio" tabindex="0" name="visibility" type="radio" value="1" {{if .DefaultOrgVisibilityMode.IsLimited}}checked{{end}}> 26 + <input class="enable-system-radio" name="visibility" type="radio" value="1" {{if .DefaultOrgVisibilityMode.IsLimited}}checked{{end}}> 27 27 <label>{{.locale.Tr "org.settings.visibility.limited"}}</label> 28 28 </div> 29 29 <div class="ui radio checkbox"> 30 - <input class="enable-system-radio" tabindex="0" name="visibility" type="radio" value="2" {{if .DefaultOrgVisibilityMode.IsPrivate}}checked{{end}}> 30 + <input class="enable-system-radio" name="visibility" type="radio" value="2" {{if .DefaultOrgVisibilityMode.IsPrivate}}checked{{end}}> 31 31 <label>{{.locale.Tr "org.settings.visibility.private"}}</label> 32 32 </div> 33 33 </div>
+3 -3
templates/org/settings/options.tmpl
··· 40 40 <label for="visibility">{{.locale.Tr "org.settings.visibility"}}</label> 41 41 <div class="field"> 42 42 <div class="ui radio checkbox"> 43 - <input class="enable-system-radio" tabindex="0" name="visibility" type="radio" value="0" {{if eq .CurrentVisibility 0}}checked{{end}}> 43 + <input class="enable-system-radio" name="visibility" type="radio" value="0" {{if eq .CurrentVisibility 0}}checked{{end}}> 44 44 <label>{{.locale.Tr "org.settings.visibility.public"}}</label> 45 45 </div> 46 46 </div> 47 47 <div class="field"> 48 48 <div class="ui radio checkbox"> 49 - <input class="enable-system-radio" tabindex="0" name="visibility" type="radio" value="1" {{if eq .CurrentVisibility 1}}checked{{end}}> 49 + <input class="enable-system-radio" name="visibility" type="radio" value="1" {{if eq .CurrentVisibility 1}}checked{{end}}> 50 50 <label>{{.locale.Tr "org.settings.visibility.limited"}}</label> 51 51 </div> 52 52 </div> 53 53 <div class="field"> 54 54 <div class="ui radio checkbox"> 55 - <input class="enable-system-radio" tabindex="0" name="visibility" type="radio" value="2" {{if eq .CurrentVisibility 2}}checked{{end}}> 55 + <input class="enable-system-radio" name="visibility" type="radio" value="2" {{if eq .CurrentVisibility 2}}checked{{end}}> 56 56 <label>{{.locale.Tr "org.settings.visibility.private"}}</label> 57 57 </div> 58 58 </div>
+2 -2
templates/projects/view.tmpl
··· 76 76 </div> 77 77 {{if and $canWriteProject (ne .ID 0)}} 78 78 <div class="ui dropdown jump item"> 79 - <div class="gt-px-3" tabindex="-1"> 79 + <div class="gt-px-3"> 80 80 {{svg "octicon-kebab-horizontal"}} 81 81 </div> 82 - <div class="menu user-menu" tabindex="-1"> 82 + <div class="menu user-menu"> 83 83 <a class="item show-modal button" data-modal="#edit-project-column-modal-{{.ID}}"> 84 84 {{svg "octicon-pencil"}} 85 85 {{ctx.Locale.Tr "repo.projects.column.edit"}}
+9 -9
templates/repo/create.tmpl
··· 77 77 <div class="inline field"> 78 78 <label>{{.locale.Tr "repo.template.items"}}</label> 79 79 <div class="ui checkbox"> 80 - <input name="git_content" type="checkbox" tabindex="0" {{if .git_content}}checked{{end}}> 80 + <input name="git_content" type="checkbox" {{if .git_content}}checked{{end}}> 81 81 <label>{{.locale.Tr "repo.template.git_content"}}</label> 82 82 </div> 83 83 <div class="ui checkbox" {{if not .SignedUser.CanEditGitHook}}data-tooltip-content="{{.locale.Tr "repo.template.git_hooks_tooltip"}}"{{end}}> 84 - <input name="git_hooks" type="checkbox" tabindex="0" {{if .git_hooks}}checked{{end}}> 84 + <input name="git_hooks" type="checkbox" {{if .git_hooks}}checked{{end}}> 85 85 <label>{{.locale.Tr "repo.template.git_hooks"}}</label> 86 86 </div> 87 87 </div> 88 88 <div class="inline field"> 89 89 <label></label> 90 90 <div class="ui checkbox"> 91 - <input name="webhooks" type="checkbox" tabindex="0" {{if .webhooks}}checked{{end}}> 91 + <input name="webhooks" type="checkbox" {{if .webhooks}}checked{{end}}> 92 92 <label>{{.locale.Tr "repo.template.webhooks"}}</label> 93 93 </div> 94 94 <div class="ui checkbox"> 95 - <input name="topics" type="checkbox" tabindex="0" {{if .topics}}checked{{end}}> 95 + <input name="topics" type="checkbox" {{if .topics}}checked{{end}}> 96 96 <label>{{.locale.Tr "repo.template.topics"}}</label> 97 97 </div> 98 98 </div> 99 99 <div class="inline field"> 100 100 <label></label> 101 101 <div class="ui checkbox"> 102 - <input name="avatar" type="checkbox" tabindex="0" {{if .avatar}}checked{{end}}> 102 + <input name="avatar" type="checkbox" {{if .avatar}}checked{{end}}> 103 103 <label>{{.locale.Tr "repo.template.avatar"}}</label> 104 104 </div> 105 105 <div class="ui checkbox"> 106 - <input name="labels" type="checkbox" tabindex="0" {{if .labels}}checked{{end}}> 106 + <input name="labels" type="checkbox" {{if .labels}}checked{{end}}> 107 107 <label>{{.locale.Tr "repo.template.issue_labels"}}</label> 108 108 </div> 109 109 </div> 110 110 <div class="inline field"> 111 111 <label></label> 112 112 <div class="ui checkbox"> 113 - <input name="protected_branch" type="checkbox" tabindex="0" {{if .protected_branch}}checked{{end}}> 113 + <input name="protected_branch" type="checkbox" {{if .protected_branch}}checked{{end}}> 114 114 <label>{{.locale.Tr "repo.settings.protected_branch"}}</label> 115 115 </div> 116 116 </div> ··· 176 176 </div> 177 177 <div class="inline field"> 178 178 <div class="ui checkbox" id="auto-init"> 179 - <input name="auto_init" type="checkbox" tabindex="0" {{if .auto_init}}checked{{end}}> 179 + <input name="auto_init" type="checkbox" {{if .auto_init}}checked{{end}}> 180 180 <label>{{.locale.Tr "repo.auto_init"}}</label> 181 181 </div> 182 182 </div> ··· 211 211 <div class="inline field"> 212 212 <label>{{.locale.Tr "repo.template"}}</label> 213 213 <div class="ui checkbox"> 214 - <input name="template" type="checkbox" tabindex="0"> 214 + <input name="template" type="checkbox"> 215 215 <label>{{.locale.Tr "repo.template_helper"}}</label> 216 216 </div> 217 217 </div>
+1 -1
templates/repo/editor/commit_form.tmpl
··· 16 16 </div> 17 17 <div class="inline field"> 18 18 <div class="ui checkbox"> 19 - <input name="signoff" type="checkbox" tabindex="0"> 19 + <input name="signoff" type="checkbox"> 20 20 <label>{{.locale.Tr "repo.editor.signoff_desc"}}</label> 21 21 </div> 22 22 </div>
+2 -2
templates/repo/issue/new_form.tmpl
··· 11 11 {{ctx.AvatarUtils.Avatar .SignedUser 40}} 12 12 <div class="ui segment content gt-my-0"> 13 13 <div class="field"> 14 - <input name="title" id="issue_title" placeholder="{{.locale.Tr "repo.milestones.title"}}" value="{{if .TitleQuery}}{{.TitleQuery}}{{else if .IssueTemplateTitle}}{{.IssueTemplateTitle}}{{else}}{{.title}}{{end}}" tabindex="3" autofocus required maxlength="255" autocomplete="off"> 14 + <input name="title" id="issue_title" placeholder="{{.locale.Tr "repo.milestones.title"}}" value="{{if .TitleQuery}}{{.TitleQuery}}{{else if .IssueTemplateTitle}}{{.IssueTemplateTitle}}{{else}}{{.title}}{{end}}" autofocus required maxlength="255" autocomplete="off"> 15 15 {{if .PageIsComparePull}} 16 16 <div class="title_wip_desc" data-wip-prefixes="{{JsonUtils.EncodeToString .PullRequestWorkInProgressPrefixes}}">{{.locale.Tr "repo.pulls.title_wip_desc" (index .PullRequestWorkInProgressPrefixes 0| Escape) | Safe}}</div> 17 17 {{end}} ··· 35 35 {{template "repo/issue/comment_tab" .}} 36 36 {{end}} 37 37 <div class="text right"> 38 - <button class="ui green button" tabindex="6"> 38 + <button class="ui green button"> 39 39 {{if .PageIsComparePull}} 40 40 {{.locale.Tr "repo.pulls.create"}} 41 41 {{else}}
+1 -1
templates/repo/issue/view_content/sidebar.tmpl
··· 621 621 </div> 622 622 623 623 <div class="field"> 624 - <div class="ui fluid dropdown selection" tabindex="0"> 624 + <div class="ui fluid dropdown selection"> 625 625 626 626 <select name="reason"> 627 627 <option value=""> </option>
+5 -5
templates/repo/settings/options.tmpl
··· 315 315 <div class="field{{if not $isWikiEnabled}} disabled{{end}}" id="wiki_box"> 316 316 <div class="field"> 317 317 <div class="ui radio checkbox{{if $isWikiGlobalDisabled}} disabled{{end}}"{{if $isWikiGlobalDisabled}} data-tooltip-content="{{.locale.Tr "repo.unit_disabled"}}"{{end}}> 318 - <input class="enable-system-radio" tabindex="0" name="enable_external_wiki" type="radio" value="false" data-target="#external_wiki_box" {{if not (.Repository.UnitEnabled $.Context $.UnitTypeExternalWiki)}}checked{{end}}> 318 + <input class="enable-system-radio" name="enable_external_wiki" type="radio" value="false" data-target="#external_wiki_box" {{if not (.Repository.UnitEnabled $.Context $.UnitTypeExternalWiki)}}checked{{end}}> 319 319 <label>{{.locale.Tr "repo.settings.use_internal_wiki"}}</label> 320 320 </div> 321 321 </div> 322 322 <div class="field"> 323 323 <div class="ui radio checkbox{{if $isExternalWikiGlobalDisabled}} disabled{{end}}"{{if $isExternalWikiGlobalDisabled}} data-tooltip-content="{{.locale.Tr "repo.unit_disabled"}}"{{end}}> 324 - <input class="enable-system-radio" tabindex="0" name="enable_external_wiki" type="radio" value="true" data-target="#external_wiki_box" {{if .Repository.UnitEnabled $.Context $.UnitTypeExternalWiki}}checked{{end}}> 324 + <input class="enable-system-radio" name="enable_external_wiki" type="radio" value="true" data-target="#external_wiki_box" {{if .Repository.UnitEnabled $.Context $.UnitTypeExternalWiki}}checked{{end}}> 325 325 <label>{{.locale.Tr "repo.settings.use_external_wiki"}}</label> 326 326 </div> 327 327 </div> ··· 348 348 <div class="field {{if not $isIssuesEnabled}}disabled{{end}}" id="issue_box"> 349 349 <div class="field"> 350 350 <div class="ui radio checkbox{{if $isIssuesGlobalDisabled}} disabled{{end}}"{{if $isIssuesGlobalDisabled}} data-tooltip-content="{{.locale.Tr "repo.unit_disabled"}}"{{end}}> 351 - <input class="enable-system-radio" tabindex="0" name="enable_external_tracker" type="radio" value="false" data-context="#internal_issue_box" data-target="#external_issue_box" {{if not (.Repository.UnitEnabled $.Context $.UnitTypeExternalTracker)}}checked{{end}}> 351 + <input class="enable-system-radio" name="enable_external_tracker" type="radio" value="false" data-context="#internal_issue_box" data-target="#external_issue_box" {{if not (.Repository.UnitEnabled $.Context $.UnitTypeExternalTracker)}}checked{{end}}> 352 352 <label>{{.locale.Tr "repo.settings.use_internal_issue_tracker"}}</label> 353 353 </div> 354 354 </div> ··· 380 380 </div> 381 381 <div class="field"> 382 382 <div class="ui radio checkbox{{if $isExternalTrackerGlobalDisabled}} disabled{{end}}"{{if $isExternalTrackerGlobalDisabled}} data-tooltip-content="{{.locale.Tr "repo.unit_disabled"}}"{{end}}> 383 - <input class="enable-system-radio" tabindex="0" name="enable_external_tracker" type="radio" value="true" data-context="#internal_issue_box" data-target="#external_issue_box" {{if .Repository.UnitEnabled $.Context $.UnitTypeExternalTracker}}checked{{end}}> 383 + <input class="enable-system-radio" name="enable_external_tracker" type="radio" value="true" data-context="#internal_issue_box" data-target="#external_issue_box" {{if .Repository.UnitEnabled $.Context $.UnitTypeExternalTracker}}checked{{end}}> 384 384 <label>{{.locale.Tr "repo.settings.use_external_issue_tracker"}}</label> 385 385 </div> 386 386 </div> ··· 523 523 <p> 524 524 {{.locale.Tr "repo.settings.default_merge_style_desc"}} 525 525 </p> 526 - <div class="ui dropdown selection" tabindex="0"> 526 + <div class="ui dropdown selection"> 527 527 <select name="pulls_default_merge_style"> 528 528 <option value="merge" {{if or (not $pullRequestEnabled) (eq $prUnit.PullRequestsConfig.DefaultMergeStyle "merge")}}selected{{end}}>{{.locale.Tr "repo.pulls.merge_pull_request"}}</option> 529 529 <option value="rebase" {{if or (not $pullRequestEnabled) (eq $prUnit.PullRequestsConfig.DefaultMergeStyle "rebase")}}selected{{end}}>{{.locale.Tr "repo.pulls.rebase_merge_pull_request"}}</option>
+23 -23
templates/repo/settings/webhook/settings.tmpl
··· 31 31 <div class="seven wide column"> 32 32 <div class="field"> 33 33 <div class="ui checkbox"> 34 - <input name="create" type="checkbox" tabindex="0" {{if .Webhook.Create}}checked{{end}}> 34 + <input name="create" type="checkbox" {{if .Webhook.Create}}checked{{end}}> 35 35 <label>{{.locale.Tr "repo.settings.event_create"}}</label> 36 36 <span class="help">{{.locale.Tr "repo.settings.event_create_desc"}}</span> 37 37 </div> ··· 41 41 <div class="seven wide column"> 42 42 <div class="field"> 43 43 <div class="ui checkbox"> 44 - <input name="delete" type="checkbox" tabindex="0" {{if .Webhook.Delete}}checked{{end}}> 44 + <input name="delete" type="checkbox" {{if .Webhook.Delete}}checked{{end}}> 45 45 <label>{{.locale.Tr "repo.settings.event_delete"}}</label> 46 46 <span class="help">{{.locale.Tr "repo.settings.event_delete_desc"}}</span> 47 47 </div> ··· 51 51 <div class="seven wide column"> 52 52 <div class="field"> 53 53 <div class="ui checkbox"> 54 - <input name="fork" type="checkbox" tabindex="0" {{if .Webhook.Fork}}checked{{end}}> 54 + <input name="fork" type="checkbox" {{if .Webhook.Fork}}checked{{end}}> 55 55 <label>{{.locale.Tr "repo.settings.event_fork"}}</label> 56 56 <span class="help">{{.locale.Tr "repo.settings.event_fork_desc"}}</span> 57 57 </div> ··· 61 61 <div class="seven wide column"> 62 62 <div class="field"> 63 63 <div class="ui checkbox"> 64 - <input name="push" type="checkbox" tabindex="0" {{if .Webhook.Push}}checked{{end}}> 64 + <input name="push" type="checkbox" {{if .Webhook.Push}}checked{{end}}> 65 65 <label>{{.locale.Tr "repo.settings.event_push"}}</label> 66 66 <span class="help">{{.locale.Tr "repo.settings.event_push_desc"}}</span> 67 67 </div> ··· 71 71 <div class="seven wide column"> 72 72 <div class="field"> 73 73 <div class="ui checkbox"> 74 - <input name="repository" type="checkbox" tabindex="0" {{if .Webhook.Repository}}checked{{end}}> 74 + <input name="repository" type="checkbox" {{if .Webhook.Repository}}checked{{end}}> 75 75 <label>{{.locale.Tr "repo.settings.event_repository"}}</label> 76 76 <span class="help">{{.locale.Tr "repo.settings.event_repository_desc"}}</span> 77 77 </div> ··· 81 81 <div class="seven wide column"> 82 82 <div class="field"> 83 83 <div class="ui checkbox"> 84 - <input name="release" type="checkbox" tabindex="0" {{if .Webhook.Release}}checked{{end}}> 84 + <input name="release" type="checkbox" {{if .Webhook.Release}}checked{{end}}> 85 85 <label>{{.locale.Tr "repo.settings.event_release"}}</label> 86 86 <span class="help">{{.locale.Tr "repo.settings.event_release_desc"}}</span> 87 87 </div> ··· 91 91 <div class="seven wide column"> 92 92 <div class="field"> 93 93 <div class="ui checkbox"> 94 - <input name="package" type="checkbox" tabindex="0" {{if .Webhook.Package}}checked{{end}}> 94 + <input name="package" type="checkbox" {{if .Webhook.Package}}checked{{end}}> 95 95 <label>{{.locale.Tr "repo.settings.event_package"}}</label> 96 96 <span class="help">{{.locale.Tr "repo.settings.event_package_desc"}}</span> 97 97 </div> ··· 102 102 <div class="seven wide column"> 103 103 <div class="field"> 104 104 <div class="ui checkbox"> 105 - <input name="wiki" type="checkbox" tabindex="0" {{if .Webhook.Wiki}}checked{{end}}> 105 + <input name="wiki" type="checkbox" {{if .Webhook.Wiki}}checked{{end}}> 106 106 <label>{{.locale.Tr "repo.settings.event_wiki"}}</label> 107 107 <span class="help">{{.locale.Tr "repo.settings.event_wiki_desc"}}</span> 108 108 </div> ··· 117 117 <div class="seven wide column"> 118 118 <div class="field"> 119 119 <div class="ui checkbox"> 120 - <input name="issues" type="checkbox" tabindex="0" {{if .Webhook.Issues}}checked{{end}}> 120 + <input name="issues" type="checkbox" {{if .Webhook.Issues}}checked{{end}}> 121 121 <label>{{.locale.Tr "repo.settings.event_issues"}}</label> 122 122 <span class="help">{{.locale.Tr "repo.settings.event_issues_desc"}}</span> 123 123 </div> ··· 127 127 <div class="seven wide column"> 128 128 <div class="field"> 129 129 <div class="ui checkbox"> 130 - <input name="issue_assign" type="checkbox" tabindex="0" {{if .Webhook.IssueAssign}}checked{{end}}> 130 + <input name="issue_assign" type="checkbox" {{if .Webhook.IssueAssign}}checked{{end}}> 131 131 <label>{{.locale.Tr "repo.settings.event_issue_assign"}}</label> 132 132 <span class="help">{{.locale.Tr "repo.settings.event_issue_assign_desc"}}</span> 133 133 </div> ··· 137 137 <div class="seven wide column"> 138 138 <div class="field"> 139 139 <div class="ui checkbox"> 140 - <input name="issue_label" type="checkbox" tabindex="0" {{if .Webhook.IssueLabel}}checked{{end}}> 140 + <input name="issue_label" type="checkbox" {{if .Webhook.IssueLabel}}checked{{end}}> 141 141 <label>{{.locale.Tr "repo.settings.event_issue_label"}}</label> 142 142 <span class="help">{{.locale.Tr "repo.settings.event_issue_label_desc"}}</span> 143 143 </div> ··· 147 147 <div class="seven wide column"> 148 148 <div class="field"> 149 149 <div class="ui checkbox"> 150 - <input name="issue_milestone" type="checkbox" tabindex="0" {{if .Webhook.IssueMilestone}}checked{{end}}> 150 + <input name="issue_milestone" type="checkbox" {{if .Webhook.IssueMilestone}}checked{{end}}> 151 151 <label>{{.locale.Tr "repo.settings.event_issue_milestone"}}</label> 152 152 <span class="help">{{.locale.Tr "repo.settings.event_issue_milestone_desc"}}</span> 153 153 </div> ··· 157 157 <div class="seven wide column"> 158 158 <div class="field"> 159 159 <div class="ui checkbox"> 160 - <input name="issue_comment" type="checkbox" tabindex="0" {{if .Webhook.IssueComment}}checked{{end}}> 160 + <input name="issue_comment" type="checkbox" {{if .Webhook.IssueComment}}checked{{end}}> 161 161 <label>{{.locale.Tr "repo.settings.event_issue_comment"}}</label> 162 162 <span class="help">{{.locale.Tr "repo.settings.event_issue_comment_desc"}}</span> 163 163 </div> ··· 172 172 <div class="seven wide column"> 173 173 <div class="field"> 174 174 <div class="ui checkbox"> 175 - <input name="pull_request" type="checkbox" tabindex="0" {{if .Webhook.PullRequest}}checked{{end}}> 175 + <input name="pull_request" type="checkbox" {{if .Webhook.PullRequest}}checked{{end}}> 176 176 <label>{{.locale.Tr "repo.settings.event_pull_request"}}</label> 177 177 <span class="help">{{.locale.Tr "repo.settings.event_pull_request_desc"}}</span> 178 178 </div> ··· 182 182 <div class="seven wide column"> 183 183 <div class="field"> 184 184 <div class="ui checkbox"> 185 - <input name="pull_request_assign" type="checkbox" tabindex="0" {{if .Webhook.PullRequestAssign}}checked{{end}}> 185 + <input name="pull_request_assign" type="checkbox" {{if .Webhook.PullRequestAssign}}checked{{end}}> 186 186 <label>{{.locale.Tr "repo.settings.event_pull_request_assign"}}</label> 187 187 <span class="help">{{.locale.Tr "repo.settings.event_pull_request_assign_desc"}}</span> 188 188 </div> ··· 192 192 <div class="seven wide column"> 193 193 <div class="field"> 194 194 <div class="ui checkbox"> 195 - <input name="pull_request_label" type="checkbox" tabindex="0" {{if .Webhook.PullRequestLabel}}checked{{end}}> 195 + <input name="pull_request_label" type="checkbox" {{if .Webhook.PullRequestLabel}}checked{{end}}> 196 196 <label>{{.locale.Tr "repo.settings.event_pull_request_label"}}</label> 197 197 <span class="help">{{.locale.Tr "repo.settings.event_pull_request_label_desc"}}</span> 198 198 </div> ··· 202 202 <div class="seven wide column"> 203 203 <div class="field"> 204 204 <div class="ui checkbox"> 205 - <input name="pull_request_milestone" type="checkbox" tabindex="0" {{if .Webhook.PullRequestMilestone}}checked{{end}}> 205 + <input name="pull_request_milestone" type="checkbox" {{if .Webhook.PullRequestMilestone}}checked{{end}}> 206 206 <label>{{.locale.Tr "repo.settings.event_pull_request_milestone"}}</label> 207 207 <span class="help">{{.locale.Tr "repo.settings.event_pull_request_milestone_desc"}}</span> 208 208 </div> ··· 212 212 <div class="seven wide column"> 213 213 <div class="field"> 214 214 <div class="ui checkbox"> 215 - <input name="pull_request_comment" type="checkbox" tabindex="0" {{if .Webhook.PullRequestComment}}checked{{end}}> 215 + <input name="pull_request_comment" type="checkbox" {{if .Webhook.PullRequestComment}}checked{{end}}> 216 216 <label>{{.locale.Tr "repo.settings.event_pull_request_comment"}}</label> 217 217 <span class="help">{{.locale.Tr "repo.settings.event_pull_request_comment_desc"}}</span> 218 218 </div> ··· 222 222 <div class="seven wide column"> 223 223 <div class="field"> 224 224 <div class="ui checkbox"> 225 - <input name="pull_request_review" type="checkbox" tabindex="0" {{if .Webhook.PullRequestReview}}checked{{end}}> 225 + <input name="pull_request_review" type="checkbox" {{if .Webhook.PullRequestReview}}checked{{end}}> 226 226 <label>{{.locale.Tr "repo.settings.event_pull_request_review"}}</label> 227 227 <span class="help">{{.locale.Tr "repo.settings.event_pull_request_review_desc"}}</span> 228 228 </div> ··· 232 232 <div class="seven wide column"> 233 233 <div class="field"> 234 234 <div class="ui checkbox"> 235 - <input name="pull_request_sync" type="checkbox" tabindex="0" {{if .Webhook.PullRequestSync}}checked{{end}}> 235 + <input name="pull_request_sync" type="checkbox" {{if .Webhook.PullRequestSync}}checked{{end}}> 236 236 <label>{{.locale.Tr "repo.settings.event_pull_request_sync"}}</label> 237 237 <span class="help">{{.locale.Tr "repo.settings.event_pull_request_sync_desc"}}</span> 238 238 </div> ··· 242 242 <div class="seven wide column"> 243 243 <div class="field"> 244 244 <div class="ui checkbox"> 245 - <input name="pull_request_review_request" type="checkbox" tabindex="0" {{if .Webhook.PullRequestReviewRequest}}checked{{end}}> 245 + <input name="pull_request_review_request" type="checkbox" {{if .Webhook.PullRequestReviewRequest}}checked{{end}}> 246 246 <label>{{.locale.Tr "repo.settings.event_pull_request_review_request"}}</label> 247 247 <span class="help">{{.locale.Tr "repo.settings.event_pull_request_review_request_desc"}}</span> 248 248 </div> ··· 254 254 <!-- Branch filter --> 255 255 <div class="field"> 256 256 <label for="branch_filter">{{.locale.Tr "repo.settings.branch_filter"}}</label> 257 - <input name="branch_filter" type="text" tabindex="0" value="{{or .Webhook.BranchFilter "*"}}"> 257 + <input name="branch_filter" type="text" value="{{or .Webhook.BranchFilter "*"}}"> 258 258 <span class="help">{{.locale.Tr "repo.settings.branch_filter_desc" | Str2html}}</span> 259 259 </div> 260 260 ··· 271 271 272 272 <div class="inline field"> 273 273 <div class="ui checkbox"> 274 - <input name="active" type="checkbox" tabindex="0" {{if or $isNew .Webhook.IsActive}}checked{{end}}> 274 + <input name="active" type="checkbox" {{if or $isNew .Webhook.IsActive}}checked{{end}}> 275 275 <label>{{.locale.Tr "repo.settings.active"}}</label> 276 276 <span class="help">{{.locale.Tr "repo.settings.active_helper"}}</span> 277 277 </div>
+2 -2
templates/user/dashboard/navbar.tmpl
··· 11 11 </span> 12 12 {{svg "octicon-triangle-down" 14 "dropdown icon"}} 13 13 </span> 14 - <div class="context user overflow menu" tabindex="-1"> 14 + <div class="context user overflow menu"> 15 15 <div class="ui header"> 16 16 {{.locale.Tr "home.switch_dashboard_context"}} 17 17 </div> ··· 55 55 {{end}} 56 56 {{svg "octicon-triangle-down" 14 "dropdown icon"}} 57 57 </span> 58 - <div class="context user overflow menu" tabindex="-1"> 58 + <div class="context user overflow menu"> 59 59 <div class="ui header"> 60 60 {{.locale.Tr "home.filter_by_team_repositories"}} 61 61 </div>
+3 -4
web_src/js/components/DiffCommitSelector.vue
··· 6 6 @click.stop="toggleMenu()" 7 7 :data-tooltip-content="locale.filter_changes_by_commit" 8 8 aria-haspopup="true" 9 - tabindex="0" 10 9 aria-controls="diff-commit-selector-menu" 11 10 :aria-label="locale.filter_changes_by_commit" 12 11 aria-activedescendant="diff-commit-list-show-all" ··· 15 14 </button> 16 15 <div class="menu left transition" id="diff-commit-selector-menu" :class="{visible: menuVisible}" v-show="menuVisible" v-cloak :aria-expanded="menuVisible ? 'true': 'false'"> 17 16 <div class="loading-indicator is-loading" v-if="isLoading"/> 18 - <div v-if="!isLoading" class="vertical item gt-df gt-fc gt-gap-2" id="diff-commit-list-show-all" role="menuitem" tabindex="-1" @keydown.enter="showAllChanges()" @click="showAllChanges()"> 17 + <div v-if="!isLoading" class="vertical item gt-df gt-fc gt-gap-2" id="diff-commit-list-show-all" role="menuitem" @keydown.enter="showAllChanges()" @click="showAllChanges()"> 19 18 <div class="gt-ellipsis"> 20 19 {{ locale.show_all_commits }} 21 20 </div> ··· 25 24 </div> 26 25 <!-- only show the show changes since last review if there is a review AND we are commits ahead of the last review --> 27 26 <div 28 - v-if="lastReviewCommitSha != null" role="menuitem" tabindex="-1" 27 + v-if="lastReviewCommitSha != null" role="menuitem" 29 28 class="vertical item gt-df gt-fc gt-gap-2 gt-border-secondary-top" 30 29 :class="{disabled: commitsSinceLastReview === 0}" 31 30 @keydown.enter="changesSinceLastReviewClick()" ··· 41 40 <span v-if="!isLoading" class="info gt-border-secondary-top text light-2">{{ locale.select_commit_hold_shift_for_range }}</span> 42 41 <template v-for="commit in commits" :key="commit.id"> 43 42 <div 44 - class="vertical item gt-df gt-gap-2 gt-border-secondary-top" role="menuitem" tabindex="-1" 43 + class="vertical item gt-df gt-gap-2 gt-border-secondary-top" role="menuitem" 45 44 :class="{selection: commit.selected, hovered: commit.hovered}" 46 45 @keydown.enter.exact="commitClicked(commit.id)" 47 46 @keydown.enter.shift.exact="commitClickedShift(commit)"