loading up the forgejo repo on tangled to test page performance
0
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix milestones deletion (#25583)

Close #25557
Fix regression from #25315

`data-id` is still needed for deleting milestone.

authored by

HesterG and committed by
GitHub
5a871932 c76b221c

+2 -2
+1 -1
templates/repo/issue/milestones.tmpl
··· 114 114 {{else}} 115 115 <a class="link-action flex-text-inline" href data-url="{{$.Link}}/{{.ID}}/close">{{svg "octicon-x" 14}}{{$.locale.Tr "repo.milestones.close"}}</a> 116 116 {{end}} 117 - <a class="delete-button flex-text-inline" href="#" data-url="{{$.RepoLink}}/milestones/delete">{{svg "octicon-trash" 14}}{{$.locale.Tr "repo.issues.label_delete"}}</a> 117 + <a class="delete-button flex-text-inline" href="#" data-url="{{$.RepoLink}}/milestones/delete" data-id="{{.ID}}">{{svg "octicon-trash" 14}}{{$.locale.Tr "repo.issues.label_delete"}}</a> 118 118 </div> 119 119 {{end}} 120 120 </div>
+1 -1
templates/user/dashboard/milestones.tmpl
··· 135 135 {{else}} 136 136 <a class="link-action flex-text-inline" href data-url="{{$.Link}}/{{.ID}}/close">{{svg "octicon-x" 14}}{{$.locale.Tr "repo.milestones.close"}}</a> 137 137 {{end}} 138 - <a class="delete-button flex-text-inline" href="#" data-url="{{$.RepoLink}}/milestones/delete">{{svg "octicon-trash" 14}}{{$.locale.Tr "repo.issues.label_delete"}}</a> 138 + <a class="delete-button flex-text-inline" href="#" data-url="{{$.RepoLink}}/milestones/delete" data-id="{{.ID}}">{{svg "octicon-trash" 14}}{{$.locale.Tr "repo.issues.label_delete"}}</a> 139 139 </div> 140 140 {{end}} 141 141 </div>