loading up the forgejo repo on tangled to test page performance
Merge pull request 'Fix bad spacing on new release page' (#5261) from maltejur/forgejo:push-nnnyrrvzlqqy into forgejo
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/5261
Reviewed-by: Otto <otto@codeberg.org>
+30
-30
+21
-25
templates/repo/release/new.tmpl
+21
-25
templates/repo/release/new.tmpl
···
99
99
{{ctx.Locale.Tr "remove"}}
100
100
</a>
101
101
</div>
102
-
<a class="ui mini button tw-float-right tw-mb-4 tw-mt-2" id="add-external-link">
102
+
<button type="button" class="ui mini button tw-float-right tw-mb-4 tw-mt-2" id="add-external-link">
103
103
{{ctx.Locale.Tr "repo.release.add_external_asset"}}
104
-
</a>
104
+
</button>
105
105
{{if .IsAttachmentEnabled}}
106
106
<div class="field">
107
107
{{template "repo/upload" .}}
···
111
111
<div class="divider"></div>
112
112
<div class="ui">
113
113
<div>
114
-
{{if not .PageIsEditRelease}}
115
-
<div class="tag-message field">
116
-
<div class="ui checkbox">
114
+
<fieldset>
115
+
{{if not .PageIsEditRelease}}
116
+
<label>
117
117
<input type="checkbox" name="add_tag_msg">
118
-
<label><strong>{{ctx.Locale.Tr "repo.release.add_tag_msg"}}</strong></label>
119
-
</div>
120
-
</div>
121
-
{{else}}
122
-
<input type="hidden" name="add_tag_msg" value="false">
123
-
{{end}}
124
-
<div class="prerelease field">
125
-
<div class="ui checkbox">
118
+
{{ctx.Locale.Tr "repo.release.add_tag_msg"}}
119
+
</label>
120
+
{{else}}
121
+
<input type="hidden" name="add_tag_msg" value="false">
122
+
{{end}}
123
+
<label>
126
124
<input type="checkbox" name="prerelease" {{if .prerelease}}checked{{end}}>
127
-
<label><strong>{{ctx.Locale.Tr "repo.release.prerelease_desc"}}</strong></label>
128
-
</div>
129
-
</div>
130
-
<span class="help">{{ctx.Locale.Tr "repo.release.prerelease_helper"}}</span>
131
-
{{if not .DisableDownloadSourceArchives}}
132
-
<div class="field">
133
-
<div class="ui checkbox">
125
+
{{ctx.Locale.Tr "repo.release.prerelease_desc"}}
126
+
<span class="help">{{ctx.Locale.Tr "repo.release.prerelease_helper"}}</span>
127
+
</label>
128
+
{{if not .DisableDownloadSourceArchives}}
129
+
<label>
134
130
<input type="checkbox" name="hide_archive_links" {{if .hide_archive_links}}checked{{end}}>
135
-
<label><strong>{{ctx.Locale.Tr "repo.release.hide_archive_links"}}</strong></label>
136
-
</div>
137
-
</div>
138
-
<span class="help">{{ctx.Locale.Tr "repo.release.hide_archive_links_helper"}}</span>
139
-
{{end}}
131
+
{{ctx.Locale.Tr "repo.release.hide_archive_links"}}
132
+
<span class="help">{{ctx.Locale.Tr "repo.release.hide_archive_links_helper"}}</span>
133
+
</label>
134
+
{{end}}
135
+
</fieldset>
140
136
<div class="divider tw-mt-0"></div>
141
137
<div class="tw-flex tw-justify-end button-row">
142
138
{{if .PageIsEditRelease}}
+3
tests/e2e/release.test.e2e.js
+3
tests/e2e/release.test.e2e.js
···
1
1
// @ts-check
2
2
import {expect} from '@playwright/test';
3
3
import {test, login_user, save_visual, load_logged_in_context} from './utils_e2e.js';
4
+
import {validate_form} from './shared/forms.js';
4
5
5
6
test.beforeAll(async ({browser}, workerInfo) => {
6
7
await login_user(browser, workerInfo, 'user2');
···
23
24
24
25
// Fill out form and create new release
25
26
await expect(page).toHaveURL('/user2/repo2/releases/new');
27
+
await validate_form({page}, 'fieldset');
26
28
await page.fill('input[name=tag_name]', '2.0');
27
29
await page.fill('input[name=title]', '2.0');
28
30
await page.click('#add-external-link');
···
43
45
44
46
// Validate edit page and edit the release
45
47
await expect(page).toHaveURL('/user2/repo2/releases/edit/2.0');
48
+
await validate_form({page}, 'fieldset');
46
49
await expect(page.locator('.attachment_edit:visible')).toHaveCount(2);
47
50
await expect(page.locator('.attachment_edit:visible').nth(0)).toHaveValue('Test');
48
51
await expect(page.locator('.attachment_edit:visible').nth(1)).toHaveValue('https://forgejo.org/');
+6
-1
web_src/css/form.css
+6
-1
web_src/css/form.css
···
10
10
11
11
fieldset label {
12
12
display: block;
13
+
margin-bottom: 0.6em;
13
14
}
14
15
15
16
fieldset label:has(input[type="text"]),
···
19
20
20
21
fieldset .help {
21
22
font-weight: var(--font-weight-normal);
22
-
display: block !important; /* overrides another rule in this file, remove when obsolete */
23
+
}
24
+
25
+
.form fieldset .help { /* overrides other .form .help rules in this file, remove when obsolete */
26
+
display: block !important;
27
+
padding-bottom: 0;
23
28
}
24
29
25
30
fieldset input[type="checkbox"],
-4
web_src/css/repo/release-tag.css
-4
web_src/css/repo/release-tag.css