loading up the forgejo repo on tangled to test page performance
0
fork

Configure Feed

Select the types of activity you want to include in your feed.

Merge pull request 'Fix New issue button position consistency' (#2845) from 0ko/forgejo:issue-button-const into forgejo

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2845
Reviewed-by: Gusted <gusted@noreply.codeberg.org>

+17 -4
+1 -1
templates/repo/issue/list.tmpl
··· 14 14 </div> 15 15 {{end}} 16 16 17 - <div class="list-header"> 17 + <div class="list-header list-header-issues"> 18 18 {{template "repo/issue/navbar" .}} 19 19 {{template "repo/issue/search" .}} 20 20 {{if not .Repository.IsArchived}}
+1 -1
templates/repo/issue/view_title.tmpl
··· 14 14 </h1> 15 15 <div class="issue-title-buttons"> 16 16 {{if and (or .HasIssuesOrPullsWritePermission .IsIssuePoster) (not .Repository.IsArchived)}} 17 - <button id="edit-title" class="ui small basic button edit-button not-in-edit{{if .Issue.IsPull}} tw-mr-0{{end}}">{{ctx.Locale.Tr "repo.issues.edit"}}</button> 17 + <button id="edit-title" class="ui small basic button edit-button not-in-edit tw-mr-0">{{ctx.Locale.Tr "repo.issues.edit"}}</button> 18 18 {{end}} 19 19 {{if not .Issue.IsPull}} 20 20 <a role="button" class="ui small primary button new-issue-button tw-mr-0" href="{{.RepoLink}}/issues/new{{if .NewIssueChooseTemplate}}/choose{{end}}">{{ctx.Locale.Tr "repo.issues.new"}}</a>
+1
web_src/css/base.css
··· 21 21 --border-radius-circle: 50%; 22 22 --opacity-disabled: 0.55; 23 23 --height-loading: 16rem; 24 + --repo-header-issue-min-height: 41px; 24 25 --min-height-textarea: 132px; /* padding + 6 lines + border = calc(1.57142em + 6lh + 2px), but lh is not fully supported */ 25 26 --tab-size: 4; 26 27 }
+6 -2
web_src/css/repo.css
··· 569 569 display: flex; 570 570 } 571 571 572 + .issue-title-buttons { 573 + gap: 0.5rem; 574 + } 575 + 572 576 @media (max-width: 767.98px) { 573 577 .repository.view.issue .issue-title { 574 578 flex-direction: column; ··· 611 615 line-height: 40px; 612 616 margin: 0; 613 617 padding-right: 0.25rem; 614 - min-height: 41px; /* avoid layout shift on edit */ 618 + min-height: var(--repo-header-issue-min-height); 615 619 } 616 620 617 621 .repository.view.issue .issue-title h1 .ui.input { ··· 2180 2184 margin: 0 !important; 2181 2185 position: relative; 2182 2186 color: var(--color-text); 2183 - min-height: 41px; 2187 + min-height: var(--repo-header-issue-min-height); 2184 2188 background-color: var(--color-box-header); 2185 2189 display: flex; 2186 2190 justify-content: space-between;
+8
web_src/css/repo/issue-list.css
··· 16 16 flex-wrap: wrap; 17 17 } 18 18 19 + .issue-list-new.button { 20 + margin-right: 0; 21 + } 22 + 23 + .list-header-issues { 24 + min-height: var(--repo-header-issue-min-height); 25 + } 26 + 19 27 @media (max-width: 767.98px) { 20 28 .issue-list-navbar { 21 29 order: 0;