oppi.li / perf-test
loading up the forgejo repo on tangled to test page performance
0
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix Actions being enabled accidentally (#24802)

Regression of #24536. If the user doesn't explicitly disable Actions, it
will be enabled.

1. Gitea will call `loadRepositoryFrom` before `loadActionsFrom`.

https://github.com/go-gitea/gitea/blob/25d4f95df25dae5226e96e813dde87b071d9155e/modules/setting/setting.go#L234-L237
2. In `loadRepositoryFrom`,
`rootCfg.Section("actions").Key("ENABLED").MustBool(true)` will set
`actions.ENABLED` with `true`.

https://github.com/go-gitea/gitea/blob/25d4f95df25dae5226e96e813dde87b071d9155e/modules/setting/repository.go#L313-L315
3. In `loadActionsFrom`, `rootCfg.Section("actions")` will get a section
with Actions enabled.

https://github.com/go-gitea/gitea/blob/25d4f95df25dae5226e96e813dde87b071d9155e/modules/setting/actions.go#L23-L26

Although the cause of the problem was using `true` by copy-paste
mistake, it also surprised me that
**`rootCfg.Section("actions").Key("ENABLED").MustBool(true)` doesn't
only read, but also write.**

authored by

Jason Song and committed by
GitHub 7985cde8 3eecde3f

+2 -2
+2 -2
modules/setting/repository.go
··· 306 306 log.Fatal("Failed to map Repository.PullRequest settings: %v", err) 307 307 } 308 308 309 - if !rootCfg.Section("packages").Key("ENABLED").MustBool(true) { 309 + if !rootCfg.Section("packages").Key("ENABLED").MustBool(Packages.Enabled) { 310 310 Repository.DisabledRepoUnits = append(Repository.DisabledRepoUnits, "repo.packages") 311 311 } 312 312 313 - if !rootCfg.Section("actions").Key("ENABLED").MustBool(true) { 313 + if !rootCfg.Section("actions").Key("ENABLED").MustBool(Actions.Enabled) { 314 314 Repository.DisabledRepoUnits = append(Repository.DisabledRepoUnits, "repo.actions") 315 315 } 316 316