loading up the forgejo repo on tangled to test page performance
0
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix wrong commit status in web ui (#26121)

Before:

![image](https://github.com/go-gitea/gitea/assets/18380374/8c5643b5-5c16-4674-9fe6-9e7fa2dda0b9)
After:

![image](https://github.com/go-gitea/gitea/assets/18380374/caf8891b-14df-418d-a7eb-977b54b9e9be)

There's a bug in the recent logic, `CalcCommitStatus` will always return
the first item of `statuses` or error status, because `state` is defined
with default value which should be `CommitStatusSuccess`

Then
``` golang
if status.State.NoBetterThan(state) {
```
this `if` will always return false unless `status.State =
CommitStatusError` which makes no sense.
So `lastStatus` will always be `nil` or error status.
Then we will always return the first item of `statuses` here or only
return error status, and this is why in the first picture the commit
status is `Success` but not `Failure`.

https://github.com/go-gitea/gitea/blob/af1ffbcd63569df8646b20c524378f25710f129e/models/git/commit_status.go#L204-L211

Co-authored-by: Giteabot <teabot@gitea.io>

authored by

yp05327
Giteabot
and committed by
GitHub
7a687cac ab72f7ee

+1 -1
+1 -1
models/git/commit_status.go
··· 194 194 // CalcCommitStatus returns commit status state via some status, the commit statues should order by id desc 195 195 func CalcCommitStatus(statuses []*CommitStatus) *CommitStatus { 196 196 var lastStatus *CommitStatus 197 - var state api.CommitStatusState 197 + state := api.CommitStatusSuccess 198 198 for _, status := range statuses { 199 199 if status.State.NoBetterThan(state) { 200 200 state = status.State