oppi.li / perf-test
loading up the forgejo repo on tangled to test page performance
0
fork

Configure Feed

Select the types of activity you want to include in your feed.

fix(ui): use usual and consistent size for project icons of 16 (#7175)

18px is not a size used for icons often. In these cases it was also inconsistent with most of the UI.

Affected areas:
* `filter_list` - dropdown, filtering repo issues by project
* `filter_actions` - dropdown, mass-editing issues via issue list
* `sidebar/projects` - dropdown in issue view
* `new_form` - dropdown when creating issue. Projects must be enabled in repo

So all areas are dropdowns. I think these were inconsistent because other dropdowns like Reviewers and Milestones use the usual icons of 16px.

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/7175
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
Co-authored-by: 0ko <0ko@noreply.codeberg.org>
Co-committed-by: 0ko <0ko@noreply.codeberg.org>

authored by

0ko
0ko and committed by
Gusted 8fce7fbe 49694242

+10 -10
+2 -2
templates/repo/issue/filter_actions.tmpl
··· 85 85 </div> 86 86 {{range .OpenProjects}} 87 87 <div class="item issue-action" data-element-id="{{.ID}}" data-url="{{$.RepoLink}}/issues/projects"> 88 - {{svg .IconName 18 "tw-mr-2"}}{{.Title}} 88 + {{svg .IconName 16 "tw-mr-2"}}{{.Title}} 89 89 </div> 90 90 {{end}} 91 91 {{end}} ··· 96 96 </div> 97 97 {{range .ClosedProjects}} 98 98 <div class="item issue-action" data-element-id="{{.ID}}" data-url="{{$.RepoLink}}/issues/projects"> 99 - {{svg .IconName 18 "tw-mr-2"}}{{.Title}} 99 + {{svg .IconName 16 "tw-mr-2"}}{{.Title}} 100 100 </div> 101 101 {{end}} 102 102 {{end}}
+2 -2
templates/repo/issue/filter_list.tmpl
··· 60 60 </div> 61 61 {{range .OpenProjects}} 62 62 <a rel="nofollow" class="{{if $.ProjectID}}{{if eq $.ProjectID .ID}}active selected{{end}}{{end}} item tw-flex" href="?q={{$.Keyword}}&type={{$.ViewType}}&sort={{$.SortType}}&state={{$.State}}&labels={{$.SelectLabels}}&milestone={{$.MilestoneID}}&project={{.ID}}&assignee={{$.AssigneeID}}&poster={{$.PosterID}}{{if $.ShowArchivedLabels}}&archived=true{{end}}"> 63 - {{svg .IconName 18 "tw-mr-2 tw-shrink-0"}}<span class="gt-ellipsis">{{.Title}}</span> 63 + {{svg .IconName 16 "tw-mr-2 tw-shrink-0"}}<span class="gt-ellipsis">{{.Title}}</span> 64 64 </a> 65 65 {{end}} 66 66 {{end}} ··· 71 71 </div> 72 72 {{range .ClosedProjects}} 73 73 <a rel="nofollow" class="{{if $.ProjectID}}{{if eq $.ProjectID .ID}}active selected{{end}}{{end}} item" href="?q={{$.Keyword}}&type={{$.ViewType}}&sort={{$.SortType}}&state={{$.State}}&labels={{$.SelectLabels}}&milestone={{$.MilestoneID}}&project={{.ID}}&assignee={{$.AssigneeID}}&poster={{$.PosterID}}{{if $.ShowArchivedLabels}}&archived=true{{end}}"> 74 - {{svg .IconName 18 "tw-mr-2"}}{{.Title}} 74 + {{svg .IconName 16 "tw-mr-2"}}{{.Title}} 75 75 </a> 76 76 {{end}} 77 77 {{end}}
+3 -3
templates/repo/issue/new_form.tmpl
··· 110 110 </div> 111 111 {{range .OpenProjects}} 112 112 <a class="item muted sidebar-item-link" data-id="{{.ID}}" data-href="{{.Link ctx}}"> 113 - {{svg .IconName 18 "tw-mr-2"}}{{.Title}} 113 + {{svg .IconName 16 "tw-mr-2"}}{{.Title}} 114 114 </a> 115 115 {{end}} 116 116 {{end}} ··· 121 121 </div> 122 122 {{range .ClosedProjects}} 123 123 <a class="item muted sidebar-item-link" data-id="{{.ID}}" data-href="{{.Link ctx}}"> 124 - {{svg .IconName 18 "tw-mr-2"}}{{.Title}} 124 + {{svg .IconName 16 "tw-mr-2"}}{{.Title}} 125 125 </a> 126 126 {{end}} 127 127 {{end}} ··· 133 133 <div class="selected"> 134 134 {{if .Project}} 135 135 <a class="item muted sidebar-item-link" href="{{.Project.Link ctx}}"> 136 - {{svg .Project.IconName 18 "tw-mr-2"}}{{.Project.Title}} 136 + {{svg .Project.IconName 16 "tw-mr-2"}}{{.Project.Title}} 137 137 </a> 138 138 {{end}} 139 139 </div>
+3 -3
templates/repo/issue/view_content/sidebar/projects.tmpl
··· 25 25 </div> 26 26 {{range .OpenProjects}} 27 27 <a class="item muted sidebar-item-link" data-id="{{.ID}}" data-href="{{.Link ctx}}"> 28 - {{svg .IconName 18 "tw-mr-2"}}{{.Title}} 28 + {{svg .IconName 16 "tw-mr-2"}}{{.Title}} 29 29 </a> 30 30 {{end}} 31 31 {{end}} ··· 36 36 </div> 37 37 {{range .ClosedProjects}} 38 38 <a class="item muted sidebar-item-link" data-id="{{.ID}}" data-href="{{.Link ctx}}"> 39 - {{svg .IconName 18 "tw-mr-2"}}{{.Title}} 39 + {{svg .IconName 16 "tw-mr-2"}}{{.Title}} 40 40 </a> 41 41 {{end}} 42 42 {{end}} ··· 47 47 <div class="selected"> 48 48 {{if .Issue.Project}} 49 49 <a class="item muted sidebar-item-link" href="{{.Issue.Project.Link ctx}}"> 50 - {{svg .Issue.Project.IconName 18 "tw-mr-2"}}{{.Issue.Project.Title}} 50 + {{svg .Issue.Project.IconName 16 "tw-mr-2"}}{{.Issue.Project.Title}} 51 51 </a> 52 52 {{end}} 53 53 </div>