oppi.li / perf-test
loading up the forgejo repo on tangled to test page performance
0
fork

Configure Feed

Select the types of activity you want to include in your feed.

fix(ui): display verified icon for default gpg key (#6803)

I noticed that the icon next to the GPG key reference appears to be incorrect for commits signed by the default GPG key.

Looking into the commit history of the template file, I noticed that Forgejo-signed commits originally had a distinct icon:
gitea-unlock-cog --> octicon-shield-lock --> octicon-unverified (current)

Since octicon-unverified is also used when a commit cannot be verified (.Verification.Warning), I find it misleading for successfully signed commits. This PR changes the icon to the verified variant for better clarity.

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/6803
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
Reviewed-by: Otto <otto@codeberg.org>
Co-authored-by: shgew <shgew@noreply.codeberg.org>
Co-committed-by: shgew <shgew@noreply.codeberg.org>

authored by

shgew
shgew and committed by
Gusted 93f84db5 c48f8579

+1 -2
+1 -2
templates/repo/commit_page.tmpl
··· 217 217 </div> 218 218 <div class="tw-flex tw-items-center"> 219 219 {{if .Verification.Verified}} 220 + {{svg "octicon-verified" 16 "tw-mr-2"}} 220 221 {{if ne .Verification.SigningUser.ID 0}} 221 - {{svg "octicon-verified" 16 "tw-mr-2"}} 222 222 {{if .Verification.SigningSSHKey}} 223 223 <span class="ui text tw-mr-2">{{ctx.Locale.Tr "repo.commits.ssh_key_fingerprint"}}:</span> 224 224 {{.Verification.SigningSSHKey.Fingerprint}} ··· 227 227 {{.Verification.SigningKey.PaddedKeyID}} 228 228 {{end}} 229 229 {{else}} 230 - {{svg "octicon-unverified" 16 "tw-mr-2"}} 231 230 {{if .Verification.SigningSSHKey}} 232 231 <span class="ui text tw-mr-2" data-tooltip-content="{{ctx.Locale.Tr "gpg.default_key"}}">{{ctx.Locale.Tr "repo.commits.ssh_key_fingerprint"}}:</span> 233 232 {{.Verification.SigningSSHKey.Fingerprint}}