loading up the forgejo repo on tangled to test page performance
fix(ui): make Finish review button work again (#6818)
I bricked the Finish review button in https://codeberg.org/forgejo/forgejo/pulls/6729 because I was naive and thought there are no mines laid within JS. I was wrong, because review panel was expected to be a child of review button. I switched both selectors to context of reviewBox.
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/6818
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
Co-authored-by: 0ko <0ko@noreply.codeberg.org>
Co-committed-by: 0ko <0ko@noreply.codeberg.org>
+27
-2
+25
tests/e2e/pr-review.test.e2e.ts
+25
tests/e2e/pr-review.test.e2e.ts
···
1
+
// Copyright 2025 The Forgejo Authors. All rights reserved.
2
+
// SPDX-License-Identifier: GPL-3.0-or-later
3
+
4
+
// @watch start
5
+
// templates/repo/diff/new_review.tmpl
6
+
// web_src/js/features/repo-issue.js
7
+
// @watch end
8
+
9
+
import {expect} from '@playwright/test';
10
+
import {save_visual, test} from './utils_e2e.ts';
11
+
12
+
test.use({user: 'user2'});
13
+
14
+
test('PR: Finish review', async ({page}) => {
15
+
const response = await page.goto('/user2/repo1/pulls/5/files');
16
+
expect(response?.status()).toBe(200);
17
+
18
+
await expect(page.locator('.tippy-box .review-box-panel')).toBeHidden();
19
+
await save_visual(page);
20
+
21
+
// Review panel should appear after clicking Finish review
22
+
await page.locator('#review-box .js-btn-review').click();
23
+
await expect(page.locator('.tippy-box .review-box-panel')).toBeVisible();
24
+
await save_visual(page);
25
+
});
+2
-2
web_src/js/features/repo-issue.js
+2
-2
web_src/js/features/repo-issue.js
···
517
517
// The following part is only for diff views
518
518
if (!$('.repository.pull.diff').length) return;
519
519
520
-
const $reviewBtn = $('.js-btn-review');
521
-
const $panel = $reviewBtn.parent().find('.review-box-panel');
520
+
const $reviewBtn = $reviewBox.parent().find('.js-btn-review');
521
+
const $panel = $reviewBox.parent().find('.review-box-panel');
522
522
const $closeBtn = $panel.find('.close');
523
523
524
524
if ($reviewBtn.length && $panel.length) {