loading up the forgejo repo on tangled to test page performance
Merge pull request '[BUG] Fix Ctrl+Enter on submitting review comment' (#2370) from gusted/forgejo-review-ctrlenter into forgejo
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2370
Reviewed-by: Otto <otto@codeberg.org>
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
+5
-2
+5
-2
web_src/js/features/repo-diff.js
+5
-2
web_src/js/features/repo-diff.js
···
57
57
$form.addClass('is-loading');
58
58
const formData = new FormData($form[0]);
59
59
60
-
// if the form is submitted by a button, append the button's name and value to the form data
61
-
const submitter = submitEventSubmitter(e.originalEvent);
60
+
// If the form is submitted by a button, append the button's name and value to the form data.
61
+
// originalEvent can be undefined, such as an event that's caused by Ctrl+Enter, in that case
62
+
// sent the event itself.
63
+
const submitter = submitEventSubmitter(e.originalEvent ?? e);
62
64
const isSubmittedByButton = (submitter?.nodeName === 'BUTTON') || (submitter?.nodeName === 'INPUT' && submitter.type === 'submit');
63
65
if (isSubmittedByButton && submitter.name) {
64
66
formData.append(submitter.name, submitter.value);
···
76
78
$newConversationHolder.find('.dropdown').dropdown();
77
79
initCompReactionSelector($newConversationHolder);
78
80
} catch { // here the caught error might be a jQuery AJAX error (thrown by await $.post), which is not good to use for error message handling
81
+
console.error('error when submitting conversation', e);
79
82
showErrorToast(i18n.network_error);
80
83
} finally {
81
84
$form.removeClass('is-loading');