loading up the forgejo repo on tangled to test page performance
Remove unnecessary variable assignments (#17695)
* Remove unnecessary variable assignments
As title
* enable ineffassign
Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
+59
-72
+1
.golangci.yml
+1
.golangci.yml
-1
cmd/hook.go
-1
cmd/hook.go
-1
contrib/environment-to-ini/environment-to-ini.go
-1
contrib/environment-to-ini/environment-to-ini.go
+2
-2
integrations/api_comment_test.go
+2
-2
integrations/api_comment_test.go
···
119
119
session := loginUser(t, repoOwner.Name)
120
120
token := getTokenForLoggedInUser(t, session)
121
121
req := NewRequestf(t, "GET", "/api/v1/repos/%s/%s/issues/comments/%d", repoOwner.Name, repo.Name, comment.ID)
122
-
resp := session.MakeRequest(t, req, http.StatusOK)
122
+
session.MakeRequest(t, req, http.StatusOK)
123
123
req = NewRequestf(t, "GET", "/api/v1/repos/%s/%s/issues/comments/%d?token=%s", repoOwner.Name, repo.Name, comment.ID, token)
124
-
resp = session.MakeRequest(t, req, http.StatusOK)
124
+
resp := session.MakeRequest(t, req, http.StatusOK)
125
125
126
126
var apiComment api.Comment
127
127
DecodeJSON(t, resp, &apiComment)
+2
-2
integrations/api_issue_label_test.go
+2
-2
integrations/api_issue_label_test.go
···
83
83
84
84
//DeleteLabel
85
85
req = NewRequest(t, "DELETE", singleURLStr)
86
-
resp = session.MakeRequest(t, req, http.StatusNoContent)
86
+
session.MakeRequest(t, req, http.StatusNoContent)
87
87
88
88
}
89
89
···
203
203
204
204
//DeleteLabel
205
205
req = NewRequest(t, "DELETE", singleURLStr)
206
-
resp = session.MakeRequest(t, req, http.StatusNoContent)
206
+
session.MakeRequest(t, req, http.StatusNoContent)
207
207
208
208
}
+1
-1
integrations/api_issue_milestone_test.go
+1
-1
integrations/api_issue_milestone_test.go
···
74
74
assert.Equal(t, int64(2), apiMilestones[0].ID)
75
75
76
76
req = NewRequest(t, "DELETE", fmt.Sprintf("/api/v1/repos/%s/%s/milestones/%d?token=%s", owner.Name, repo.Name, apiMilestone.ID, token))
77
-
resp = session.MakeRequest(t, req, http.StatusNoContent)
77
+
session.MakeRequest(t, req, http.StatusNoContent)
78
78
}
+8
-8
integrations/api_issue_reaction_test.go
+8
-8
integrations/api_issue_reaction_test.go
···
36
36
req := NewRequestWithJSON(t, "POST", urlStr, &api.EditReactionOption{
37
37
Reaction: "wrong",
38
38
})
39
-
resp := session.MakeRequest(t, req, http.StatusForbidden)
39
+
session.MakeRequest(t, req, http.StatusForbidden)
40
40
41
41
//Delete not allowed reaction
42
42
req = NewRequestWithJSON(t, "DELETE", urlStr, &api.EditReactionOption{
43
43
Reaction: "zzz",
44
44
})
45
-
resp = session.MakeRequest(t, req, http.StatusOK)
45
+
session.MakeRequest(t, req, http.StatusOK)
46
46
47
47
//Add allowed reaction
48
48
req = NewRequestWithJSON(t, "POST", urlStr, &api.EditReactionOption{
49
49
Reaction: "rocket",
50
50
})
51
-
resp = session.MakeRequest(t, req, http.StatusCreated)
51
+
resp := session.MakeRequest(t, req, http.StatusCreated)
52
52
var apiNewReaction api.Reaction
53
53
DecodeJSON(t, resp, &apiNewReaction)
54
54
55
55
//Add existing reaction
56
-
resp = session.MakeRequest(t, req, http.StatusForbidden)
56
+
session.MakeRequest(t, req, http.StatusForbidden)
57
57
58
58
//Get end result of reaction list of issue #1
59
59
req = NewRequestf(t, "GET", urlStr)
···
96
96
req := NewRequestWithJSON(t, "POST", urlStr, &api.EditReactionOption{
97
97
Reaction: "wrong",
98
98
})
99
-
resp := session.MakeRequest(t, req, http.StatusForbidden)
99
+
session.MakeRequest(t, req, http.StatusForbidden)
100
100
101
101
//Delete none existing reaction
102
102
req = NewRequestWithJSON(t, "DELETE", urlStr, &api.EditReactionOption{
103
103
Reaction: "eyes",
104
104
})
105
-
resp = session.MakeRequest(t, req, http.StatusOK)
105
+
session.MakeRequest(t, req, http.StatusOK)
106
106
107
107
//Add allowed reaction
108
108
req = NewRequestWithJSON(t, "POST", urlStr, &api.EditReactionOption{
109
109
Reaction: "+1",
110
110
})
111
-
resp = session.MakeRequest(t, req, http.StatusCreated)
111
+
resp := session.MakeRequest(t, req, http.StatusCreated)
112
112
var apiNewReaction api.Reaction
113
113
DecodeJSON(t, resp, &apiNewReaction)
114
114
115
115
//Add existing reaction
116
-
resp = session.MakeRequest(t, req, http.StatusForbidden)
116
+
session.MakeRequest(t, req, http.StatusForbidden)
117
117
118
118
//Get end result of reaction list of issue #1
119
119
req = NewRequestf(t, "GET", urlStr)
+3
-3
integrations/api_notification_test.go
+3
-3
integrations/api_notification_test.go
···
66
66
// -- GET /notifications/threads/{id} --
67
67
// get forbidden
68
68
req = NewRequest(t, "GET", fmt.Sprintf("/api/v1/notifications/threads/%d?token=%s", 1, token))
69
-
resp = session.MakeRequest(t, req, http.StatusForbidden)
69
+
session.MakeRequest(t, req, http.StatusForbidden)
70
70
71
71
// get own
72
72
req = NewRequest(t, "GET", fmt.Sprintf("/api/v1/notifications/threads/%d?token=%s", thread5.ID, token))
···
100
100
101
101
lastReadAt := "2000-01-01T00%3A50%3A01%2B00%3A00" //946687801 <- only Notification 4 is in this filter ...
102
102
req = NewRequest(t, "PUT", fmt.Sprintf("/api/v1/repos/%s/%s/notifications?last_read_at=%s&token=%s", user2.Name, repo1.Name, lastReadAt, token))
103
-
resp = session.MakeRequest(t, req, http.StatusResetContent)
103
+
session.MakeRequest(t, req, http.StatusResetContent)
104
104
105
105
req = NewRequest(t, "GET", fmt.Sprintf("/api/v1/notifications?status-types=unread&token=%s", token))
106
106
resp = session.MakeRequest(t, req, http.StatusOK)
···
109
109
110
110
// -- PATCH /notifications/threads/{id} --
111
111
req = NewRequest(t, "PATCH", fmt.Sprintf("/api/v1/notifications/threads/%d?token=%s", thread5.ID, token))
112
-
resp = session.MakeRequest(t, req, http.StatusResetContent)
112
+
session.MakeRequest(t, req, http.StatusResetContent)
113
113
114
114
assert.Equal(t, models.NotificationStatusUnread, thread5.Status)
115
115
thread5 = unittest.AssertExistsAndLoadBean(t, &models.Notification{ID: 5}).(*models.Notification)
+1
-1
integrations/api_pull_review_test.go
+1
-1
integrations/api_pull_review_test.go
···
140
140
assert.EqualValues(t, "COMMENT", review.State)
141
141
assert.EqualValues(t, 0, review.CodeCommentsCount)
142
142
req = NewRequestf(t, http.MethodDelete, "/api/v1/repos/%s/%s/pulls/%d/reviews/%d?token=%s", repo.OwnerName, repo.Name, pullIssue.Index, review.ID, token)
143
-
resp = session.MakeRequest(t, req, http.StatusNoContent)
143
+
session.MakeRequest(t, req, http.StatusNoContent)
144
144
145
145
// test CreatePullReview Comment without body but with comments
146
146
req = NewRequestWithJSON(t, http.MethodPost, fmt.Sprintf("/api/v1/repos/%s/%s/pulls/%d/reviews?token=%s", repo.OwnerName, repo.Name, pullIssue.Index, token), &api.CreatePullReviewOptions{
+3
-4
integrations/api_repo_edit_test.go
+3
-4
integrations/api_repo_edit_test.go
···
145
145
// Get user2's token
146
146
session := loginUser(t, user2.Name)
147
147
token2 := getTokenForLoggedInUser(t, session)
148
-
session = emptyTestSession(t)
149
148
// Get user4's token
150
149
session = loginUser(t, user4.Name)
151
150
token4 := getTokenForLoggedInUser(t, session)
···
223
222
// Do some tests with invalid URL for external tracker and wiki
224
223
repoEditOption.ExternalTracker.ExternalTrackerURL = "htp://www.somewebsite.com"
225
224
req = NewRequestWithJSON(t, "PATCH", url, &repoEditOption)
226
-
resp = session.MakeRequest(t, req, http.StatusUnprocessableEntity)
225
+
session.MakeRequest(t, req, http.StatusUnprocessableEntity)
227
226
repoEditOption.ExternalTracker.ExternalTrackerURL = "http://www.somewebsite.com"
228
227
repoEditOption.ExternalTracker.ExternalTrackerFormat = "http://www.somewebsite.com/{user/{repo}?issue={index}"
229
228
req = NewRequestWithJSON(t, "PATCH", url, &repoEditOption)
230
-
resp = session.MakeRequest(t, req, http.StatusUnprocessableEntity)
229
+
session.MakeRequest(t, req, http.StatusUnprocessableEntity)
231
230
repoEditOption.ExternalTracker.ExternalTrackerFormat = "http://www.somewebsite.com/{user}/{repo}?issue={index}"
232
231
repoEditOption.ExternalWiki.ExternalWikiURL = "htp://www.somewebsite.com"
233
232
req = NewRequestWithJSON(t, "PATCH", url, &repoEditOption)
234
-
resp = session.MakeRequest(t, req, http.StatusUnprocessableEntity)
233
+
session.MakeRequest(t, req, http.StatusUnprocessableEntity)
235
234
236
235
//Test small repo change through API with issue and wiki option not set; They shall not be touched.
237
236
*repoEditOption.Description = "small change"
-1
integrations/api_repo_file_create_test.go
-1
integrations/api_repo_file_create_test.go
+1
-2
integrations/api_repo_file_delete_test.go
+1
-2
integrations/api_repo_file_delete_test.go
···
49
49
// Get user2's token
50
50
session := loginUser(t, user2.Name)
51
51
token2 := getTokenForLoggedInUser(t, session)
52
-
session = emptyTestSession(t)
53
52
// Get user4's token
54
53
session = loginUser(t, user4.Name)
55
54
token4 := getTokenForLoggedInUser(t, session)
···
111
110
deleteFileOptions.SHA = "badsha"
112
111
url = fmt.Sprintf("/api/v1/repos/%s/%s/contents/%s?token=%s", user2.Name, repo1.Name, treePath, token2)
113
112
req = NewRequestWithJSON(t, "DELETE", url, &deleteFileOptions)
114
-
resp = session.MakeRequest(t, req, http.StatusBadRequest)
113
+
session.MakeRequest(t, req, http.StatusBadRequest)
115
114
116
115
// Test creating a file in repo16 by user4 who does not have write access
117
116
fileID++
-1
integrations/api_repo_file_update_test.go
-1
integrations/api_repo_file_update_test.go
+1
-2
integrations/api_repo_get_contents_list_test.go
+1
-2
integrations/api_repo_get_contents_list_test.go
···
64
64
// Get user2's token
65
65
session := loginUser(t, user2.Name)
66
66
token2 := getTokenForLoggedInUser(t, session)
67
-
session = emptyTestSession(t)
68
67
// Get user4's token
69
68
session = loginUser(t, user4.Name)
70
69
token4 := getTokenForLoggedInUser(t, session)
···
139
138
// Test file contents a file with a bad ref
140
139
ref = "badref"
141
140
req = NewRequestf(t, "GET", "/api/v1/repos/%s/%s/contents/%s?ref=%s", user2.Name, repo1.Name, treePath, ref)
142
-
resp = session.MakeRequest(t, req, http.StatusNotFound)
141
+
session.MakeRequest(t, req, http.StatusNotFound)
143
142
144
143
// Test accessing private ref with user token that does not have access - should fail
145
144
req = NewRequestf(t, "GET", "/api/v1/repos/%s/%s/contents/%s?token=%s", user2.Name, repo16.Name, treePath, token4)
+1
-2
integrations/api_repo_get_contents_test.go
+1
-2
integrations/api_repo_get_contents_test.go
···
65
65
// Get user2's token
66
66
session := loginUser(t, user2.Name)
67
67
token2 := getTokenForLoggedInUser(t, session)
68
-
session = emptyTestSession(t)
69
68
// Get user4's token
70
69
session = loginUser(t, user4.Name)
71
70
token4 := getTokenForLoggedInUser(t, session)
···
141
140
// Test file contents a file with a bad ref
142
141
ref = "badref"
143
142
req = NewRequestf(t, "GET", "/api/v1/repos/%s/%s/contents/%s?ref=%s", user2.Name, repo1.Name, treePath, ref)
144
-
resp = session.MakeRequest(t, req, http.StatusNotFound)
143
+
session.MakeRequest(t, req, http.StatusNotFound)
145
144
146
145
// Test accessing private ref with user token that does not have access - should fail
147
146
req = NewRequestf(t, "GET", "/api/v1/repos/%s/%s/contents/%s?token=%s", user2.Name, repo16.Name, treePath, token4)
+6
-6
integrations/api_repo_teams_test.go
+6
-6
integrations/api_repo_teams_test.go
···
54
54
55
55
url = fmt.Sprintf("/api/v1/repos/%s/teams/%s?token=%s", publicOrgRepo.FullName(), "NonExistingTeam", token)
56
56
req = NewRequest(t, "GET", url)
57
-
res = session.MakeRequest(t, req, http.StatusNotFound)
57
+
session.MakeRequest(t, req, http.StatusNotFound)
58
58
59
59
// AddTeam with user4
60
60
url = fmt.Sprintf("/api/v1/repos/%s/teams/%s?token=%s", publicOrgRepo.FullName(), "team1", token)
61
61
req = NewRequest(t, "PUT", url)
62
-
res = session.MakeRequest(t, req, http.StatusForbidden)
62
+
session.MakeRequest(t, req, http.StatusForbidden)
63
63
64
64
// AddTeam with user2
65
65
user = unittest.AssertExistsAndLoadBean(t, &models.User{ID: 2}).(*models.User)
···
67
67
token = getTokenForLoggedInUser(t, session)
68
68
url = fmt.Sprintf("/api/v1/repos/%s/teams/%s?token=%s", publicOrgRepo.FullName(), "team1", token)
69
69
req = NewRequest(t, "PUT", url)
70
-
res = session.MakeRequest(t, req, http.StatusNoContent)
71
-
res = session.MakeRequest(t, req, http.StatusUnprocessableEntity) // test duplicate request
70
+
session.MakeRequest(t, req, http.StatusNoContent)
71
+
session.MakeRequest(t, req, http.StatusUnprocessableEntity) // test duplicate request
72
72
73
73
// DeleteTeam
74
74
url = fmt.Sprintf("/api/v1/repos/%s/teams/%s?token=%s", publicOrgRepo.FullName(), "team1", token)
75
75
req = NewRequest(t, "DELETE", url)
76
-
res = session.MakeRequest(t, req, http.StatusNoContent)
77
-
res = session.MakeRequest(t, req, http.StatusUnprocessableEntity) // test duplicate request
76
+
session.MakeRequest(t, req, http.StatusNoContent)
77
+
session.MakeRequest(t, req, http.StatusUnprocessableEntity) // test duplicate request
78
78
}
+10
-10
integrations/api_repo_topic_test.go
+10
-10
integrations/api_repo_topic_test.go
···
75
75
76
76
// Test delete a topic
77
77
req = NewRequestf(t, "DELETE", "/api/v1/repos/%s/%s/topics/%s?token=%s", user2.Name, repo2.Name, "Topicname1", token2)
78
-
res = session.MakeRequest(t, req, http.StatusNoContent)
78
+
session.MakeRequest(t, req, http.StatusNoContent)
79
79
80
80
// Test add an existing topic
81
81
req = NewRequestf(t, "PUT", "/api/v1/repos/%s/%s/topics/%s?token=%s", user2.Name, repo2.Name, "Golang", token2)
82
-
res = session.MakeRequest(t, req, http.StatusNoContent)
82
+
session.MakeRequest(t, req, http.StatusNoContent)
83
83
84
84
// Test add a topic
85
85
req = NewRequestf(t, "PUT", "/api/v1/repos/%s/%s/topics/%s?token=%s", user2.Name, repo2.Name, "topicName3", token2)
86
-
res = session.MakeRequest(t, req, http.StatusNoContent)
86
+
session.MakeRequest(t, req, http.StatusNoContent)
87
87
88
88
// Test read topics using token
89
89
req = NewRequest(t, "GET", url)
···
96
96
req = NewRequestWithJSON(t, "PUT", url, &api.RepoTopicOptions{
97
97
Topics: newTopics,
98
98
})
99
-
res = session.MakeRequest(t, req, http.StatusNoContent)
99
+
session.MakeRequest(t, req, http.StatusNoContent)
100
100
req = NewRequest(t, "GET", url)
101
101
res = session.MakeRequest(t, req, http.StatusOK)
102
102
DecodeJSON(t, res, &topics)
···
107
107
req = NewRequestWithJSON(t, "PUT", url, &api.RepoTopicOptions{
108
108
Topics: newTopics,
109
109
})
110
-
res = session.MakeRequest(t, req, http.StatusUnprocessableEntity)
110
+
session.MakeRequest(t, req, http.StatusUnprocessableEntity)
111
111
req = NewRequest(t, "GET", url)
112
112
res = session.MakeRequest(t, req, http.StatusOK)
113
113
DecodeJSON(t, res, &topics)
···
118
118
req = NewRequestWithJSON(t, "PUT", url, &api.RepoTopicOptions{
119
119
Topics: newTopics,
120
120
})
121
-
res = session.MakeRequest(t, req, http.StatusNoContent)
121
+
session.MakeRequest(t, req, http.StatusNoContent)
122
122
req = NewRequest(t, "GET", url)
123
123
res = session.MakeRequest(t, req, http.StatusOK)
124
124
DecodeJSON(t, res, &topics)
···
129
129
req = NewRequestWithJSON(t, "PUT", url, &api.RepoTopicOptions{
130
130
Topics: newTopics,
131
131
})
132
-
res = session.MakeRequest(t, req, http.StatusUnprocessableEntity)
132
+
session.MakeRequest(t, req, http.StatusUnprocessableEntity)
133
133
134
134
// Test add a topic when there is already maximum
135
135
req = NewRequestf(t, "PUT", "/api/v1/repos/%s/%s/topics/%s?token=%s", user2.Name, repo2.Name, "t26", token2)
136
-
res = session.MakeRequest(t, req, http.StatusUnprocessableEntity)
136
+
session.MakeRequest(t, req, http.StatusUnprocessableEntity)
137
137
138
138
// Test delete a topic that repo doesn't have
139
139
req = NewRequestf(t, "DELETE", "/api/v1/repos/%s/%s/topics/%s?token=%s", user2.Name, repo2.Name, "Topicname1", token2)
140
-
res = session.MakeRequest(t, req, http.StatusNotFound)
140
+
session.MakeRequest(t, req, http.StatusNotFound)
141
141
142
142
// Get user4's token
143
143
session = loginUser(t, user4.Name)
···
153
153
154
154
// Test add a topic to repo with write access (requires repo admin access)
155
155
req = NewRequestf(t, "PUT", "/api/v1/repos/%s/%s/topics/%s?token=%s", user3.Name, repo3.Name, "topicName", token4)
156
-
res = session.MakeRequest(t, req, http.StatusForbidden)
156
+
session.MakeRequest(t, req, http.StatusForbidden)
157
157
158
158
}
+1
-1
integrations/api_team_test.go
+1
-1
integrations/api_team_test.go
···
160
160
csrf = GetCSRF(t, session, "/"+org.Name)
161
161
req = NewRequestf(t, "GET", "/api/v1/orgs/%s/teams/search?q=%s", org.Name, "team")
162
162
req.Header.Add("X-Csrf-Token", csrf)
163
-
resp = session.MakeRequest(t, req, http.StatusForbidden)
163
+
session.MakeRequest(t, req, http.StatusForbidden)
164
164
165
165
}
+2
-2
integrations/api_user_orgs_test.go
+2
-2
integrations/api_user_orgs_test.go
···
72
72
73
73
session := emptyTestSession(t)
74
74
req := NewRequest(t, "GET", "/api/v1/user/orgs")
75
-
resp := session.MakeRequest(t, req, http.StatusUnauthorized)
75
+
session.MakeRequest(t, req, http.StatusUnauthorized)
76
76
77
77
normalUsername := "user2"
78
78
session = loginUser(t, normalUsername)
79
79
token := getTokenForLoggedInUser(t, session)
80
80
req = NewRequest(t, "GET", "/api/v1/user/orgs?token="+token)
81
-
resp = session.MakeRequest(t, req, http.StatusOK)
81
+
resp := session.MakeRequest(t, req, http.StatusOK)
82
82
var orgs []*api.Organization
83
83
DecodeJSON(t, resp, &orgs)
84
84
user3 := unittest.AssertExistsAndLoadBean(t, &models.User{Name: "user3"}).(*models.User)
+1
-1
integrations/eventsource_test.go
+1
-1
integrations/eventsource_test.go
···
69
69
70
70
lastReadAt := "2000-01-01T00%3A50%3A01%2B00%3A00" //946687801 <- only Notification 4 is in this filter ...
71
71
req = NewRequest(t, "PUT", fmt.Sprintf("/api/v1/repos/%s/%s/notifications?last_read_at=%s&token=%s", user2.Name, repo1.Name, lastReadAt, token))
72
-
resp = session.MakeRequest(t, req, http.StatusResetContent)
72
+
session.MakeRequest(t, req, http.StatusResetContent)
73
73
74
74
req = NewRequest(t, "GET", fmt.Sprintf("/api/v1/notifications?token=%s&status-types=unread", token))
75
75
resp = session.MakeRequest(t, req, http.StatusOK)
+1
-1
integrations/issue_test.go
+1
-1
integrations/issue_test.go
···
287
287
unittest.AssertExistsAndLoadBean(t, comment)
288
288
289
289
// Ref from a different repository
290
-
issueRefURL, issueRef = testIssueWithBean(t, "user12", 10, "TitleXRef", fmt.Sprintf("Description ref user2/repo1#%d", issueBase.Index))
290
+
_, issueRef = testIssueWithBean(t, "user12", 10, "TitleXRef", fmt.Sprintf("Description ref user2/repo1#%d", issueBase.Index))
291
291
unittest.AssertExistsAndLoadBean(t, &models.Comment{
292
292
IssueID: issueBase.ID,
293
293
RefRepoID: 10,
+2
-2
integrations/pull_status_test.go
+2
-2
integrations/pull_status_test.go
···
33
33
34
34
req = NewRequest(t, "GET", "/user1/repo1/pulls")
35
35
resp := session.MakeRequest(t, req, http.StatusOK)
36
-
doc := NewHTMLParser(t, resp.Body)
36
+
NewHTMLParser(t, resp.Body)
37
37
38
38
// Request repository commits page
39
39
req = NewRequest(t, "GET", "/user1/repo1/pulls/1/commits")
40
40
resp = session.MakeRequest(t, req, http.StatusOK)
41
-
doc = NewHTMLParser(t, resp.Body)
41
+
doc := NewHTMLParser(t, resp.Body)
42
42
43
43
// Get first commit URL
44
44
commitURL, exists := doc.doc.Find("#commits-table tbody tr td.sha a").Last().Attr("href")
+2
-2
integrations/repo_fork_test.go
+2
-2
integrations/repo_fork_test.go
···
21
21
22
22
// Step0: check the existence of the to-fork repo
23
23
req := NewRequestf(t, "GET", "/%s/%s", forkOwnerName, forkRepoName)
24
-
resp := session.MakeRequest(t, req, http.StatusNotFound)
24
+
session.MakeRequest(t, req, http.StatusNotFound)
25
25
26
26
// Step1: go to the main page of repo
27
27
req = NewRequestf(t, "GET", "/%s/%s", ownerName, repoName)
28
-
resp = session.MakeRequest(t, req, http.StatusOK)
28
+
resp := session.MakeRequest(t, req, http.StatusOK)
29
29
30
30
// Step2: click the fork button
31
31
htmlDoc := NewHTMLParser(t, resp.Body)
+2
-2
integrations/repo_generate_test.go
+2
-2
integrations/repo_generate_test.go
···
21
21
22
22
// Step0: check the existence of the generated repo
23
23
req := NewRequestf(t, "GET", "/%s/%s", generateOwnerName, generateRepoName)
24
-
resp := session.MakeRequest(t, req, http.StatusNotFound)
24
+
session.MakeRequest(t, req, http.StatusNotFound)
25
25
26
26
// Step1: go to the main page of template repo
27
27
req = NewRequestf(t, "GET", "/%s/%s", templateOwnerName, templateRepoName)
28
-
resp = session.MakeRequest(t, req, http.StatusOK)
28
+
resp := session.MakeRequest(t, req, http.StatusOK)
29
29
30
30
// Step2: click the "Use this template" button
31
31
htmlDoc := NewHTMLParser(t, resp.Body)
+1
-1
models/issue_assignees_test.go
+1
-1
models/issue_assignees_test.go
···
72
72
assert.NoError(t, err)
73
73
assert.Equal(t, []int64{}, IDs)
74
74
75
-
IDs, err = MakeIDsFromAPIAssigneesToAdd("", []string{"none_existing_user"})
75
+
_, err = MakeIDsFromAPIAssigneesToAdd("", []string{"none_existing_user"})
76
76
assert.Error(t, err)
77
77
78
78
IDs, err = MakeIDsFromAPIAssigneesToAdd("user1", []string{"user1"})
+1
-2
models/topic_test.go
+1
-2
models/topic_test.go
···
16
16
func TestAddTopic(t *testing.T) {
17
17
totalNrOfTopics := 6
18
18
repo1NrOfTopics := 3
19
-
repo2NrOfTopics := 2
20
19
21
20
assert.NoError(t, unittest.PrepareTestDatabase())
22
21
···
38
37
assert.Len(t, topics, repo1NrOfTopics)
39
38
40
39
assert.NoError(t, SaveTopics(2, "golang"))
41
-
repo2NrOfTopics = 1
40
+
repo2NrOfTopics := 1
42
41
topics, _, err = FindTopics(&FindTopicOptions{})
43
42
assert.NoError(t, err)
44
43
assert.Len(t, topics, totalNrOfTopics)
+2
-2
models/user_email_test.go
+2
-2
models/user_email_test.go
···
111
111
112
112
// Must find only primary addresses (i.e. from the `user` table)
113
113
opts = &SearchEmailOptions{IsPrimary: util.OptionalBoolTrue}
114
-
emails, count, err = SearchEmails(opts)
114
+
emails, _, err = SearchEmails(opts)
115
115
assert.NoError(t, err)
116
116
assert.True(t, contains(func(s *SearchEmailResult) bool { return s.IsPrimary }))
117
117
assert.False(t, contains(func(s *SearchEmailResult) bool { return !s.IsPrimary }))
118
118
119
119
// Must find only inactive addresses (i.e. not validated)
120
120
opts = &SearchEmailOptions{IsActivated: util.OptionalBoolFalse}
121
-
emails, count, err = SearchEmails(opts)
121
+
emails, _, err = SearchEmails(opts)
122
122
assert.NoError(t, err)
123
123
assert.True(t, contains(func(s *SearchEmailResult) bool { return !s.IsActivated }))
124
124
assert.False(t, contains(func(s *SearchEmailResult) bool { return s.IsActivated }))
+1
-2
modules/gitgraph/graph_test.go
+1
-2
modules/gitgraph/graph_test.go
···
55
55
parser.Reset()
56
56
tgBytes := []byte(testglyphs)
57
57
tg := tgBytes
58
-
idx := bytes.Index(tg, []byte("\n"))
59
58
for i := 0; i < b.N; i++ {
60
59
parser.Reset()
61
60
tg = tgBytes
62
-
idx = bytes.Index(tg, []byte("\n"))
61
+
idx := bytes.Index(tg, []byte("\n"))
63
62
for idx > 0 {
64
63
parser.ParseGlyphs(tg[:idx])
65
64
tg = tg[idx+1:]
+1
-2
modules/nosql/manager_leveldb.go
+1
-2
modules/nosql/manager_leveldb.go
···
48
48
49
49
return db.db, nil
50
50
}
51
-
dataDir := connection
52
51
uri := ToLevelDBURI(connection)
53
52
db = &levelDBHolder{
54
53
name: []string{connection, uri.String()},
55
54
}
56
55
57
-
dataDir = path.Join(uri.Host, uri.Path)
56
+
dataDir := path.Join(uri.Host, uri.Path)
58
57
opts := &opt.Options{}
59
58
for k, v := range uri.Query() {
60
59
switch replacer.Replace(strings.ToLower(k)) {
-2
modules/web/middleware/binding.go
-2
modules/web/middleware/binding.go