loading up the forgejo repo on tangled to test page performance
Added `alt`'s to `<img>`
authored by
Antonin Del Fabbro
and committed by
Robert Wolff
c9b72d5b
b1590068
+24
-24
+1
-1
modules/templates/util_avatar.go
+1
-1
modules/templates/util_avatar.go
···
34
34
name = "avatar"
35
35
}
36
36
37
-
return template.HTML(`<img loading="lazy" class="` + class + `" src="` + src + `" title="` + html.EscapeString(name) + `" width="` + sizeStr + `" height="` + sizeStr + `"/>`)
37
+
return template.HTML(`<img loading="lazy" alt="" class="` + class + `" src="` + src + `" title="` + html.EscapeString(name) + `" width="` + sizeStr + `" height="` + sizeStr + `"/>`)
38
38
}
39
39
40
40
// Avatar renders user avatars. args: user, size (int), class (string)
+1
-1
routers/api/v1/misc/markup_test.go
+1
-1
routers/api/v1/misc/markup_test.go
···
112
112
<h2 id="user-content-quick-links">Quick Links</h2>
113
113
<p>Here are some links to the most important topics. You can find the full list of pages at the sidebar.</p>
114
114
<p><a href="` + FullURL + `wiki/Configuration" rel="nofollow">Configuration</a>
115
-
<a href="` + FullURL + `wiki/raw/images/icon-bug.png" rel="nofollow"><img src="` + FullURL + `wiki/raw/images/icon-bug.png" title="icon-bug.png" alt="images/icon-bug.png"/></a></p>
115
+
<a href="` + FullURL + `wiki/raw/images/icon-bug.png" rel="nofollow"><img src="` + FullURL + `wiki/raw/images/icon-bug.png" title="icon-bug.png" alt=""/></a></p>
116
116
`,
117
117
}
118
118
+1
-1
templates/install.tmpl
+1
-1
templates/install.tmpl
···
363
363
</div>
364
364
</div>
365
365
</div>
366
-
<img class="tw-hidden" src="{{AssetUrlPrefix}}/img/forgejo-loading.svg" width="256" height="256">
366
+
<img class="tw-hidden" src="{{AssetUrlPrefix}}/img/forgejo-loading.svg" alt="{{ctx.Locale.Tr "loading"}}" width="256" height="256">
367
367
{{template "base/footer" .}}
+6
-6
templates/repo/diff/image_diff.tmpl
+6
-6
templates/repo/diff/image_diff.tmpl
···
22
22
{{if .blobBase}}
23
23
<span class="side">
24
24
<p class="side-header">{{ctx.Locale.Tr "repo.diff.file_before"}}</p>
25
-
<span class="before-container"><img class="image-before"></span>
25
+
<span class="before-container"><img class="image-before" alt=""></span>
26
26
<p>
27
27
<span class="bounds-info-before">
28
28
{{ctx.Locale.Tr "repo.diff.file_image_width"}}: <span class="text bounds-info-width"></span>
···
37
37
{{if .blobHead}}
38
38
<span class="side">
39
39
<p class="side-header">{{ctx.Locale.Tr "repo.diff.file_after"}}</p>
40
-
<span class="after-container"><img class="image-after"></span>
40
+
<span class="after-container"><img class="image-after" alt=""></span>
41
41
<p>
42
42
<span class="bounds-info-after">
43
43
{{ctx.Locale.Tr "repo.diff.file_image_width"}}: <span class="text bounds-info-width"></span>
···
55
55
<div class="ui bottom attached tab image-diff-container" data-tab="diff-swipe-{{.file.Index}}">
56
56
<div class="diff-swipe">
57
57
<div class="swipe-frame">
58
-
<span class="before-container"><img class="image-before"></span>
58
+
<span class="before-container"><img class="image-before" alt="{{ctx.Locale.Tr "repo.diff.file_before"}}"></span>
59
59
<span class="swipe-container">
60
-
<span class="after-container"><img class="image-after"></span>
60
+
<span class="after-container"><img class="image-after" alt="{{ctx.Locale.Tr "repo.diff.file_after"}}"></span>
61
61
</span>
62
62
<span class="swipe-bar">
63
63
<span class="handle top-handle"></span>
···
70
70
<div class="diff-overlay">
71
71
<input type="range" min="0" max="100" value="50">
72
72
<div class="overlay-frame">
73
-
<span class="before-container"><img class="image-before"></span>
74
-
<span class="after-container"><img class="image-after"></span>
73
+
<span class="before-container"><img class="image-before" alt="{{ctx.Locale.Tr "repo.diff.file_before"}}"></span>
74
+
<span class="after-container"><img class="image-after" alt="{{ctx.Locale.Tr "repo.diff.file_after"}}"></span>
75
75
</div>
76
76
</div>
77
77
</div>
+1
-1
templates/repo/issue/view_content/comments.tmpl
+1
-1
templates/repo/issue/view_content/comments.tmpl
···
602
602
<div class="timeline-item-group">
603
603
<div class="timeline-item event" id="{{.HashTag}}">
604
604
<a class="timeline-avatar"{{if gt .Poster.ID 0}} href="{{.Poster.HomeLink}}"{{end}}>
605
-
<img src="{{.Poster.AvatarLink $.Context}}" width="40" height="40">
605
+
<img src="{{.Poster.AvatarLink $.Context}}" alt="" width="40" height="40">
606
606
</a>
607
607
<span class="badge grey">{{svg "octicon-x" 16}}</span>
608
608
<span class="text grey muted-links">
+1
-1
templates/repo/migrate/migrating.tmpl
+1
-1
templates/repo/migrate/migrating.tmpl
···
9
9
<div class="ui stackable middle very relaxed page grid">
10
10
<div id="repo_migrating" class="sixteen wide center aligned centered column" data-migrating-task-id="{{.MigrateTask.ID}}">
11
11
<div>
12
-
<img src="{{AssetUrlPrefix}}/img/forgejo-loading.svg" width="256" height="256">
12
+
<img src="{{AssetUrlPrefix}}/img/forgejo-loading.svg" alt="{{ctx.Locale.Tr "loading"}}" width="256" height="256">
13
13
</div>
14
14
</div>
15
15
<div id="repo_migrating_failed_image" class="sixteen wide center aligned centered column tw-hidden">
+1
-1
templates/repo/settings/lfs_file.tmpl
+1
-1
templates/repo/settings/lfs_file.tmpl
···
21
21
{{else if not .IsTextFile}}
22
22
<div class="view-raw">
23
23
{{if .IsImageFile}}
24
-
<img src="{{$.RawFileLink}}">
24
+
<img src="{{$.RawFileLink}}" alt="">
25
25
{{else if .IsVideoFile}}
26
26
<video controls src="{{$.RawFileLink}}">
27
27
<strong>{{ctx.Locale.Tr "repo.video_not_supported_in_browser"}}</strong>
+1
-1
templates/user/auth/captcha.tmpl
+1
-1
templates/user/auth/captcha.tmpl
···
1
1
{{if .EnableCaptcha}}{{if eq .CaptchaType "image"}}
2
2
<div class="inline field tw-text-center">
3
3
<input type="hidden" name="img-captcha-id" value="{{.Captcha}}">
4
-
<img style="transform: scaleX(-1)" onclick="this.src=`{{AppSubUrl}}/captcha/{{.Captcha}}.png?reload=${Date.now()}`" class="captcha-img" src="{{AppSubUrl}}/captcha/{{.Captcha}}.png">
4
+
<img style="transform: scaleX(-1)" onclick="this.src=`{{AppSubUrl}}/captcha/{{.Captcha}}.png?reload=${Date.now()}`" class="captcha-img" src="{{AppSubUrl}}/captcha/{{.Captcha}}.png" alt="{{ctx.Locale.Tr "captcha"}}">
5
5
</div>
6
6
<div class="required field {{if .Err_Captcha}}error{{end}}">
7
7
<label for="captcha">{{ctx.Locale.Tr "captcha"}}</label>
+1
-1
templates/user/dashboard/feeds.tmpl
+1
-1
templates/user/dashboard/feeds.tmpl
···
91
91
{{range $push.Commits}}
92
92
{{$commitLink := printf "%s/commit/%s" $repoLink .Sha1}}
93
93
<div class="flex-text-block">
94
-
<img class="ui avatar" src="{{$push.AvatarLink $.Context .AuthorEmail}}" title="{{.AuthorName}}" width="16" height="16">
94
+
<img class="ui avatar" src="{{$push.AvatarLink $.Context .AuthorEmail}}" alt="" title="{{.AuthorName}}" width="16" height="16">
95
95
<a class="ui sha label" href="{{$commitLink}}">{{ShortSha .Sha1}}</a>
96
96
<span class="text truncate">
97
97
{{RenderCommitMessage $.Context .Message ($repo.ComposeMetas ctx)}}