loading up the forgejo repo on tangled to test page performance
Fix bug on user setting (#22539)
Fix #22537
Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
authored by
Lunny Xiao
KN4CK3R
and committed by
GitHub
eb793c33
a1fcb1cf
+10
-4
+10
-4
models/user/setting.go
+10
-4
models/user/setting.go
···
10
10
11
11
"code.gitea.io/gitea/models/db"
12
12
"code.gitea.io/gitea/modules/cache"
13
+
setting_module "code.gitea.io/gitea/modules/setting"
13
14
14
15
"xorm.io/builder"
15
16
)
···
154
155
return err
155
156
}
156
157
157
-
_, err := cache.GetString(genSettingCacheKey(userID, key), func() (string, error) {
158
-
return value, upsertUserSettingValue(userID, key, value)
159
-
})
158
+
if err := upsertUserSettingValue(userID, key, value); err != nil {
159
+
return err
160
+
}
161
+
162
+
cc := cache.GetCache()
163
+
if cc != nil {
164
+
return cc.Put(genSettingCacheKey(userID, key), value, setting_module.CacheService.TTLSeconds())
165
+
}
160
166
161
-
return err
167
+
return nil
162
168
}
163
169
164
170
func upsertUserSettingValue(userID int64, key, value string) error {