loading up the forgejo repo on tangled to test page performance
Don't apply the group filter when listing LDAP group membership if it is empty (#23745)
When running listLdapGroupMemberships check if the groupFilter is empty
before using it to list memberships.
Fix #23615
Signed-off-by: Andrew Thornton <art27@cantab.net>
+1
-1
+1
-1
services/auth/source/ldap/source_search.go
+1
-1
services/auth/source/ldap/source_search.go
···
208
208
}
209
209
210
210
var searchFilter string
211
-
if applyGroupFilter {
211
+
if applyGroupFilter && groupFilter != "" {
212
212
searchFilter = fmt.Sprintf("(&(%s)(%s=%s))", groupFilter, source.GroupMemberUID, ldap.EscapeFilter(uid))
213
213
} else {
214
214
searchFilter = fmt.Sprintf("(%s=%s)", source.GroupMemberUID, ldap.EscapeFilter(uid))