+14

bin/tests/bool_simplification.rs

reviewed

··· 1 1 + mod _utils; 2 2 + 3 3 + use macros::generate_tests; 4 4 + 5 5 + generate_tests! { 6 6 + rule: bool_simplification, 7 7 + expressions: [ 8 8 + "!(a == b)", 9 9 + 10 10 + // non-matches 11 11 + "!(a != b)", 12 12 + "a != b", 13 13 + ], 14 14 + }

-7

bin/tests/data/bool_simplification.nix

reviewed

··· 1 1 - let 2 2 - _ = !(a == b); 3 3 - # do not match here 4 4 - _ = !(a != b); 5 5 - _ = a != b; 6 6 - in 7 7 - null

-1

bin/tests/main.rs

reviewed

··· 56 56 unquoted_uri, 57 57 empty_inherit, 58 58 deprecated_to_path, 59 59 - bool_simplification, 60 59 useless_has_attr, 61 60 repeated_keys, 62 61 empty_list_concat

+9

bin/tests/snapshots/bool_simplification__fix_b01828755e286c145f9a8ae65cde7a14eb9e252d7bb6f72fb3d934dff9400353.snap

reviewed

··· 1 1 + --- 2 2 + source: bin/tests/bool_simplification.rs 3 3 + expression: "\"!(a == b)\"" 4 4 + --- 5 5 + --- <temp_file_path> 6 6 + +++ <temp_file_path> [fixed] 7 7 + @@ -1 +1 @@ 8 8 + -!(a == b) 9 9 + +a != b

+5

bin/tests/snapshots/bool_simplification__fix_dba01b31497c8add1ca9c98db9ec7d205af95f5e9c8904c94cc3adc9889f8d40.snap

reviewed

··· 1 1 + --- 2 2 + source: bin/tests/bool_simplification.rs 3 3 + expression: "\"a != b\"" 4 4 + --- 5 5 +

+5

bin/tests/snapshots/bool_simplification__fix_fc74617cbe767e6731b7fbce9bf425fe8a017be2bebd70050bbe01f40a45f066.snap

reviewed

··· 1 1 + --- 2 2 + source: bin/tests/bool_simplification.rs 3 3 + expression: "\"!(a != b)\"" 4 4 + --- 5 5 +

+11

bin/tests/snapshots/bool_simplification__lint_b01828755e286c145f9a8ae65cde7a14eb9e252d7bb6f72fb3d934dff9400353.snap

reviewed

··· 1 1 + --- 2 2 + source: bin/tests/bool_simplification.rs 3 3 + expression: "\"!(a == b)\"" 4 4 + --- 5 5 + [W18] Warning: This boolean expression can be simplified 6 6 + ╭─[<temp_file_path>:1:1] 7 7 + │ 8 8 + 1 │ !(a == b) 9 9 + · ────┬──── 10 10 + · ╰────── Try != instead of !(... == ...) 11 11 + ───╯

+5

bin/tests/snapshots/bool_simplification__lint_dba01b31497c8add1ca9c98db9ec7d205af95f5e9c8904c94cc3adc9889f8d40.snap

reviewed

··· 1 1 + --- 2 2 + source: bin/tests/bool_simplification.rs 3 3 + expression: "\"a != b\"" 4 4 + --- 5 5 +

+5

bin/tests/snapshots/bool_simplification__lint_fc74617cbe767e6731b7fbce9bf425fe8a017be2bebd70050bbe01f40a45f066.snap

reviewed

··· 1 1 + --- 2 2 + source: bin/tests/bool_simplification.rs 3 3 + expression: "\"!(a != b)\"" 4 4 + --- 5 5 +

-14

bin/tests/snapshots/main__bool_simplification_fix.snap

reviewed

··· 1 1 - --- 2 2 - source: bin/tests/main.rs 3 3 - expression: "&stdout" 4 4 - --- 5 5 - --- tests/data/bool_simplification.nix 6 6 - +++ tests/data/bool_simplification.nix [fixed] 7 7 - @@ -1,6 +1,6 @@ 8 8 - let 9 9 - - _ = !(a == b); 10 10 - + _ = a != b; 11 11 - # do not match here 12 12 - _ = !(a != b); 13 13 - _ = a != b; 14 14 - in

-11

bin/tests/snapshots/main__bool_simplification_lint.snap

reviewed

··· 1 1 - --- 2 2 - source: bin/tests/main.rs 3 3 - expression: "&stdout" 4 4 - --- 5 5 - [W18] Warning: This boolean expression can be simplified 6 6 - ╭─[tests/data/bool_simplification.nix:2:7] 7 7 - │ 8 8 - 2 │ _ = !(a == b); 9 9 - · ────┬──── 10 10 - · ╰────── Try != instead of !(... == ...) 11 11 - ───╯