Lints and suggestions for the Nix programming language
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

regenerate snaps

+19 -57
+1 -3
bin/tests/snapshots/main__bool_comparison.snap
··· 1 1 --- 2 2 source: bin/tests/main.rs 3 - expression: "&out" 4 - 3 + expression: "& out" 5 4 --- 6 5 [W01] Warning: Unnecessary comparison with boolean 7 6 ╭─[data/bool_comparison.nix:3:4] ··· 59 58 · ─────┬──── 60 59 · ╰────── Comparing h with boolean literal false 61 60 ────╯ 62 -
+1 -3
bin/tests/snapshots/main__bool_simplification.snap
··· 1 1 --- 2 2 source: bin/tests/main.rs 3 - expression: "&out" 4 - 3 + expression: "& out" 5 4 --- 6 5 [W18] Warning: This boolean expression can be simplified 7 6 ╭─[data/bool_simplification.nix:2:7] ··· 10 9 · ────┬──── 11 10 · ╰────── Try != instead of !(... == ...) 12 11 ───╯ 13 -
+1 -3
bin/tests/snapshots/main__collapsible_let_in.snap
··· 1 1 --- 2 2 source: bin/tests/main.rs 3 - expression: "&out" 4 - 3 + expression: "& out" 5 4 --- 6 5 [W06] Warning: These let-in expressions are collapsible 7 6 ╭─[data/collapsible_let_in.nix:1:1] ··· 14 13 · │ │ 15 14 · ╰───────────────────┴─── This let in expression contains a nested let in expression 16 15 ───╯ 17 -
+1 -3
bin/tests/snapshots/main__deprecated_to_path.snap
··· 1 1 --- 2 2 source: bin/tests/main.rs 3 - expression: "&out" 4 - 3 + expression: "& out" 5 4 --- 6 5 [W17] Warning: Found usage of deprecated builtin toPath 7 6 ╭─[data/deprecated_to_path.nix:2:4] ··· 31 30 · ──────────────┬───────────── 32 31 · ╰─────────────── builtins.toPath is deprecated, see :doc builtins.toPath within the REPL for more 33 32 ───╯ 34 -
+1 -3
bin/tests/snapshots/main__empty_inherit.snap
··· 1 1 --- 2 2 source: bin/tests/main.rs 3 - expression: "&out" 4 - 3 + expression: "& out" 5 4 --- 6 5 [W14] Warning: Found empty inherit statement 7 6 ╭─[data/empty_inherit.nix:2:3] ··· 10 9 · ────┬─── 11 10 · ╰───── Remove this empty inherit statement 12 11 ───╯ 13 -
+1 -3
bin/tests/snapshots/main__empty_let_in.snap
··· 1 1 --- 2 2 source: bin/tests/main.rs 3 - expression: "&out" 4 - 3 + expression: "& out" 5 4 --- 6 5 [W02] Warning: Useless let-in expression 7 6 ╭─[data/empty_let_in.nix:3:5] ··· 19 18 · │ 20 19 · ╰────────────── This let-in expression has no entries 21 20 ────╯ 22 -
+1 -3
bin/tests/snapshots/main__empty_list_concat.snap
··· 1 1 --- 2 2 source: bin/tests/main.rs 3 - expression: "&out" 4 - 3 + expression: "& out" 5 4 --- 6 5 [W23] Warning: Unnecessary concatenation with empty list 7 6 ╭─[data/empty_list_concat.nix:6:4] ··· 38 37 · ────┬─── 39 38 · ╰───── Concatenation with the empty list, [], is a no-op 40 39 ────╯ 41 -
+1 -3
bin/tests/snapshots/main__empty_pattern.snap
··· 1 1 --- 2 2 source: bin/tests/main.rs 3 - expression: "&out" 4 - 3 + expression: "& out" 5 4 --- 6 5 [W10] Warning: Found empty pattern in function argument 7 6 ╭─[data/empty_pattern.nix:3:4] ··· 17 16 · ────────┬─────── 18 17 · ╰───────── This pattern bind is redundant, use inputs instead 19 18 ───╯ 20 -
+1 -3
bin/tests/snapshots/main__eta_reduction.snap
··· 1 1 --- 2 2 source: bin/tests/main.rs 3 - expression: "&out" 4 - 3 + expression: "& out" 5 4 --- 6 5 [W07] Warning: This function expression is eta reducible 7 6 ╭─[data/eta_reduction.nix:11:9] ··· 10 9 · ─────┬───── 11 10 · ╰─────── Found eta-reduction: double 12 11 ────╯ 13 -
+1 -3
bin/tests/snapshots/main__faster_groupby.snap
··· 1 1 --- 2 2 source: bin/tests/main.rs 3 - expression: "&out" 4 - 3 + expression: "& out" 5 4 --- 6 5 [W15] Warning: Found lib.groupBy 7 6 ╭─[data/faster_groupby.nix:3:7] ··· 17 16 · ─────────┬───────── 18 17 · ╰─────────── Prefer builtins.groupBy over nixpkgs.lib.groupBy 19 18 ───╯ 20 -
+1 -3
bin/tests/snapshots/main__faster_zipattrswith.snap
··· 1 1 --- 2 2 source: bin/tests/main.rs 3 - expression: "&out" 4 - 3 + expression: "& out" 5 4 --- 6 5 [W16] Warning: Found lib.zipAttrsWith 7 6 ╭─[data/faster_zipattrswith.nix:3:7] ··· 17 16 · ────────────┬─────────── 18 17 · ╰───────────── Prefer builtins.zipAttrsWith over nixpkgs.lib.zipAttrsWith 19 18 ───╯ 20 -
+1 -3
bin/tests/snapshots/main__legacy_let_syntax.snap
··· 1 1 --- 2 2 source: bin/tests/main.rs 3 - expression: "&out" 4 - 3 + expression: "& out" 5 4 --- 6 5 [W05] Warning: Using undocumented `let` syntax 7 6 ╭─[data/legacy_let_syntax.nix:1:1] ··· 11 10 · │ 12 11 · ╰─────── Prefer rec over undocumented let syntax 13 12 ───╯ 14 -
+1 -3
bin/tests/snapshots/main__manual_inherit.snap
··· 1 1 --- 2 2 source: bin/tests/main.rs 3 - expression: "&out" 4 - 3 + expression: "& out" 5 4 --- 6 5 [W03] Warning: Assignment instead of inherit 7 6 ╭─[data/manual_inherit.nix:7:3] ··· 10 9 · ───┬── 11 10 · ╰──── This assignment is better written with inherit 12 11 ───╯ 13 -
+1 -3
bin/tests/snapshots/main__manual_inherit_from.snap
··· 1 1 --- 2 2 source: bin/tests/main.rs 3 - expression: "&out" 4 - 3 + expression: "& out" 5 4 --- 6 5 [W04] Warning: Assignment instead of inherit from 7 6 ╭─[data/manual_inherit_from.nix:5:3] ··· 17 16 · ────┬─── 18 17 · ╰───── This assignment is better written with inherit 19 18 ───╯ 20 -
+1 -3
bin/tests/snapshots/main__redundant_pattern_bind.snap
··· 1 1 --- 2 2 source: bin/tests/main.rs 3 - expression: "&out" 4 - 3 + expression: "& out" 5 4 --- 6 5 [W11] Warning: Found redundant pattern bind in function argument 7 6 ╭─[data/redundant_pattern_bind.nix:1:1] ··· 10 9 · ────────┬──────── 11 10 · ╰────────── This pattern bind is redundant, use inputs instead 12 11 ───╯ 13 -
+1 -3
bin/tests/snapshots/main__repeated_keys.snap
··· 1 1 --- 2 2 source: bin/tests/main.rs 3 - expression: "&out" 4 - 3 + expression: "& out" 5 4 --- 6 5 [W20] Warning: Avoid repeated keys in attribute sets 7 6 ╭─[data/repeated_keys.nix:16:5] ··· 29 28 · ──────┬───── 30 29 · ╰─────── ... and here (2 occurrences omitted). Try foo = { baz.bar1=...; baz.bar2=...; baz.bar3=...; } instead. 31 30 ────╯ 32 -
+1 -3
bin/tests/snapshots/main__unquoted_uri.snap
··· 1 1 --- 2 2 source: bin/tests/main.rs 3 - expression: "&out" 4 - 3 + expression: "& out" 5 4 --- 6 5 [W12] Warning: Found unquoted URI expression 7 6 ╭─[data/unquoted_uri.nix:1:1] ··· 10 9 · ────────────┬──────────── 11 10 · ╰────────────── Consider quoting this URI expression 12 11 ───╯ 13 -
+1 -3
bin/tests/snapshots/main__useless_has_attr.snap
··· 1 1 --- 2 2 source: bin/tests/main.rs 3 - expression: "&out" 4 - 3 + expression: "& out" 5 4 --- 6 5 [W19] Warning: This `if` expression can be simplified with `or` 7 6 ╭─[data/useless_has_attr.nix:3:4] ··· 38 37 · ─────────────┬──────────── 39 38 · ╰────────────── Consider using x.a or b.c instead of this if expression 40 39 ───╯ 41 -
+1 -3
bin/tests/snapshots/main__useless_parens.snap
··· 1 1 --- 2 2 source: bin/tests/main.rs 3 - expression: "&out" 4 - 3 + expression: "& out" 5 4 --- 6 5 [W08] Warning: These parentheses can be omitted 7 6 ╭─[data/useless_parens.nix:16:3] ··· 45 44 · ────────┬─────── 46 45 · ╰───────── Useless parentheses around value in binding 47 46 ────╯ 48 -