Lints and suggestions for the Nix programming language
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

chore: 1-expr tests manual-inherit

+43 -41
-12
bin/tests/data/manual_inherit.nix
··· 1 - let 2 - a = 2; 3 - y = "y"; 4 - in 5 - { 6 - # trivial 7 - a = a; 8 - 9 - # don't lint 10 - x.y = y; 11 - } 12 -
-1
bin/tests/main.rs
··· 44 44 } 45 45 46 46 test_lint! { 47 - manual_inherit, 48 47 manual_inherit_from, 49 48 legacy_let_syntax, 50 49 collapsible_let_in,
+13
bin/tests/manual_inherit.rs
··· 1 + mod _utils; 2 + 3 + use macros::generate_tests; 4 + 5 + generate_tests! { 6 + rule: manual_inherit, 7 + expressions: [ 8 + // trivial 9 + "let a = 2; in { a = a; }", 10 + // don't lint 11 + "let y = 2; in { x.y = y; }", 12 + ], 13 + }
-17
bin/tests/snapshots/main__manual_inherit_fix.snap
··· 1 - --- 2 - source: bin/tests/main.rs 3 - expression: "&stdout" 4 - --- 5 - --- tests/data/manual_inherit.nix 6 - +++ tests/data/manual_inherit.nix [fixed] 7 - @@ -3,9 +3,9 @@ 8 - y = "y"; 9 - in 10 - { 11 - # trivial 12 - - a = a; 13 - + inherit a; 14 - 15 - # don't lint 16 - x.y = y; 17 - }
-11
bin/tests/snapshots/main__manual_inherit_lint.snap
··· 1 - --- 2 - source: bin/tests/main.rs 3 - expression: "&stdout" 4 - --- 5 - [W03] Warning: Assignment instead of inherit 6 - ╭─[tests/data/manual_inherit.nix:7:3] 7 - 8 - 7 │ a = a; 9 - · ───┬── 10 - · ╰──── This assignment is better written with inherit 11 - ───╯
+5
bin/tests/snapshots/manual_inherit__fix_287b90d387af9044b772153bd95b398106d6e004717c9530e9aa547ef39a1f20.snap
··· 1 + --- 2 + source: bin/tests/manual_inherit.rs 3 + expression: "\"let y = 2; in { x.y = y; }\"" 4 + --- 5 +
+9
bin/tests/snapshots/manual_inherit__fix_2a92c1cb560d2d727373fb3ad10da2b17cf57a13421fc72f9847d8d25bf8099d.snap
··· 1 + --- 2 + source: bin/tests/manual_inherit.rs 3 + expression: "\"let a = 2; in { a = a; }\"" 4 + --- 5 + --- <temp_file_path> 6 + +++ <temp_file_path> [fixed] 7 + @@ -1 +1 @@ 8 + -let a = 2; in { a = a; } 9 + +let a = 2; in { inherit a; }
+5
bin/tests/snapshots/manual_inherit__lint_287b90d387af9044b772153bd95b398106d6e004717c9530e9aa547ef39a1f20.snap
··· 1 + --- 2 + source: bin/tests/manual_inherit.rs 3 + expression: "\"let y = 2; in { x.y = y; }\"" 4 + --- 5 +
+11
bin/tests/snapshots/manual_inherit__lint_2a92c1cb560d2d727373fb3ad10da2b17cf57a13421fc72f9847d8d25bf8099d.snap
··· 1 + --- 2 + source: bin/tests/manual_inherit.rs 3 + expression: "\"let a = 2; in { a = a; }\"" 4 + --- 5 + [W03] Warning: Assignment instead of inherit 6 + ╭─[<temp_file_path>:1:17] 7 + 8 + 1 │ let a = 2; in { a = a; } 9 + · ───┬── 10 + · ╰──── This assignment is better written with inherit 11 + ───╯