+1 -1

README.md

reviewed

··· 47 47 48 48 ### Working with DMG images 49 49 50 50 - DMG images can be attached and deattached from inside `darling shell` with `hdiutil`. This is how you can install Xcode along with its toolchain and SDKs (note that Xcode itself doesn't run yet): 50 50 + DMG images can be attached and detached from inside `darling shell` with `hdiutil`. This is how you can install Xcode along with its toolchain and SDKs (note that Xcode itself doesn't run yet): 51 51 52 52 ```` 53 53 Darling [~]$ hdiutil attach Xcode_7.2.dmg

+1 -1

src/libsimple/src/lock.c

reviewed

··· 226 226 return; 227 227 }; // not reached 228 228 case libsimple_once_state_triggered_uncontended: { 229 229 - // somebody is already perfoming the callback; 229 229 + // somebody is already performing the callback; 230 230 // now we're waiting, so let's update the state for that 231 231 libsimple_once_debug("someone is already performing the callback with no waiters; becoming first waiter..."); 232 232 exchanged = atomic_compare_exchange_strong_explicit(&once->state, &prev, libsimple_once_state_triggered_contended, memory_order_acq_rel, memory_order_acquire);

+1 -1

src/libsystem_coreservices/dirhelper.c

reviewed

··· 82 82 pthread_mutex_lock(&dir_suffix_lock); 83 83 dir_suffix = suffix; 84 84 pthread_mutex_unlock(&dir_suffix_lock); 85 85 - return 1; // weird, it's suppossed to return non-zero on success (maybe it's actually a bool?) 85 85 + return 1; // weird, it's supposed to return non-zero on success (maybe it's actually a bool?) 86 86 }; 87 87

+1 -1

src/startup/mldr/commpage.c

reviewed

··· 60 60 logcpus = (uint8_t*)CGET(_COMM_PAGE_LOGICAL_CPUS); 61 61 *physcpus = *logcpus = *ncpus; 62 62 63 63 - // I'm not sure if Linux has seperate page sizes for kernel and user space. 63 63 + // I'm not sure if Linux has separate page sizes for kernel and user space. 64 64 // Apple's code uses left shift logical (1 << user_page_shift) to get the page size value. 65 65 // Since it's very unlikely that the page size won't be a power of 2, we can use __builtin_ctzl() 66 66 // as a substitute for log2().

+2 -2

src/startup/mldr/elfcalls/threads.c

reviewed

··· 58 58 uintptr_t arg2; // `stack_addr` for normal threads; `flags` for workqueues 59 59 uintptr_t arg3; // `flags` for normal threads; `nkevents` for workqueues 60 60 union { 61 61 - void* _backwards_compat; // kept around to avoid modifiying assembly 61 61 + void* _backwards_compat; // kept around to avoid modifying assembly 62 62 int port; 63 63 }; 64 64 unsigned long pth_obj_size; ··· 230 230 231 231 // let's check-in with darlingserver on this new thread 232 232 int dummy_stack_variable; 233 233 - // the lifetime pipe fd is ignored as the proces should already have been registered 233 233 + // the lifetime pipe fd is ignored as the process should already have been registered 234 234 if (dserver_rpc_explicit_checkin(t_server_socket, false, &dummy_stack_variable, -1) < 0) { 235 235 // we can't do ANYTHING if darlingserver doesn't acknowledge us successfully 236 236 abort();

+1 -1

src/xtrace/lock.c

reviewed

··· 169 169 return; 170 170 }; // not reached 171 171 case xtrace_once_state_triggered_uncontended: { 172 172 - // somebody is already perfoming the callback; 172 172 + // somebody is already performing the callback; 173 173 // now we're waiting, so let's update the state for that 174 174 xtrace_once_debug("someone is already performing the callback with no waiters; becoming first waiter..."); 175 175 exchanged = atomic_compare_exchange_strong_explicit(&once->state, &prev, xtrace_once_state_triggered_contended, memory_order_acq_rel, memory_order_acquire);

+1 -1

tools/rename-target

reviewed

··· 4 4 import os 5 5 import re 6 6 7 7 - parser = argparse.ArgumentParser(description="Rename a CMake target. Opperates on the current directory.") 7 7 + parser = argparse.ArgumentParser(description="Rename a CMake target. Operates on the current directory.") 8 8 9 9 parser.add_argument("old", help="the target to rename", type=str) 10 10 parser.add_argument("new", help="the new target name", type=str)

+1 -1

tools/stripcomments

reviewed

··· 1 1 #!/bin/sh 2 2 3 3 # This cool can be used to strip most of the copyrightable material from header files. 4 4 - # Remember that all files processed with this script stil need to be checked manually! 4 4 + # Remember that all files processed with this script still need to be checked manually! 5 5 6 6 gcc -DNS_BLOCKS_AVAILABLE -fpreprocessed -dD -E "$1" | egrep -v '# [[:digit:]]' | sed -r 's/APPKIT_EXTERN/EXTERN_C/;s/ ?(NS_AVAILABLE(_MAC)?|NS_DEPRECATED_MAC|NS_CLASS_AVAILABLE)\([^)]+\)//;s/#pragma mark.*//;s/NS_AUTOMATED_REFCOUNT_WEAK_UNAVAILABLE//;s/NS_RETURNS_INNER_POINTER//;s/NS_FORMAT_FUNCTION\(([0-9]+), ?([0-9]+)\)//' 7 7