Bluesky app fork with some witchin' additions 💫
0
fork

Configure Feed

Select the types of activity you want to include in your feed.

Use build arg in docker action to correctly pass git commit SHA (#3940)

* use env variables through docker args

* remove quotes

* use an output instead

* try that again

* write the variables to .env

* rm unused

* use short sha

* remove test branch

authored by

Hailey and committed by
GitHub
1821a992 6e172b6c

+14 -4
+6 -3
.github/workflows/build-and-push-bskyweb-aws.yaml
··· 43 43 tags: | 44 44 type=sha,enable=true,priority=100,prefix=,suffix=,format=long 45 45 46 + - name: Set outputs 47 + id: vars 48 + run: echo "sha_short=$(git rev-parse --short HEAD)" >> $GITHUB_OUTPUT 49 + 46 50 - name: Build and push Docker image 47 51 id: build-and-push 48 52 uses: docker/build-push-action@v4 ··· 54 58 labels: ${{ steps.meta.outputs.labels }} 55 59 cache-from: type=gha 56 60 cache-to: type=gha,mode=max 57 - env: 58 - EXPO_PUBLIC_BUNDLE_IDENTIFIER: $(git rev-parse --short HEAD) 59 - EXPO_PUBLIC_BUNDLE_DATE: $(date -u +"%y%m%d%H") 61 + build-args: | 62 + EXPO_PUBLIC_BUNDLE_IDENTIFIER=${{ steps.vars.outputs.sha_short }}
+8 -1
Dockerfile
··· 15 15 ENV CGO_ENABLED=1 16 16 ENV GOEXPERIMENT="loopvar" 17 17 18 + # Expo 19 + ARG EXPO_PUBLIC_BUNDLE_IDENTIFIER 20 + ENV EXPO_PUBLIC_BUNDLE_IDENTIFIER ${EXPO_PUBLIC_BUNDLE_IDENTIFIER:-dev} 21 + 18 22 COPY . . 19 23 20 24 # ··· 29 33 RUN \. "$NVM_DIR/nvm.sh" && \ 30 34 nvm install $NODE_VERSION && \ 31 35 nvm use $NODE_VERSION && \ 36 + echo "Using bundle identifier: $EXPO_PUBLIC_BUNDLE_IDENTIFIER" && \ 37 + echo "EXPO_PUBLIC_BUNDLE_IDENTIFIER=$EXPO_PUBLIC_BUNDLE_IDENTIFIER" >> .env && \ 38 + echo "EXPO_PUBLIC_BUNDLE_DATE=$(date -u +"%y%m%d%H")" >> .env && \ 32 39 npm install --global yarn && \ 33 40 yarn && \ 34 41 yarn intl:build && \ 35 - yarn build-web 42 + EXPO_PUBLIC_BUNDLE_IDENTIFIER=$EXPO_PUBLIC_BUNDLE_IDENTIFIER EXPO_PUBLIC_BUNDLE_DATE=$() yarn build-web 36 43 37 44 # DEBUG 38 45 RUN find ./bskyweb/static && find ./web-build/static