Bluesky app fork with some witchin' additions 💫
0
fork

Configure Feed

Select the types of activity you want to include in your feed.

Remove unused NoopFeedTuner (#4856)

authored by

dan and committed by
GitHub
c75bb65b c3e77b56

+6 -31
-10
src/lib/api/feed-manip.ts
··· 136 136 } 137 137 } 138 138 139 - export class NoopFeedTuner { 140 - reset() {} 141 - tune( 142 - feed: FeedViewPost[], 143 - _opts?: {dryRun: boolean; maintainOrder: boolean}, 144 - ): FeedViewPostsSlice[] { 145 - return feed.map(item => new FeedViewPostsSlice(item)) 146 - } 147 - } 148 - 149 139 export class FeedTuner { 150 140 seenKeys: Set<string> = new Set() 151 141 seenUris: Set<string> = new Set()
+6 -21
src/state/queries/post-feed.ts
··· 31 31 import {ListFeedAPI} from 'lib/api/feed/list' 32 32 import {MergeFeedAPI} from 'lib/api/feed/merge' 33 33 import {FeedAPI, ReasonFeedSource} from 'lib/api/feed/types' 34 - import {FeedTuner, FeedTunerFn, NoopFeedTuner} from 'lib/api/feed-manip' 34 + import {FeedTuner, FeedTunerFn} from 'lib/api/feed-manip' 35 35 import {BSKY_FEED_OWNER_DIDS} from 'lib/constants' 36 36 import {KnownError} from '#/view/com/posts/FeedErrorMessage' 37 37 import {useFeedTuners} from '../preferences/feed-tuners' ··· 61 61 | `list|${ListUri}` 62 62 | `list|${ListUri}|${ListFilter}` 63 63 export interface FeedParams { 64 - disableTuner?: boolean 65 64 mergeFeedEnabled?: boolean 66 65 mergeFeedSources?: string[] 67 66 } ··· 105 104 106 105 export interface FeedPage { 107 106 api: FeedAPI 108 - tuner: FeedTuner | NoopFeedTuner 107 + tuner: FeedTuner 109 108 cursor: string | undefined 110 109 slices: FeedPostSlice[] 111 110 fetchedAt: number ··· 142 141 const selectArgs = React.useMemo( 143 142 () => ({ 144 143 feedTuners, 145 - disableTuner: params?.disableTuner, 146 144 moderationOpts, 147 145 ignoreFilterFor: opts?.ignoreFilterFor, 148 146 isDiscover, 149 147 }), 150 - [ 151 - feedTuners, 152 - params?.disableTuner, 153 - moderationOpts, 154 - opts?.ignoreFilterFor, 155 - isDiscover, 156 - ], 148 + [feedTuners, moderationOpts, opts?.ignoreFilterFor, isDiscover], 157 149 ) 158 150 159 151 const query = useInfiniteQuery< ··· 232 224 (data: InfiniteData<FeedPageUnselected, RQPageParam>) => { 233 225 // If the selection depends on some data, that data should 234 226 // be included in the selectArgs object and read here. 235 - const { 236 - feedTuners, 237 - disableTuner, 238 - moderationOpts, 239 - ignoreFilterFor, 240 - isDiscover, 241 - } = selectArgs 227 + const {feedTuners, moderationOpts, ignoreFilterFor, isDiscover} = 228 + selectArgs 242 229 243 - const tuner = disableTuner 244 - ? new NoopFeedTuner() 245 - : new FeedTuner(feedTuners) 230 + const tuner = new FeedTuner(feedTuners) 246 231 247 232 // Keep track of the last run and whether we can reuse 248 233 // some already selected pages from there.